Skip to content
Snippets Groups Projects
  1. Dec 24, 2019
    • Peter Josef Scheibel's avatar
    • Peter Josef Scheibel's avatar
      Mirrors: skip attempts to fetch BundlePackages · 587c650b
      Peter Josef Scheibel authored
      BundlePackages use a noop fetch strategy. The mirror logic was assuming
      that the fetcher had a resource to cach after performing a fetch. This adds
      a special check to skip caching if the stage is associated with a
      BundleFetchStrategy. Note that this should allow caching resources
      associated with BundlePackages.
      Unverified
      587c650b
    • Peter Josef Scheibel's avatar
      Mirrors: avoid re-downloading patches · d7142862
      Peter Josef Scheibel authored
      When updating a mirror, Spack was re-retrieving all patches (since the
      fetch logic for patches is separate). This updates the patch logic to
      allow the mirror logic to avoid this.
      Unverified
      d7142862
    • Peter Josef Scheibel's avatar
      Mirrors: perform checksum of fetched sources · a69b3c85
      Peter Josef Scheibel authored
      Since cache_mirror does the fetch itself, it also needs to do the
      checksum itself if it wants to verify that the source stored in the
      mirror is valid. Note that this isn't strictly required because fetching
      (including from mirrors) always separately verifies the checksum.
      Unverified
      a69b3c85
    • Peter Josef Scheibel's avatar
      Mirrors: fix cosmetic symlink targets · 98b498c6
      Peter Josef Scheibel authored
      The targets for the cosmetic paths in mirrrors were being calculated
      incorrectly as of fb3a3ba9: the symlinks used relative paths as targets,
      and the relative path was computed relative to the wrong directory.
      Unverified
      98b498c6
    • Peter Josef Scheibel's avatar
      Allow repeated invocations of 'mirror create' · 64209dda
      Peter Josef Scheibel authored
      When creating a cosmetic symlink for a resource in a mirror, remove
      it if it already exists. The symlink is removed in case the logic to
      create the symlink has changed.
      Unverified
      64209dda
    • Paul Ferrell's avatar
      mirror bug fixes: symlinks, duplicate patch names, and exception handling (#13789) · c15e55c6
      Paul Ferrell authored
      * Some packages (e.g. mpfr at the time of this patch) can have patches
        with the same name but different contents (which apply to different
        versions of the package). This appends part of the patch hash to the
        cache file name to avoid conflicts.
      * Some exceptions which occur during fetching are not a subclass of
        SpackError and therefore do not have a 'message' attribute. This
        updates the logic for mirroring a single spec (add_single_spec)
        to produce an appropriate error message in that case (where before
        it failed with an AttributeError)
      * In various circumstances, a mirror can contain the universal storage
        path but not a cosmetic symlink; in this case it would not generate
        a symlink. Now "spack mirror create" will create a symlink for any
        package that doesn't have one.
      Unverified
      c15e55c6
  2. Dec 05, 2019
  3. Dec 02, 2019
  4. Nov 17, 2019
  5. Nov 15, 2019
  6. Nov 14, 2019
  7. Nov 05, 2019
  8. Nov 04, 2019
    • Omar Padron's avatar
      bugfix: fetch prefers to fetch local mirrors over remote resources (#13545) · edf95483
      Omar Padron authored
      - [x] insert at beginning of list so fetch grabs local mirrors before remote resources
      - [x] update the S3FetchStrategy so that it throws a SpackError if the fetch fails.  
            Before, it was throwing URLError, which was not being caught in stage.py.
      - [x] move error handling out of S3FetchStrategy and into web_util.read_from_url()
      - [x] pass string instead of URLError to SpackWebError
      Unverified
      edf95483
  9. Nov 03, 2019
    • Greg Becker's avatar
      environments: only write when necessary (#13546) · 7cdb241f
      Greg Becker authored
      This changes Spack environments so that the YAML file associated with the environment is *only* written when necessary (i.e., if it is changed *by spack*).  The lockfile is still written out as before.
      
      There is a larger question here of which part of Spack should be responsible for setting defaults in config files, and how we can get rid of empty lists and data structures currently cluttering files like `compilers.yaml`.  But that probably requires a rework of the default-setting validator in `spack.config`, as well as the code that uses `spack.config`.  This will at least help for `spack.yaml`.
      Unverified
      7cdb241f
  10. Nov 01, 2019
  11. Oct 31, 2019
  12. Oct 26, 2019
Loading