Skip to content
Snippets Groups Projects
  1. Oct 24, 2014
  2. Oct 10, 2014
  3. Oct 04, 2014
  4. Sep 26, 2014
  5. Sep 21, 2014
  6. Sep 15, 2014
  7. Sep 12, 2014
  8. Sep 10, 2014
  9. Sep 09, 2014
  10. Sep 08, 2014
  11. Sep 06, 2014
  12. Sep 05, 2014
  13. Sep 04, 2014
  14. Sep 02, 2014
    • Mark Jones's avatar
      Add "+1" to length when using new char[] · 085928d1
      Mark Jones authored
      Found when doing valgrind --tool=memcheck --track-origins=yes --leak-check=full hcana
      Return errors like below
      ==14467== Invalid write of size 1
      ==14467==    at 0x4A0794F: __GI_strcpy (mc_replace_strmem.c:313)
      ==14467==    by 0x57137A3: THcHodoscope::Setup(char const*, char const*) (THcHodoscope.cxx:112)
      ==14467==    by 0x5713A7E: THcHodoscope::Init(TDatime const&) (THcHodoscope.cxx:142)
      ==14467==    by 0x4D38C29: THaApparatus::Init(TDatime const&) (THaApparatus.C:193)
      ==14467==    by 0x4D67E57: THaAnalyzer::InitModules(TList const*, TDatime&, int, char const*) (THaAnalyzer.C:433)
      ==14467==    by 0x4D68B1F: THaAnalyzer::DoInit(THaRunBase*) (THaAnalyzer.C:667)
      ==14467==    by 0x4D68126: THaAnalyzer::Init(THaRunBase*) (THaAnalyzer.C:467)
      ==14467==    by 0x4D6B31A: THaAnalyzer::Process(THaRunBase*) (THaAnalyzer.C:1289)
      ==14467==    by 0x4E21E97: G__haDict_704_0_6(G__value*, char const*, G__param*, int) (haDict.C:23491)
      ==14467==    by 0x6DB6148: Cint::G__ExceptionWrapper(int (*)(G__value*, char const*, G__param*, int), G__value*, char*, G__param*, int) (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34)
      ==14467==    by 0x6E5A3A0: G__execute_call (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34)
      ==14467==    by 0x6E5B201: G__call_cppfunc (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34)
      ==14467==  Address 0xd7636a2 is 0 bytes after a block of size 2 alloc'd
      ==14467==    at 0x4A0674C: operator new[](unsigned long) (vg_replace_malloc.c:305)
      ==14467==    by 0x5713757: THcHodoscope::Setup(char const*, char const*) (THcHodoscope.cxx:111)
      ==14467==    by 0x5713A7E: THcHodoscope::Init(TDatime const&) (THcHodoscope.cxx:142)
      ==14467==    by 0x4D38C29: THaApparatus::Init(TDatime const&) (THaApparatus.C:193)
      ==14467==    by 0x4D67E57: THaAnalyzer::InitModules(TList const*, TDatime&, int, char const*) (THaAnalyzer.C:433)
      ==14467==    by 0x4D68B1F: THaAnalyzer::DoInit(THaRunBase*) (THaAnalyzer.C:667)
      ==14467==    by 0x4D68126: THaAnalyzer::Init(THaRunBase*) (THaAnalyzer.C:467)
      ==14467==    by 0x4D6B31A: THaAnalyzer::Process(THaRunBase*) (THaAnalyzer.C:1289)
      ==14467==    by 0x4E21E97: G__haDict_704_0_6(G__value*, char const*, G__param*, int) (haDict.C:23491)
      ==14467==    by 0x6DB6148: Cint::G__ExceptionWrapper(int (*)(G__value*, char const*, G__param*, int), G__value*, char*, G__param*, int) (in /u/apps/root/5
      085928d1
    • Mark Jones's avatar
      Fix problem with uninitialized variables used in THcHodoscope::Clear · d276508b
      Mark Jones authored
      THcHodoscope::Clear is called at beginning of analysis before ReadDatabase and Init methods
      and therefore  MAXHODHITS and fNPlanes are uninitiated.
      Change Clear to ClearEvent
      Add call to ClearEvent in Decode
      Eliminate Clear method in THcHodoscope.h
      d276508b
  15. Aug 30, 2014
  16. Aug 29, 2014
  17. Aug 28, 2014
  18. Aug 25, 2014
  19. Aug 22, 2014
  20. Aug 21, 2014
    • Zafar's avatar
      Golden track: · 0854d6f9
      Zafar authored
      Goldent track is moved to THcHallCSpectrometer::TrackCalc()
        if  fSelUsingScin == 0 then golden track is calculated just
        like podd. i.e. it is the first track with minimum chi2/ndf
        with sorting ON
      
        if fSelUsingScin == 1 then golden track is calculetd just like
        engine/HTRACKING/h_select_best_track_using_scin.h. This method
        gives the best track with minimum value of chi2/ndf but with
        additional cuts on the tracks. These cuts are on dedx, beta
        and on energy.
      
        This commit also corrects and modifies the beta code written
        in the THcHodoscope::FineProcess
      
        At this point we have godlend track and in additoion to
        previous vlues the following values are set to a track:
        Energy, beta, chi2 of beta and dedx[track][first hit].
      
      NOTE: For some tracks we have large differences in value of chi
            square between ENGINE and hcana and this is already
            discussed in the last group meeting. Following emails are
            exchanged regarding this difference of chisquare.
      
      email to Mark:
      
      Hi Mark,
      I tried to trace the origin of difference of the chi square value between
      ENGINE and hcana. Please see the attached file, it has long table which I
      cannot present in this email. Or you can see the file at the following
      link, thanks.
      
      https://userweb.jlab.org/~zahmed/chi2diff.txt
      
      Ahmed
      
      Mark's reply:
      Ahmed,
              Thanks. I agree with what you see, but there is also another reason
      for the difference. For the space point in ch2 the engine and hcana
      choose different left/right combinations. That is why you see the large
      jump in the summed chi2 from planes 9 and 10. The two codes pick
      different left/right because there is a cut on the difference between the
      measured stub xp and an expected xp = sp->GetX()/875  and one code has a combination
      slightly below the cut value and the other slightly above. I do not see a way
      to make the codes agree more exactly since the stub fitting involves a matrix
      inversion.
      
                      Cheers,
                             Mark
      0854d6f9
    • Zafar's avatar
      Golden track: · cf4b23b2
      Zafar authored
      Goldent track is moved to THcHallCSpectrometer::TrackCalc()
        if  fSelUsingScin == 0 then golden track is calculated just
        like podd. i.e. it is the first track with minimum chi2/ndf
        with sorting ON
      
        if fSelUsingScin == 1 then golden track is calculetd just like
        engine/HTRACKING/h_select_best_track_using_scin.h. This method
        gives the best track with minimum value of chi2/ndf but with
        additional cuts on the tracks. These cuts are on dedx, beta
        and on energy.
      
        This commit also corrects and modifies the beta code written
        in the THcHodoscope::FineProcess
      
        At this point we have godlend track and in additoion to
        previous vlues the following values are set to a track:
        Energy, beta, chi2 of beta and dedx[track][first hit].
      
      NOTE: For some tracks we have large differences in value of chi
            square between ENGINE and hcana and this is already
            discussed in the last group meeting. Following emails are
            exchanged regarding this difference of chisquare.
      
      email to Mark:
      
      Hi Mark,
      I tried to trace the origin of difference of the chi square value between
      ENGINE and hcana. Please see the attached file, it has long table which I
      cannot present in this email. Or you can see the file at the following
      link, thanks.
      
      https://userweb.jlab.org/~zahmed/chi2diff.txt
      
      Ahmed
      
      Mark's reply:
      Ahmed,
              Thanks. I agree with what you see, but there is also another reason
      for the difference. For the space point in ch2 the engine and hcana
      choose different left/right combinations. That is why you see the large
      jump in the summed chi2 from planes 9 and 10. The two codes pick
      different left/right because there is a cut on the difference between the
      measured stub xp and an expected xp = sp->GetX()/875  and one code has a combination
      slightly below the cut value and the other slightly above. I do not see a way
      to make the codes agree more exactly since the stub fitting involves a matrix
      inversion.
      
                      Cheers,
                             Mark
      cf4b23b2
  21. Aug 20, 2014
  22. Aug 19, 2014
    • Zafar's avatar
      Golden track. · f5da09b2
      Zafar authored
        Goldent track is moved to THcHallCSpectrometer::TrackCalc()
        if  fSelUsingScin == 0 then golden track is calculated just
        like podd. i.e. it is the first track with minimum chi2/ndf
        with sorting ON
      
        if fSelUsingScin == 1 then golden track is calculetd just like
        engine/HTRACKING/h_select_best_track_using_scin.h. This method
        gives the best track with minimum value of chi2/ndf but with
        additional cuts on the tracks. These cuts are on dedx, beta
        and on energy.
      
        This commit also corrects and modifies the beta code written
        in the THcHodoscope::FineProcess
      
        At this point we have godlend track and in additoion to
        previous vlues the following values are set to a track:
        Energy, beta, chi2 of beta and dedx[track][first hit].
      
      NOTE: For some tracks we have large differences in value of chi
            square between ENGINE and hcana and this is already
            discussed in the last group meeting. Following emails are
            exchanged regarding this difference of chisquare.
      
      email to Mark:
      
      Hi Mark,
      I tried to trace the origin of difference of the chi square value between
      ENGINE and hcana. Please see the attached file, it has long table which I
      cannot present in this email. Or you can see the file at the following
      link, thanks.
      
      https://userweb.jlab.org/~zahmed/chi2diff.txt
      
      Ahmed
      
      Mark's reply:
      Ahmed,
              Thanks. I agree with what you see, but there is also another reason
      for the difference. For the space point in ch2 the engine and hcana
      choose different left/right combinations. That is why you see the large
      jump in the summed chi2 from planes 9 and 10. The two codes pick
      different left/right because there is a cut on the difference between the
      measured stub xp and an expected xp = sp->GetX()/875  and one code has a combination
      slightly below the cut value and the other slightly above. I do not see a way
      to make the codes agree more exactly since the stub fitting involves a matrix
      inversion.
      
                      Cheers,
                             Mark
      
      ---------------------------------------------------------------------------------------
      f5da09b2
    • Zafar's avatar
      Beta: · f55341ed
      Zafar authored
      This commmit is only for Beta. THcHodoscope is modified and few
      bugs are fixed. I will not make pull request for this commit.
      Pull request will be made after the completion of Golden track
      in THcHallCSpectrometer.
      f55341ed
  23. Aug 18, 2014
Loading