- Sep 02, 2014
-
-
Mark Jones authored
Found when doing valgrind --tool=memcheck --track-origins=yes --leak-check=full hcana Return errors like below ==14467== Invalid write of size 1 ==14467== at 0x4A0794F: __GI_strcpy (mc_replace_strmem.c:313) ==14467== by 0x57137A3: THcHodoscope::Setup(char const*, char const*) (THcHodoscope.cxx:112) ==14467== by 0x5713A7E: THcHodoscope::Init(TDatime const&) (THcHodoscope.cxx:142) ==14467== by 0x4D38C29: THaApparatus::Init(TDatime const&) (THaApparatus.C:193) ==14467== by 0x4D67E57: THaAnalyzer::InitModules(TList const*, TDatime&, int, char const*) (THaAnalyzer.C:433) ==14467== by 0x4D68B1F: THaAnalyzer::DoInit(THaRunBase*) (THaAnalyzer.C:667) ==14467== by 0x4D68126: THaAnalyzer::Init(THaRunBase*) (THaAnalyzer.C:467) ==14467== by 0x4D6B31A: THaAnalyzer::Process(THaRunBase*) (THaAnalyzer.C:1289) ==14467== by 0x4E21E97: G__haDict_704_0_6(G__value*, char const*, G__param*, int) (haDict.C:23491) ==14467== by 0x6DB6148: Cint::G__ExceptionWrapper(int (*)(G__value*, char const*, G__param*, int), G__value*, char*, G__param*, int) (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34) ==14467== by 0x6E5A3A0: G__execute_call (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34) ==14467== by 0x6E5B201: G__call_cppfunc (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34) ==14467== Address 0xd7636a2 is 0 bytes after a block of size 2 alloc'd ==14467== at 0x4A0674C: operator new[](unsigned long) (vg_replace_malloc.c:305) ==14467== by 0x5713757: THcHodoscope::Setup(char const*, char const*) (THcHodoscope.cxx:111) ==14467== by 0x5713A7E: THcHodoscope::Init(TDatime const&) (THcHodoscope.cxx:142) ==14467== by 0x4D38C29: THaApparatus::Init(TDatime const&) (THaApparatus.C:193) ==14467== by 0x4D67E57: THaAnalyzer::InitModules(TList const*, TDatime&, int, char const*) (THaAnalyzer.C:433) ==14467== by 0x4D68B1F: THaAnalyzer::DoInit(THaRunBase*) (THaAnalyzer.C:667) ==14467== by 0x4D68126: THaAnalyzer::Init(THaRunBase*) (THaAnalyzer.C:467) ==14467== by 0x4D6B31A: THaAnalyzer::Process(THaRunBase*) (THaAnalyzer.C:1289) ==14467== by 0x4E21E97: G__haDict_704_0_6(G__value*, char const*, G__param*, int) (haDict.C:23491) ==14467== by 0x6DB6148: Cint::G__ExceptionWrapper(int (*)(G__value*, char const*, G__param*, int), G__value*, char*, G__param*, int) (in /u/apps/root/5
-
Mark Jones authored
THcHodoscope::Clear is called at beginning of analysis before ReadDatabase and Init methods and therefore MAXHODHITS and fNPlanes are uninitiated. Change Clear to ClearEvent Add call to ClearEvent in Decode Eliminate Clear method in THcHodoscope.h
-
- Aug 30, 2014
-
-
Zafar authored
Hardwired numbers are fixed in THcHallcSpectrometer class. Generalized functions for center of hodoscope planes and their spacings are defined.
-
- Aug 29, 2014
-
-
Mark K Jones authored
Crashfixes0828
-
Stephen A. Wood authored
-
- Aug 28, 2014
-
-
Stephen A. Wood authored
-
- Aug 25, 2014
-
-
Stephen A. Wood authored
-
- Aug 22, 2014
-
-
Mark K Jones authored
Zafar a2 Golden Track
-
- Aug 21, 2014
-
-
Zafar authored
Goldent track is moved to THcHallCSpectrometer::TrackCalc() if fSelUsingScin == 0 then golden track is calculated just like podd. i.e. it is the first track with minimum chi2/ndf with sorting ON if fSelUsingScin == 1 then golden track is calculetd just like engine/HTRACKING/h_select_best_track_using_scin.h. This method gives the best track with minimum value of chi2/ndf but with additional cuts on the tracks. These cuts are on dedx, beta and on energy. This commit also corrects and modifies the beta code written in the THcHodoscope::FineProcess At this point we have godlend track and in additoion to previous vlues the following values are set to a track: Energy, beta, chi2 of beta and dedx[track][first hit]. NOTE: For some tracks we have large differences in value of chi square between ENGINE and hcana and this is already discussed in the last group meeting. Following emails are exchanged regarding this difference of chisquare. email to Mark: Hi Mark, I tried to trace the origin of difference of the chi square value between ENGINE and hcana. Please see the attached file, it has long table which I cannot present in this email. Or you can see the file at the following link, thanks. https://userweb.jlab.org/~zahmed/chi2diff.txt Ahmed Mark's reply: Ahmed, Thanks. I agree with what you see, but there is also another reason for the difference. For the space point in ch2 the engine and hcana choose different left/right combinations. That is why you see the large jump in the summed chi2 from planes 9 and 10. The two codes pick different left/right because there is a cut on the difference between the measured stub xp and an expected xp = sp->GetX()/875 and one code has a combination slightly below the cut value and the other slightly above. I do not see a way to make the codes agree more exactly since the stub fitting involves a matrix inversion. Cheers, Mark
-
Zafar authored
Goldent track is moved to THcHallCSpectrometer::TrackCalc() if fSelUsingScin == 0 then golden track is calculated just like podd. i.e. it is the first track with minimum chi2/ndf with sorting ON if fSelUsingScin == 1 then golden track is calculetd just like engine/HTRACKING/h_select_best_track_using_scin.h. This method gives the best track with minimum value of chi2/ndf but with additional cuts on the tracks. These cuts are on dedx, beta and on energy. This commit also corrects and modifies the beta code written in the THcHodoscope::FineProcess At this point we have godlend track and in additoion to previous vlues the following values are set to a track: Energy, beta, chi2 of beta and dedx[track][first hit]. NOTE: For some tracks we have large differences in value of chi square between ENGINE and hcana and this is already discussed in the last group meeting. Following emails are exchanged regarding this difference of chisquare. email to Mark: Hi Mark, I tried to trace the origin of difference of the chi square value between ENGINE and hcana. Please see the attached file, it has long table which I cannot present in this email. Or you can see the file at the following link, thanks. https://userweb.jlab.org/~zahmed/chi2diff.txt Ahmed Mark's reply: Ahmed, Thanks. I agree with what you see, but there is also another reason for the difference. For the space point in ch2 the engine and hcana choose different left/right combinations. That is why you see the large jump in the summed chi2 from planes 9 and 10. The two codes pick different left/right because there is a cut on the difference between the measured stub xp and an expected xp = sp->GetX()/875 and one code has a combination slightly below the cut value and the other slightly above. I do not see a way to make the codes agree more exactly since the stub fitting involves a matrix inversion. Cheers, Mark
-
- Aug 20, 2014
-
-
Zafar authored
Bugs fixed.
-
- Aug 19, 2014
-
-
Zafar authored
Goldent track is moved to THcHallCSpectrometer::TrackCalc() if fSelUsingScin == 0 then golden track is calculated just like podd. i.e. it is the first track with minimum chi2/ndf with sorting ON if fSelUsingScin == 1 then golden track is calculetd just like engine/HTRACKING/h_select_best_track_using_scin.h. This method gives the best track with minimum value of chi2/ndf but with additional cuts on the tracks. These cuts are on dedx, beta and on energy. This commit also corrects and modifies the beta code written in the THcHodoscope::FineProcess At this point we have godlend track and in additoion to previous vlues the following values are set to a track: Energy, beta, chi2 of beta and dedx[track][first hit]. NOTE: For some tracks we have large differences in value of chi square between ENGINE and hcana and this is already discussed in the last group meeting. Following emails are exchanged regarding this difference of chisquare. email to Mark: Hi Mark, I tried to trace the origin of difference of the chi square value between ENGINE and hcana. Please see the attached file, it has long table which I cannot present in this email. Or you can see the file at the following link, thanks. https://userweb.jlab.org/~zahmed/chi2diff.txt Ahmed Mark's reply: Ahmed, Thanks. I agree with what you see, but there is also another reason for the difference. For the space point in ch2 the engine and hcana choose different left/right combinations. That is why you see the large jump in the summed chi2 from planes 9 and 10. The two codes pick different left/right because there is a cut on the difference between the measured stub xp and an expected xp = sp->GetX()/875 and one code has a combination slightly below the cut value and the other slightly above. I do not see a way to make the codes agree more exactly since the stub fitting involves a matrix inversion. Cheers, Mark ---------------------------------------------------------------------------------------
-
Zafar authored
This commmit is only for Beta. THcHodoscope is modified and few bugs are fixed. I will not make pull request for this commit. Pull request will be made after the completion of Golden track in THcHallCSpectrometer.
-
- Aug 18, 2014
-
-
Vardan Tadevosyan authored
shower counter's FineProcess. Remove THcHallCSpectrometer::TrackEnergies method. Add GetShEnergy call for each tack in THcShower::fineProcess.
-
Vardan Tadevosyan authored
memory consumption with event number. Add THcShowerClusterList::purge() method to purge and clean THcShower::fClusterList by the end of each event, in THcShower::Clear().
-
Vardan Tadevosyan authored
crashes.
-
Vardan Tadevosyan authored
Add TrackEnergies method in THcHallCSpectrometer class. It is called from TrackCalc metod.
-
Vardan Tadevosyan authored
calorimeter. Add list of clusters fClusterList in THcShower class. Add method THcShower::GetShEnergy(THaTrack*). Add method THcShowerClusterList::clear() in THcShowerCluster.h.
-
Vardan Tadevosyan authored
Increment fNtracks++ each time a cluster matches a spectrometer track. Only best matches were counted before. Move fNtracks++ from THcShower::CoarceProcess to THcShower:MatchCluster.
-
Vardan Tadevosyan authored
In hcal_calib/hcal_replay_cuts.def: add one_clust condition; activate good_beta condition (defined for run 52949); define 2 versions of the Reconstruct_master cut, one for initial calibration and another for iterative calibration.
-
Stephen A. Wood authored
-
- Jul 30, 2014
-
-
Mark K Jones authored
Created two new variables for THcDC, fNthits and fN_True_RawHits.
-
Jonathan Stelzleni authored
In tree they are called tnhit and trawhit. Created two new variables for THcDriftChamber, fNthits and fN_True_RawHits. In tree they are called tnhit and trawhit. THcDC defined subdetector THcDriftChamber to have name Ch1 and Ch2 to do used in the tree. THcDriftChamberPlane defined new method GetNRawhits to return fNRawhits for each plane. Added member fNRawhits to THcDriftChamberPlane
-
- Jul 16, 2014
-
-
Zafar Ahmed authored
Time difference variables now defined in output.def
-
- Jul 09, 2014
-
-
Vardan Tadevosyan authored
Remove track related variables from the HMS Shower class, use ntuples from the track (H.tr) block instead in the HMS calorimeter calibration scripts. - Remove a block of duplicated track related variables from the THcShower class which have been added for calorimeter calibration purposes. - In hcal_calib directory, replace those variables with correspondent variables from H.tr block in the calorimeter calibration class (THcShowerCalib.h), in the cut (hcal_replay_cuts.def) and output (output_hcal_replay.def) definitions.
-
Zafar Ahmed authored
Compute time differences between planes Calculate beta and Chisquard for each track in the hodoscope. New variables: fBeta, fBetaChisq New histograms for time differences
-
- Jun 18, 2014
-
-
Stephen A. Wood authored
-
- Jun 17, 2014
-
-
Zafar Ahmed authored
Conversion of h_tof.f to THcHodoscope::CoarseProcess method. Quick summary of third version at branch zafar1: New functions in THcScintillatorPlane.h --------------------------------------- TClonesArray* GetPosADC() { return fPosADCHits;}; // Ahmed TClonesArray* GetNegADC() { return fNegADCHits;}; // Ahmed TClonesArray* GetPosTDC() { return fPosTDCHits;}; // Ahmed TClonesArray* GetNegTDC() { return fNegTDCHits;}; // Ahmed New data members in THcHodoscope.h ---------------------------------- TClonesArray* scinPosADC; // Ahmed TClonesArray* scinNegADC; // Ahmed TClonesArray* scinPosTDC; // Ahmed TClonesArray* scinNegTDC; // Ahmed Action in THcHodoscope::CoarseProcess ------------------------------------- scinPosADC = fPlanes[ip]-GetPosADC(); hitPaddle = (THcSignalHit*)scinPosADC->At(ihit))->GetPaddleNumber()-1;
-
- May 07, 2014
-
-
Mark Jones authored
-
Buddhini Waidyawansa authored
Fixed the wrong raster channel assignment in raster_jun04.map. The X and Y channels needed to be switched. In both map files, changed the plane assignments of all the raster channels to be 1 instead of 1,2,3,4. This then follows the ENGINE convention.
-
- May 06, 2014
-
-
Mark Jones authored
-
Mark Jones authored
-
- May 05, 2014
-
-
Buddhini Waidyawansa authored
Added the raw raster ADC values to the histos and trees. Modified the ranges and binning of the histogram definitions in output_bpw_.def accordingly.
-
Buddhini Waidyawansa authored
This is a script created by Stephen Wood to convert engine type channel maps into hcana type mapfiles. Right now, this is only used when doing hcana and engine comparision for the raster.
-
Buddhini Waidyawansa authored
In raster_jun04.map, reassigned the raster channels into a single plane instead of different planes. This makes it easier for comparision with the engine. Modified raster_test.C to analyze run 52947 in the cache directory. Some minor clean up in the THcRaster.cxx class- removing comments and unused variables.
-
- Apr 28, 2014
-
-
Stephen A. Wood authored
-
Stephen A. Wood authored
Don't put [1] at end of variable name as is done with numerical parameters with Define. Use new CCDB methods to get table row and column counts
-
Stephen A. Wood authored
-
- Apr 25, 2014
-
-
Buddhini Waidyawansa authored
-
Mark K Jones authored
detector map file for jan05 data taking
-