Skip to content
Snippets Groups Projects
  1. Jan 29, 2018
    • Massimiliano Culpo's avatar
      Mark slow unit tests (#6994) · 7368586f
      Massimiliano Culpo authored
      * Marking database tests as slow
      
      * Marking url command tests as slow
      
      * Marking every test that uses database as slow
      
      * Marking tests that import files as slow
      
      * Marking gpg tests as slow
      
      * Marking all versions and one list tests as slow
      
      * Added more markers to unit tests + cli option to skip slow tests
      
      Following a discussion with Axel, the generic 'slowtest' marker has been
      split into 'db', 'network' and 'maybeslow'. A brief description of the
      meaning of each marker has been added to pytest.ini.
      
      A command line option to run only fast tests has been added to
      'spack test'
      
      * Don't use classes to group tests together
      
      Reverted grouping tests under a class, as required in the review
      
      * Minor style changes
      7368586f
    • Peter Scheibel's avatar
      Remove Package instance caching in Repo (#6367) · f27c5e74
      Peter Scheibel authored
      This attempts to address one of the complaints at #5996 (comment):
      
      > Repo currently caches package instances by Spec, and those Package instances have a Spec. 
      > This is unnecessary and causes confusion. I think I thought that we'd need to cache instances 
      > after loading package classes, but really just caching the classes is fine.
      
      With this update, Repo's package cache is removed and Specs cache the package reference themselves. One consequence is that Specs which compare as equal will store separate instances of a Package class (not doing this creates issues for #4595 (comment)).
      
      There were several references to Spec.package that could be replaced with Spec.package_class without any additional modifications. There are still a couple remaining references to Spec.package in Spec that would require adding functionality before replacing (e.g. calling Package.provides and Package.installed).
      
      Note this makes it difficult to mock fetchers for tests which invokes code that reconstructs specs. test_packaging was one example of this where the updates caused a failure (in that case the error was avoided by not making an unnecessary call).
      
      Details:
      * Replace instances of spec.package with spec.package_class where a class method is being called
      * Remove instances of Repo.get where Spec.package_class can be used in its place
      * remove Repo.get caching instances of Package class for specs
      * remove redundant check (which is also incorrect now that each spec stores its own copy of its package)
      * avoid creating mirror with specs because it copies specs and those copies dont refer to the mocked fetcher (and it is also not required for the test)
      * remove checks that are no longer necessary since repo doesn't cache specs
      f27c5e74
    • Adam J. Stewart's avatar
      Fix gfortran 7 detection (#7017) · f7f4bae1
      Adam J. Stewart authored
      f7f4bae1
  2. Jan 28, 2018
    • Massimiliano Culpo's avatar
      Cleaned up JUnit report generation on install (#6977) · 5af9256d
      Massimiliano Culpo authored
      * Cleaned up JUnit report generation on install
      
      The generation of a JUnit report was previously part of the install
      command. This commit factors the logic into its own module, and uses
      a template for the generation of the report.
      
      It also improves report generation, that now can deal with multiple
      specs installed at once. Finally, extending the list of supported
      formats is much easier than before, as it entails just writing a
      new template.
      
      * Polished report generation + added tests for failures and errors
      
      The generation of a JUnit report has been polished, so that the
      stacktrace is correctly displayed with Jenkins JUnit plugin. Standard
      error is still not used.
      
      Added unit tests to cover for installation failures and installation
      errors.
      5af9256d
    • Geoffrey Oxberry's avatar
      libtool, binutils: fix darwin linking (#7073) · 784234ae
      Geoffrey Oxberry authored
      * libtool: fix linking of libtool on darwin
      
      * binutils, libtool: fix conflicts w/ BSD tools, v2
      
      Fix namespace conflicts with BSD tools in a more elegant fashion,
      using a program prefix, similar to Homebrew.
      784234ae
  3. Jan 27, 2018
  4. Jan 26, 2018
  5. Jan 25, 2018
    • Brian Van Essen's avatar
      Protobuf package: allow building shared library (#7067) · 8bc5916b
      Brian Van Essen authored
      This adds a +shared variant for building shared libraries in the
      protobuf package and enables it by default.
      8bc5916b
    • Brian Van Essen's avatar
      Lbann package: bug fix (#7066) · 82d4d58c
      Brian Van Essen authored
      Fixed a bug in the guard on cub functionality.  Reduced the
      requirements on hwloc to make it simpler to build on Power systems.
      82d4d58c
    • Axel Huebl's avatar
      Python Installs: No User Site Dir (#7065) · 85c887a9
      Axel Huebl authored
      Avoid adding an "outside" (local home's) python user site directory
      during python package installs.
      
      Implements #6611
      
      Fixes packages with auto-find side effects such as `py-setuptools`
      that cause `py-matplotlib` to fail to build #6558
      85c887a9
    • Geoffrey Oxberry's avatar
      libtool: symlink libtool{ize} to glibtool{ize} (#7060) · e0082e05
      Geoffrey Oxberry authored
      On Darwin and other BSD systems, the system 'libtool' and 'libtoolize'
      are BSD libtool and libtoolize, respectively. Some build systems
      require the GNU versions of these commands, so BSD package systems
      tend to name the GNU versions 'glibtool' and 'glibtoolize',
      respectively, to avoid namespace collisions.
      
      A problem with the current libtool package is that it installs the GNU
      libtool commands as 'libtool' and 'libtoolize', respectively, but
      build systems on BSD platforms will attempt to run 'glibtool' and
      'glibtoolize'. The expedient solution to this problem is to symlink
      'libtool' to 'glibtool' and 'libtoolize' to 'glibtoolize', because
      attempting to patch the detection logic one build system at a time
      seems impractical.
      e0082e05
  6. Jan 24, 2018
    • Geoffrey Oxberry's avatar
      netlib-xblas 1.0.248: new package (#7024) · b5daa51c
      Geoffrey Oxberry authored
      * netlib-xblas@1.0.248: new package
      
      * netlib-lapack: add xblas option
      b5daa51c
    • Brian Van Essen's avatar
      Lbann update (#6987) · a62e1a04
      Brian Van Essen authored
      * Added new link line flag
      
      * Refactored some of the common components out of the different
      version's build commands.  Also corrected the when commands to
      properly capture non-numeric names such as local.
      
      * Added support to the Elemental package for the Hydrogen branch.
      a62e1a04
  7. Jan 23, 2018
  8. Jan 22, 2018
  9. Jan 21, 2018
  10. Jan 20, 2018
Loading