Fix typo in previous commit's THcCherenkov.cxx

Fix logical flaw in THcScintillator::ProcessHits in finding good adc hit in multiple hits in one channel

When looping over hits to find the best ADC hit, the code was looping over
frNegAdcPulseInt->GetEntries() or frPosAdcPulseInt->GetEntries()
which are the raw arrays that are filled for all raw hits in the plane
The code was not  using the proper indexes to access the right hits.

The logic is simpler if one loops over rawNegAdcHit.GetNPulses()
or rawPosAdcHit.GetNPulses() which are the the raw hit object for the
paritcular hit. NPulses is the number of ADC pulses that were found for that
adc channel.
The first adc pulse for the channel which is within the adc time window
then has its information saved for late insertion into the "good"
vectors for the hit if either the hit passes 'good" tdc and adc for the POS
or NEG side of the PMT.

  This will add the Hall C parameter DB (gHCParms) to the Run_Data object
  The GetHCParms method will retrieve the parameter DB

Fix mistake in THcHodoEff::End

Add back parameter hodo_gold_hits which is the number of "should" hits
  for each paddle. Needed to calculate efficiency per paddle in
  end run template

Set fHMSStyleChambers =1 according to dc_version parameter.
If no dc_version parameter loaded defaults to old HMS style chambers

    1. Add arrays over paddle num : fStatTrkSum,fStatAndSum and fStatAndEff
    2. Add scalers fHodoEff_s1,fHodoEff_s2,fHodoEff_tof,fHodoEff_3_of_4,fHodoEff_4_of_4
    3. Modify End method to calculate the hodoscope trigger efficiency quantities

    THcHodoscope.cxx
    1. Remove from the use of "temp_planes" for SHMS which
         used only 3 planes for beta and determination of start time.

    2. With change of Integral ADC to pC, change TMath::Sqrt(TMath::Max(20.0,adc_pos))
      to Math::Sqrt(TMath::Max(20.0*.020,adc_pos)) to convert 20 channels to pC

    3. Set fGoodFlags[itrack][ip][iphit].onTrack = kTRUE; when fTOFPInfo[ih].onTrack
       Was always FALSE before.

    4. Modify FineProcess
       a. Add calculation of the track X and Y track position at each plane.
       b. Calculate the difference between the track position and position
          measured by hodoscope center. If multiple paddles hit then take
          average of the paddles.

    THcScintillatorPlane.h and cxx

    1. add variables fHitDistance,fTrackXPosition and fTrackYPosition
    2. add methods GetHitDistance(),GetTrackXPosition(),GetTrackYPosition()
    3. add methods SetHitDistance,SetTrackXPosition,SetTrackYPosition
    4. add variables to tree DiffDisTrack,TrackXPos and TrackYPos
    5. set GoodPosAdcPulseTime to frPosAdcPulseTime
    6. set fGoodNegAdcPulseTime to frNegAdcPulseTime
    7. in HodoHit set PosADCtime and NegADCtime to PulseTime

Modify the way that the constants for conversion to mV and pC are defined
so that it will compile with and without C11.

Include methods for FADC conversions and apply to non-raw data objects in THcRawAdcHit

Add raw pulse time data object to Cherenkov detector classes

Add raw pulse time data object to shower detector classes

Add raw pulse time data object to hodoscope detector class

  This TI information, between the words 0xd0000000 and 0xd000000f,
  contains the # of pedestals, the time interval between scaler events
  the event interval between synchronized scaler events and the
  prescale settings.  Two versions of this block of data are supported,
  version one is mssing the scaler interval values.

  Nothing is actually done with the information found in event 125, but
  a summary can be printed with the method THcConfigEvtHandler::PrintConfig()

  1.  If there are multiple ROCs with scalers (hardware, TI, FADC), then
there will be multiple event 129s.  In the case where analysis of these
events is defered to the end of the analysis, all the event 129s will
be analyzed as if a single event, resulting in one entry in the tree.
  2.  Scalers are read either when a given time interval has passed since
the last scaler read (usually 2 seconds), or every time an event is tagged
as a sync event.  In the case of the "timed" reading of events, different ROCs
with scalers are not guaranteed to read their scalers at the same event.  But
or sync event scaler reads, all ROCs read their scalers.  This commit adds an
option SetOnlyUseSyncEvents(Bool_t).  If set, only scaler events triggered
by the sync event will be analyzed.

Fix bug if more BCMs defined in db_PScalevt.dat than in gscalers.param

Fix bug that confused names "BCM1" and "BCM17" by adding ".scal" to the BCM name

1) Add X,Y offsets parameter for each plane, instead of X,Y offset per chamber
2) ModifyTHcDriftChamber::CorrectHitTimes to work with SHMS chambers
3) Add GetReadoutSide method to THcDCHit class.

  Cache the Cherenkov detector and parent pointers in Init

  Fixes building when using scons 3.0 which apparenlyt uses python3.
  Fixes broken building on travis

  For both the layers and the array part
  Correct calculation of coordinates of the Array modules in the
    calorimeter effciency calculations.

Previous was trying to return the reconstructed target
quantities as values which was totaly wrong.

Changed so that the references are returned. Now get the
reconstructed target quantities properly.

  fpTimes, fScinTime, fScinSigma and fScinZpos are not used.
  These arrays were given fixed size of 53.
  This commit finishes issue #53

  Add #include <set>
  Don't use new method of looping over vector

  When the db file is read, a list of crate #s and a list of
  module types is made.  The tag of each bank searched for scalers
  must have a tag that is in one of these lists.
  If all scalers are in banks tagged with the module type, then,
  SetOnlyBanks(kTRUE) should be called in which case bank tags will
  be compared only against this list of module types.

  In the end method of the Hall C rocs, the scalers are read for a final
  time and a user event 129 is created with the scaler counts.
  These events do not always appear at the end of the coda file, leading to
  the risk that triggered scaler reads will appear after the event 129s.

  If the event type of these final scaler reads is passed to the scaler
  object with the SetDelayedType(int evtype) method, then the scaler analyis
  will cache these events and analyze them at the end of the analysis.