For the most part this is making sure that the loop variable in
  a for loop is of the same type as the variable that it is compared
  against (Often a UInt_t).

This is a temporary fix for problem that arise when compiling on the
ifarm machines. In the DefinedValue method when using
kCutScaler and kCutNCalled the switch statement goes to the default
case.

On ifarm gcc version 4.4.6 20110731 (Red Hat 4.4.6-3) (GCC)
There are compiler warnings
 src/THcFormula.cxx: In member function 'virtual Double_t THcFormula::DefinedValue(Int_t)':
src/THcFormula.cxx:131: warning: case label value exceeds maximum value for type
src/THcFormula.cxx:134: warning: case label value exceeds maximum value for type
One permenant fix would be to add kCutScaler and kCutNCalled to the
enum EVariableType in THaFormula.h.

Add THaSpectrometer::DefineVariables( mode );
to define those tree variables

First, in h_pattern_recognition.f we have:

https://github.com/zahmed9/engine/blob/mkj/HTRACKING/h_pattern_recognition.f#L139
(hdc_wire_center(yy)-hdc_wire_center(yyprime))**2 .lt. (hspace_point_criterion(ich))

So I changed
https://github.com/zahmed9/hcana/blob/develop/src/THcDriftChamber.cxx#L292
TMath::Abs(fHits[plane_hitind]->GetPos() - fHits[planep_hitind]->GetPos()) < fSpacePointCriterion

to

pow((fHits[plane_hitind]->GetPos() - fHits[planep_hitind]->GetPos()),2) < fSpacePointCriterion

Second, the value of MAX_SPACE_POINTS in ENGINE is 100 so in hcana I changed it from 50 to 100.

  This is because the classes in these header files are only
  used by THcShower.

     Edit debug outputs in THcSHower and THcShowerPlane classes. Group
     outputs preferably by the end of methods, for smooth code
     flow. Structure tests of outputs for easy reading.

the HMS calorimeter.

    Add src/THcShowerCluster.h.float, a version of THcShowerCluster
    class with float precision calculation in clX method.

first track from the HMS shower counter code.

    Remove variables and code related to the maximum cluster of hits,
    and association of a cluster to the 1-st spectrometer track in
    THcShower.h and THcShower.cxx. Those were used for testing of the
    code, not needed any more.

track in Engine and the golden track in hcana.

      Add directory examples/gtrk_e holding the code.

consistent with Engine.

	   Reverse order of cycling through clusters in THcShower::MatchCluster.

Access the energy of the golden track from THaGoldenTrack.

    Include THaTrack.h in THaGoldenTrack.h.
    Add GetEnergy method in THaGoldenTrack.h.
    Define variable name "e" for the energy of golden track in THaGoldenTrack.C.

  Convert some arrays that were fixed length to vectors.
  Since these arrays are only used local to the method
  ThcHallCSpectrometer::TrackCalc(), they were moved out of the class
  into the method.
  The affected arrays are fX2D, fY2D, f2XHits and f2YHits

    Structure TOFPInfo holds information for hits within a plane
    Structure TOFCalc holds hit information for all the hits.
    fdEdX changed from 2d array to vector of vectors

      Selection of golden track using prune method is added.
      A bug is also fixed in THcHodoscope class
      Number of pmts hits, focal plane time, good time for plane 4
      and good time for plane 3 are set to the tracks in
      THcHodoscope class.

  This insures that 5th exponent is zero if not specified on recon file

  This is anticipation of a new hit class for processed hits.
  To make it clear that this hit class is for decoding into hit lists

    Add fdbg_raw_cal flag in THcShower.h.
    Initiate fdbg_raw_cal with engine's hdbg_raw_cal in THcShower::ReadDataBase.
    Supply calorimeter debug flags to otherwise free print-outs in the
    THcShower and THcShowerPlane methods.

    Add fdbg_init_cal flag in THcShower.h.
    Initialize fdbg_init_cal from engine's hdebugflaggeometry
    in THcShower::ReadDataBase.

debug info should be suppressed in the main develop branch

- no need to call Nint() on an integer

  Use InitArrays method in THcCherenkov and THcAerogel
  Null out all array pointers in the InitArrays method and
  call that method from all constructors so that it is always
  safe to delete these arrays.

Found when doing valgrind --tool=memcheck --track-origins=yes --leak-check=full hcana
Return errors like below
==14467== Invalid write of size 1
==14467==    at 0x4A0794F: __GI_strcpy (mc_replace_strmem.c:313)
==14467==    by 0x57137A3: THcHodoscope::Setup(char const*, char const*) (THcHodoscope.cxx:112)
==14467==    by 0x5713A7E: THcHodoscope::Init(TDatime const&) (THcHodoscope.cxx:142)
==14467==    by 0x4D38C29: THaApparatus::Init(TDatime const&) (THaApparatus.C:193)
==14467==    by 0x4D67E57: THaAnalyzer::InitModules(TList const*, TDatime&, int, char const*) (THaAnalyzer.C:433)
==14467==    by 0x4D68B1F: THaAnalyzer::DoInit(THaRunBase*) (THaAnalyzer.C:667)
==14467==    by 0x4D68126: THaAnalyzer::Init(THaRunBase*) (THaAnalyzer.C:467)
==14467==    by 0x4D6B31A: THaAnalyzer::Process(THaRunBase*) (THaAnalyzer.C:1289)
==14467==    by 0x4E21E97: G__haDict_704_0_6(G__value*, char const*, G__param*, int) (haDict.C:23491)
==14467==    by 0x6DB6148: Cint::G__ExceptionWrapper(int (*)(G__value*, char const*, G__param*, int), G__value*, char*, G__param*, int) (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34)
==14467==    by 0x6E5A3A0: G__execute_call (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34)
==14467==    by 0x6E5B201: G__call_cppfunc (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34)
==14467==  Address 0xd7636a2 is 0 bytes after a block of size 2 alloc'd
==14467==    at 0x4A0674C: operator new[](unsigned long) (vg_replace_malloc.c:305)
==14467==    by 0x5713757: THcHodoscope::Setup(char const*, char const*) (THcHodoscope.cxx:111)
==14467==    by 0x5713A7E: THcHodoscope::Init(TDatime const&) (THcHodoscope.cxx:142)
==14467==    by 0x4D38C29: THaApparatus::Init(TDatime const&) (THaApparatus.C:193)
==14467==    by 0x4D67E57: THaAnalyzer::InitModules(TList const*, TDatime&, int, char const*) (THaAnalyzer.C:433)
==14467==    by 0x4D68B1F: THaAnalyzer::DoInit(THaRunBase*) (THaAnalyzer.C:667)
==14467==    by 0x4D68126: THaAnalyzer::Init(THaRunBase*) (THaAnalyzer.C:467)
==14467==    by 0x4D6B31A: THaAnalyzer::Process(THaRunBase*) (THaAnalyzer.C:1289)
==14467==    by 0x4E21E97: G__haDict_704_0_6(G__value*, char const*, G__param*, int) (haDict.C:23491)
==14467==    by 0x6DB6148: Cint::G__ExceptionWrapper(int (*)(G__value*, char const*, G__param*, int), G__value*, char*, G__param*, int) (in /u/apps/root/5

THcHodoscope::Clear is called at beginning of analysis before ReadDatabase and Init methods
and therefore  MAXHODHITS and fNPlanes are uninitiated.
Change Clear to ClearEvent
Add call to ClearEvent in Decode
Eliminate Clear method in THcHodoscope.h

    Hardwired numbers are fixed in THcHallcSpectrometer class.
    Generalized functions for center of hodoscope planes and
    their spacings are defined.