- Jul 31, 2015
-
-
Stephen A. Wood authored
-
- May 16, 2015
-
-
Zafar Ahmed authored
-
- Mar 10, 2015
-
-
Stephen A. Wood authored
Modify THcFormula and THcParmList to match changes to THaFormula (needed for reports) Small changes in THcInterface and detector classes for compatibility with new OO decoder and podd 1.6
-
- Jan 16, 2015
-
-
Stephen A. Wood authored
When it was UInt_t, variable length global variables didn't get the length correctly and there were run time errors.
-
Stephen A. Wood authored
For the most part this is making sure that the loop variable in a for loop is of the same type as the variable that it is compared against (Often a UInt_t).
-
- Jan 14, 2015
-
-
Stephen A. Wood authored
This reverts commit e9ce1040. Conflicts: src/THcHallCSpectrometer.cxx
-
- Jan 08, 2015
-
-
Stephen A. Wood authored
For the most part this is making sure that the loop variable in a for loop is of the same type as the variable that it is compared against (Often a UInt_t).
-
- Jan 07, 2015
-
-
Mark Jones authored
-
- Sep 09, 2014
-
-
Stephen A. Wood authored
-
- Sep 02, 2014
-
-
Mark Jones authored
Found when doing valgrind --tool=memcheck --track-origins=yes --leak-check=full hcana Return errors like below ==14467== Invalid write of size 1 ==14467== at 0x4A0794F: __GI_strcpy (mc_replace_strmem.c:313) ==14467== by 0x57137A3: THcHodoscope::Setup(char const*, char const*) (THcHodoscope.cxx:112) ==14467== by 0x5713A7E: THcHodoscope::Init(TDatime const&) (THcHodoscope.cxx:142) ==14467== by 0x4D38C29: THaApparatus::Init(TDatime const&) (THaApparatus.C:193) ==14467== by 0x4D67E57: THaAnalyzer::InitModules(TList const*, TDatime&, int, char const*) (THaAnalyzer.C:433) ==14467== by 0x4D68B1F: THaAnalyzer::DoInit(THaRunBase*) (THaAnalyzer.C:667) ==14467== by 0x4D68126: THaAnalyzer::Init(THaRunBase*) (THaAnalyzer.C:467) ==14467== by 0x4D6B31A: THaAnalyzer::Process(THaRunBase*) (THaAnalyzer.C:1289) ==14467== by 0x4E21E97: G__haDict_704_0_6(G__value*, char const*, G__param*, int) (haDict.C:23491) ==14467== by 0x6DB6148: Cint::G__ExceptionWrapper(int (*)(G__value*, char const*, G__param*, int), G__value*, char*, G__param*, int) (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34) ==14467== by 0x6E5A3A0: G__execute_call (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34) ==14467== by 0x6E5B201: G__call_cppfunc (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34) ==14467== Address 0xd7636a2 is 0 bytes after a block of size 2 alloc'd ==14467== at 0x4A0674C: operator new[](unsigned long) (vg_replace_malloc.c:305) ==14467== by 0x5713757: THcHodoscope::Setup(char const*, char const*) (THcHodoscope.cxx:111) ==14467== by 0x5713A7E: THcHodoscope::Init(TDatime const&) (THcHodoscope.cxx:142) ==14467== by 0x4D38C29: THaApparatus::Init(TDatime const&) (THaApparatus.C:193) ==14467== by 0x4D67E57: THaAnalyzer::InitModules(TList const*, TDatime&, int, char const*) (THaAnalyzer.C:433) ==14467== by 0x4D68B1F: THaAnalyzer::DoInit(THaRunBase*) (THaAnalyzer.C:667) ==14467== by 0x4D68126: THaAnalyzer::Init(THaRunBase*) (THaAnalyzer.C:467) ==14467== by 0x4D6B31A: THaAnalyzer::Process(THaRunBase*) (THaAnalyzer.C:1289) ==14467== by 0x4E21E97: G__haDict_704_0_6(G__value*, char const*, G__param*, int) (haDict.C:23491) ==14467== by 0x6DB6148: Cint::G__ExceptionWrapper(int (*)(G__value*, char const*, G__param*, int), G__value*, char*, G__param*, int) (in /u/apps/root/5
-
- Aug 28, 2014
-
-
Stephen A. Wood authored
-
- Jul 30, 2014
-
-
Jonathan Stelzleni authored
In tree they are called tnhit and trawhit. Created two new variables for THcDriftChamber, fNthits and fN_True_RawHits. In tree they are called tnhit and trawhit. THcDC defined subdetector THcDriftChamber to have name Ch1 and Ch2 to do used in the tree. THcDriftChamberPlane defined new method GetNRawhits to return fNRawhits for each plane. Added member fNRawhits to THcDriftChamberPlane
-
- Feb 27, 2014
-
-
Mark Jones authored
add flags debugflagpr and debugflagstubs add method THcDC::PrintStubs modify THcDC::PrintSpacePoints Set THcDC::LinkStubs() to only set fNDCTracks=0 and retrun when fNDCTracks>10 for HMS style chambers to match engine.
-
- Jan 30, 2014
-
-
Zafar authored
-
- Jan 17, 2014
-
-
Stephen A. Wood authored
-
- Jan 14, 2014
-
-
Stephen A. Wood authored
-
- Dec 19, 2013
-
-
Stephen A. Wood authored
Fix from Mark Jones with additional cleanup for saw's misunderstanding of space point criterion
-
Mark Jones authored
-
- Dec 16, 2013
-
-
Stephen A. Wood authored
THcDriftChamber::AddPlane didn't know if style was HMS, because style was only determined in Init. Now fHMSStyleFlag is set in only one place. Right now determined from spectrometer name, but could be a parameter in the future.
-
Mark Jones authored
With fdebugprintdecodeddc call Chambers[i]->PrintDecode() to output the drift chamber info after min/max time cuts Added PrintSpacePoints() With fdebugprintdecodeddc call PrintSpacePoints() to output drift chmaber spacepoint info
-
- Dec 05, 2013
-
-
Stephen A. Wood authored
-
- Dec 02, 2013
-
-
Stephen A. Wood authored
THcDriftChamber New flag fHMSStyleChambers to determine if HMS or SOS style tracking should be done. Flag is set on if the spectrometer name begins with 'h'. THcDriftChamber::LeftRight fSmallAngleApprox must be set and fHMSStyleChambers must be off to do SOS style. If not HMS style, ignore all the Yplane optimizations THcDC SOS code does "project to chamber" in link stubs. Need to evaluate if this is necessary, or if HMS style should also do it.
-
- Nov 15, 2013
-
-
Edward Brash authored
These were related to a) scope of some variable declarations, and b) use of pre-increment vs. post-increment of non-primitive types (this has a slight performance hit due to the way that pre- vs. post-increment operators are overloaded in C++. Also cleaned up a few places where initialized variables were not being used.
-
- Nov 08, 2013
-
-
Stephen A. Wood authored
Clone some DC tests from ENGINE test files to podd style cuts. Make changes to source code to support these tests. Correct hits in plane line in example report file.
-
- Nov 01, 2013
-
-
Stephen A. Wood authored
Added variables using ENGINE names gen_run_number gen_run_starting_event gen_event_id_number
-
- Oct 31, 2013
-
-
Stephen A. Wood authored
-
- Oct 07, 2013
-
-
Stephen A. Wood authored
-
- Sep 26, 2013
-
-
Mark Jones authored
-
Stephen A. Wood authored
{prefix}dc_fix_lr Historically, in the ENGINE, if a hit is used in multiple space points/stubs, the left/right assignment for that hit, which is later used in track fitting, is that assigned for the last stub encountered with that hit. Properly, the left right assignment should be allowed to be different in different space points. If this parameter is set to zero (e.g. in hcana.param), then the ENGINE behavior is used. For new analyses, it should be set to one. (Which is the default) {prefix}dc_fix_propcorr When a hit gets put into a stub, the distance of the hit from the discriminator can then be estimated. In the engine, a correction to the drift time (and thus drift distance) is applied. However, if that hit ends up in another stub, the correction will get applied again, resulting in a over correction. Setting this flag to 1 will give that hit a different corection for each stub that it is in. These flags will default to the new "correct" way of handling hits if the above parameters are not set in a parameter file. Currently, both flags are set to zero in hcana.param to replicate the ENGINE behavior. To implement these changes, the propagation correction and L/R information for each hit is saved in space point and track classes. This information is still saved in the hit class, but only used if in ENGINE compatibility mode. The THcDCTrack class now saves a list of space point pointers instead of space point indices. The AddSpacePoint method now also copies all the hit information into the track object so that THcDC doesn't need to explicitely copy all the hits. The FindStub method, which fits a stub track to a space point is passed the space point rather than a list of hits
-
- Aug 21, 2013
-
-
Stephen A. Wood authored
Results are focal plane coordinate (transport) system, not detector system Turn on golden track selection.
-
Stephen A. Wood authored
-
- Aug 19, 2013
-
-
Stephen A. Wood authored
-
- Aug 12, 2013
-
-
Stephen A. Wood authored
-
- Aug 08, 2013
-
-
Stephen A. Wood authored
Set 2d histogram limits on tracking results.
-
- Jul 23, 2013
-
-
Stephen A. Wood authored
-
Mark Jones authored
-
- Jul 22, 2013
-
-
Stephen A. Wood authored
-
Stephen A. Wood authored
-
- Jul 17, 2013
-
-
Stephen A. Wood authored
Add track coordinates to track structure. Add code for single stubs Try to deal with plane number/index confusion
-
- Jun 20, 2013
-
-
Mark Jones authored
-