Skip to content
Snippets Groups Projects
  1. Jul 31, 2015
  2. May 16, 2015
  3. Mar 10, 2015
  4. Jan 16, 2015
  5. Jan 14, 2015
  6. Jan 08, 2015
  7. Jan 07, 2015
  8. Sep 09, 2014
  9. Sep 02, 2014
    • Mark Jones's avatar
      Add "+1" to length when using new char[] · 085928d1
      Mark Jones authored
      Found when doing valgrind --tool=memcheck --track-origins=yes --leak-check=full hcana
      Return errors like below
      ==14467== Invalid write of size 1
      ==14467==    at 0x4A0794F: __GI_strcpy (mc_replace_strmem.c:313)
      ==14467==    by 0x57137A3: THcHodoscope::Setup(char const*, char const*) (THcHodoscope.cxx:112)
      ==14467==    by 0x5713A7E: THcHodoscope::Init(TDatime const&) (THcHodoscope.cxx:142)
      ==14467==    by 0x4D38C29: THaApparatus::Init(TDatime const&) (THaApparatus.C:193)
      ==14467==    by 0x4D67E57: THaAnalyzer::InitModules(TList const*, TDatime&, int, char const*) (THaAnalyzer.C:433)
      ==14467==    by 0x4D68B1F: THaAnalyzer::DoInit(THaRunBase*) (THaAnalyzer.C:667)
      ==14467==    by 0x4D68126: THaAnalyzer::Init(THaRunBase*) (THaAnalyzer.C:467)
      ==14467==    by 0x4D6B31A: THaAnalyzer::Process(THaRunBase*) (THaAnalyzer.C:1289)
      ==14467==    by 0x4E21E97: G__haDict_704_0_6(G__value*, char const*, G__param*, int) (haDict.C:23491)
      ==14467==    by 0x6DB6148: Cint::G__ExceptionWrapper(int (*)(G__value*, char const*, G__param*, int), G__value*, char*, G__param*, int) (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34)
      ==14467==    by 0x6E5A3A0: G__execute_call (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34)
      ==14467==    by 0x6E5B201: G__call_cppfunc (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34)
      ==14467==  Address 0xd7636a2 is 0 bytes after a block of size 2 alloc'd
      ==14467==    at 0x4A0674C: operator new[](unsigned long) (vg_replace_malloc.c:305)
      ==14467==    by 0x5713757: THcHodoscope::Setup(char const*, char const*) (THcHodoscope.cxx:111)
      ==14467==    by 0x5713A7E: THcHodoscope::Init(TDatime const&) (THcHodoscope.cxx:142)
      ==14467==    by 0x4D38C29: THaApparatus::Init(TDatime const&) (THaApparatus.C:193)
      ==14467==    by 0x4D67E57: THaAnalyzer::InitModules(TList const*, TDatime&, int, char const*) (THaAnalyzer.C:433)
      ==14467==    by 0x4D68B1F: THaAnalyzer::DoInit(THaRunBase*) (THaAnalyzer.C:667)
      ==14467==    by 0x4D68126: THaAnalyzer::Init(THaRunBase*) (THaAnalyzer.C:467)
      ==14467==    by 0x4D6B31A: THaAnalyzer::Process(THaRunBase*) (THaAnalyzer.C:1289)
      ==14467==    by 0x4E21E97: G__haDict_704_0_6(G__value*, char const*, G__param*, int) (haDict.C:23491)
      ==14467==    by 0x6DB6148: Cint::G__ExceptionWrapper(int (*)(G__value*, char const*, G__param*, int), G__value*, char*, G__param*, int) (in /u/apps/root/5
      085928d1
  10. Aug 28, 2014
  11. Jul 30, 2014
    • Jonathan Stelzleni's avatar
      Created two new variables for THcDC, fNthits and fN_True_RawHits. · d496e1e3
      Jonathan Stelzleni authored
      In tree they are called tnhit and trawhit.
      Created two new variables for THcDriftChamber, fNthits and fN_True_RawHits.
      In tree they are called tnhit and trawhit.
      THcDC defined subdetector THcDriftChamber to have name Ch1 and Ch2 to do used in the tree.
      THcDriftChamberPlane defined new method GetNRawhits to return fNRawhits for each plane.
      Added member fNRawhits to THcDriftChamberPlane
      d496e1e3
  12. Feb 27, 2014
    • Mark Jones's avatar
      Updated drift chamber debug messages · 30ccc1ce
      Mark Jones authored
      add flags debugflagpr and debugflagstubs
      add method THcDC::PrintStubs
      modify THcDC::PrintSpacePoints
      Set THcDC::LinkStubs() to only set fNDCTracks=0 and retrun when
        fNDCTracks>10 for HMS style chambers to match engine.
      30ccc1ce
  13. Jan 30, 2014
  14. Jan 17, 2014
  15. Jan 14, 2014
  16. Dec 19, 2013
  17. Dec 16, 2013
  18. Dec 05, 2013
  19. Dec 02, 2013
    • Stephen A. Wood's avatar
      Untested SOS tracking code. · 2af4bf2d
      Stephen A. Wood authored
        THcDriftChamber
          New flag fHMSStyleChambers to determine if HMS or SOS style
          tracking should be done.  Flag is set on if the spectrometer
          name begins with 'h'.
          THcDriftChamber::LeftRight fSmallAngleApprox must be set and
          fHMSStyleChambers must be off to do SOS style.
          If not HMS style, ignore all the Yplane optimizations
        THcDC
          SOS code does "project to chamber" in link stubs.  Need to evaluate
          if this is necessary, or if HMS style should also do it.
      2af4bf2d
  20. Nov 15, 2013
    • Edward Brash's avatar
      Address some minor issues reported by cppcheck · bd50814c
      Edward Brash authored
      These were related to a) scope of some variable declarations, and b) use
      of pre-increment vs. post-increment of non-primitive types (this has a
      slight performance hit due to the way that pre- vs. post-increment
      operators are overloaded in C++.
      
      Also cleaned up a few places where initialized variables were not being
      used.
      bd50814c
  21. Nov 08, 2013
  22. Nov 01, 2013
  23. Oct 31, 2013
  24. Oct 07, 2013
  25. Sep 26, 2013
    • Mark Jones's avatar
    • Stephen A. Wood's avatar
      Parameters to optionally correct small ENGINE DC hit handling errors. · 6a33dcf3
      Stephen A. Wood authored
         {prefix}dc_fix_lr
              Historically, in the ENGINE, if a hit is used in multiple
              space points/stubs, the left/right assignment for that hit, which
              is later used in track fitting, is that assigned for the last stub
              encountered with that hit.  Properly, the left right assignment
              should be allowed to be different in different space points.  If
              this parameter is set to zero (e.g. in hcana.param), then the
              ENGINE behavior is used.  For new analyses, it should be set to one.
              (Which is the default)
         {prefix}dc_fix_propcorr
              When a hit gets put into a stub, the distance of the hit from the
              discriminator can then be estimated.  In the engine, a correction to
              the drift time (and thus drift distance) is applied.  However, if
              that hit ends up in another stub, the correction will get applied again,
              resulting in a over correction.  Setting this flag to 1 will give that
              hit a different corection for each stub that it is in.
      
      These flags will default to the new "correct" way of handling hits if
      the above parameters are not set in a parameter file.  Currently, both
      flags are set to zero in hcana.param to replicate the ENGINE behavior.
      
      To implement these changes, the propagation correction and L/R information
      for each hit is saved in space point and track classes.  This information
      is still saved in the hit class, but only used if in ENGINE compatibility
      mode.
      
      The THcDCTrack class now saves a list of space point pointers instead
      of space point indices.
      
      The AddSpacePoint method now also copies all the hit information into
      the track object so that THcDC doesn't need to explicitely copy all
      the hits.
      
      The FindStub method, which fits a stub track to a space point is passed
      the space point rather than a list of hits
      6a33dcf3
  26. Aug 21, 2013
  27. Aug 19, 2013
  28. Aug 12, 2013
  29. Aug 08, 2013
  30. Jul 23, 2013
  31. Jul 22, 2013
  32. Jul 17, 2013
  33. Jun 20, 2013
Loading