Skip to content
Snippets Groups Projects
  1. Dec 22, 2014
  2. Dec 19, 2014
  3. Dec 12, 2014
  4. Dec 05, 2014
  5. Nov 17, 2014
  6. Nov 13, 2014
  7. Oct 24, 2014
  8. Oct 10, 2014
  9. Oct 04, 2014
  10. Sep 26, 2014
  11. Sep 21, 2014
  12. Sep 15, 2014
  13. Sep 12, 2014
  14. Sep 10, 2014
  15. Sep 09, 2014
  16. Sep 08, 2014
  17. Sep 06, 2014
  18. Sep 05, 2014
  19. Sep 04, 2014
  20. Sep 02, 2014
    • Mark Jones's avatar
      Add "+1" to length when using new char[] · 085928d1
      Mark Jones authored
      Found when doing valgrind --tool=memcheck --track-origins=yes --leak-check=full hcana
      Return errors like below
      ==14467== Invalid write of size 1
      ==14467==    at 0x4A0794F: __GI_strcpy (mc_replace_strmem.c:313)
      ==14467==    by 0x57137A3: THcHodoscope::Setup(char const*, char const*) (THcHodoscope.cxx:112)
      ==14467==    by 0x5713A7E: THcHodoscope::Init(TDatime const&) (THcHodoscope.cxx:142)
      ==14467==    by 0x4D38C29: THaApparatus::Init(TDatime const&) (THaApparatus.C:193)
      ==14467==    by 0x4D67E57: THaAnalyzer::InitModules(TList const*, TDatime&, int, char const*) (THaAnalyzer.C:433)
      ==14467==    by 0x4D68B1F: THaAnalyzer::DoInit(THaRunBase*) (THaAnalyzer.C:667)
      ==14467==    by 0x4D68126: THaAnalyzer::Init(THaRunBase*) (THaAnalyzer.C:467)
      ==14467==    by 0x4D6B31A: THaAnalyzer::Process(THaRunBase*) (THaAnalyzer.C:1289)
      ==14467==    by 0x4E21E97: G__haDict_704_0_6(G__value*, char const*, G__param*, int) (haDict.C:23491)
      ==14467==    by 0x6DB6148: Cint::G__ExceptionWrapper(int (*)(G__value*, char const*, G__param*, int), G__value*, char*, G__param*, int) (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34)
      ==14467==    by 0x6E5A3A0: G__execute_call (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34)
      ==14467==    by 0x6E5B201: G__call_cppfunc (in /u/apps/root/5.34.13/root/lib/libCint.so.5.34)
      ==14467==  Address 0xd7636a2 is 0 bytes after a block of size 2 alloc'd
      ==14467==    at 0x4A0674C: operator new[](unsigned long) (vg_replace_malloc.c:305)
      ==14467==    by 0x5713757: THcHodoscope::Setup(char const*, char const*) (THcHodoscope.cxx:111)
      ==14467==    by 0x5713A7E: THcHodoscope::Init(TDatime const&) (THcHodoscope.cxx:142)
      ==14467==    by 0x4D38C29: THaApparatus::Init(TDatime const&) (THaApparatus.C:193)
      ==14467==    by 0x4D67E57: THaAnalyzer::InitModules(TList const*, TDatime&, int, char const*) (THaAnalyzer.C:433)
      ==14467==    by 0x4D68B1F: THaAnalyzer::DoInit(THaRunBase*) (THaAnalyzer.C:667)
      ==14467==    by 0x4D68126: THaAnalyzer::Init(THaRunBase*) (THaAnalyzer.C:467)
      ==14467==    by 0x4D6B31A: THaAnalyzer::Process(THaRunBase*) (THaAnalyzer.C:1289)
      ==14467==    by 0x4E21E97: G__haDict_704_0_6(G__value*, char const*, G__param*, int) (haDict.C:23491)
      ==14467==    by 0x6DB6148: Cint::G__ExceptionWrapper(int (*)(G__value*, char const*, G__param*, int), G__value*, char*, G__param*, int) (in /u/apps/root/5
      085928d1
    • Mark Jones's avatar
      Fix problem with uninitialized variables used in THcHodoscope::Clear · d276508b
      Mark Jones authored
      THcHodoscope::Clear is called at beginning of analysis before ReadDatabase and Init methods
      and therefore  MAXHODHITS and fNPlanes are uninitiated.
      Change Clear to ClearEvent
      Add call to ClearEvent in Decode
      Eliminate Clear method in THcHodoscope.h
      d276508b
  21. Aug 30, 2014
  22. Aug 29, 2014
  23. Aug 28, 2014
Loading