Patch extracted from #7536 courtesy of @mgsternberg

* update R to v3.5.3

* abinit: Fix building with hdf5/netcdf.

* gromacs: Fix attempt to build with cuda support when 'cuda=False'

If for some reason there's a cuda toolkit installed by other means,
(i.e. not by spack) cmake will still try to build with cuda support,
even though 'cuda=False' is the default of the spec.

* Revert "abinit: Fix building with hdf5/netcdf."

This reverts commit e16f725e37b91193fe519b1821446c76ab551928.

This should not be here.

* Branson: provide new versions.

+ Also update dependencies (newer version have fewer dependencies).

* fix style issue

* Draco: add variants

+ This package has many optional build dependencies that were not registered in
  older versions of this recipe.  I've added (and tested) this more complete
  list of optional dependencies: parmetis, superlu-dist, qt.

* fix style issues

Added versions from 4.0.11 to 5.0.3

closes #9180

* hpcviewer: new package

Add binary package for hpcviewer and hpctraceviewer for the Rice
hpctoolkit on Linux x86_64, ppc64 and ppc64le.

* ibm-java: add property 'home' so that spec['java'].home will work.

* Flake

* More flake.

* Test that the version, machine type pair exists before using it in the
sha dictionaries so that 'spack info' doesn't crash on unsupported
configurations.

* mariadb-c-client is a new package using the distinct, LGPL,
  MySQL-compatible client library from mariadb.com. It provides the
  virtual package mariadb-client
* mariadb is recorded as a provider of the mariadb-client virtual
* The mysql-client virtual package is also added, and mariadb-c-client
  is recorded as a provider for it

* Add latest version and missing dependencies of MySQL

* m4 only needed on solaris

If the user has set the environment variable VISUAL, it will be used
in preference to EDITOR for all Spack editing activities. If VISUAL
is not set or fails (perhaps due to a lack of graphical editing
capabilities),EDITOR will be used instead. We fall back to one of
several common editors if neither bears fruit.

This feature has been tailored to:

* Provide identical behavior to the previous implementation in the
  case that VISUAL is not set.
* Not require any change to code utilizing the editor feature.
* Follow usual UNIX behavior concerning VISUAL and EDITOR.

* Throw InstallError if more than one GPU architecture is passed to cuda_arch. Previous cuda_arch test was not actually working because comparison with none string was on the cuda_arch list instead of the first entry of the list.

* Removing redundant cuda_arch statement.

pkgconfig is the correct virtual provider.

mpich@3.3 introduced a new regex-based function for node list parsing
that does not recognize hostnames without a dash properly.