fix: cleanup jobs in finalize stage don't need explicit needs

This should fix builds of tags and stable branches which don't build nightly. The stage is what defines when this runs anyway.

assigned to @wdconinc

added 1 commit

• 0b8a9ecc - fix: rm needs: version

Compare with previous version

I am not sure this is a good idea. The stage generally doesn't control when it runs. Right now all the cleans have been run but jug_dev has failed.

Even when jug_dev fails we need cleanup of whatever temporary images were created. The cleanups ran after the previous jobs. The stage order is respected when no needs are defined.

added 3 commits

• 37167af1 - 1 commit from branch master
• ca7d5d7b - fix: cleanup jobs in finalize stage don't need explicit needs
• 51a71e19 - fix: rm needs: version

Compare with previous version

The immediate goal here is to fix https://eicweb.phy.anl.gov/containers/eic_container/-/pipelines/72542 yaml failures for tags and branches that don't build nightly. If we just remove the nightly dependency then it will run cleanup as soon as default has completed and (on master) while nightly is still running.

From what I understand, it would not matter if the ordering is off, the cleanup stage would only act on temporary images corresponding to closed and merged PRs. I don't know what is an issue with running cleanup unnecessarily.

merged

Internal tag cleanup before benchmarks are complete would cause benchmarks not to find the image they are supposed to run with.

We should be able to rely on gitlab cleaning up unused images automatically, but in the past this has resulted in gitlab removing the images from its registry without removing them from the docker service and space allocation. So, experience says that unless we remove these images ourselves we end up bringing down the server exactly when we are most busy and running lots of pipelines.