Skip to content

Resolve "Many places have hard-coded `eicd::Vector3f` which should depend on data model types"

Wouter Deconinck requested to merge 103-many-places-have-hard-coded-eicd-vector3f-which-should-depend-on-data-model-types into master

Closes #103 (closed)

JugFast/src/components/ClusterMerger.cpp:        eicd::Vector3f position;
JugFast/src/components/SmearedFarForwardParticles.cpp:    const edm4hep::Vector3f psmear_ion{static_cast<float>(pxs), static_cast<float>(pys), static_cast<float>(pzs)};
JugFast/src/components/SmearedFarForwardParticles.cpp:  edm4hep::Vector3f rotateLabToIonDirection(const edm4hep::Vector3f& vec) const {
JugFast/src/components/SmearedFarForwardParticles.cpp:  edm4hep::Vector3f rotateIonToLabDirection(const edm4hep::Vector3f& vec) const {
JugFast/src/components/SmearedFarForwardParticles.cpp:  edm4hep::Vector3f removeCrossingAngle(const edm4hep::Vector3f& vec) const {
JugReco/src/components/CalorimeterIslandCluster.cpp:#include "eicd/Vector3f.h"
JugReco/src/components/ImagingClusterReco.cpp:    eicd::Vector3f mean_pos{0, 0, 0};
JugTrack/src/components/TrackParamACTSSeeding.cpp:                            eicd::Vector3f(v[0], v[1], v[2]),
JugTrack/src/components/TrackProjector.cpp:          const eicd::Vector3f position {
JugTrack/src/components/TrackProjector.cpp:          const eicd::Vector3f momentum = eicd::sphericalToVector(
Edited by Wouter Deconinck

Merge request reports