fix a typo in HallC_Data and get rid of some warnings

src/THcDC.h

@@ -227,7 +227,7 @@ protected:
 
 public:
   THcDriftChamberPlane* GetPlane(unsigned int i_plane) {
-    if(i_plane < fNPlanes) {
+    if(static_cast<int>(i_plane) < fNPlanes) {
       return fPlanes[i_plane];
     }
     return nullptr;

src/THcRawHit.h

@@ -29,20 +29,20 @@ public:
   //  virtual Bool_t  operator==( const THcRawHit& ) = 0;
   //  virtual Bool_t  operator!=( const THcRawHit& ) = 0;
 
-  virtual void SetData(Int_t signal, Int_t data) {};
-  virtual void SetSample(Int_t signal, Int_t data) {};
-  virtual void SetDataTimePedestalPeak(Int_t signal, Int_t data,
-				       Int_t time, Int_t pedestal, Int_t peak) {};
-  virtual Int_t GetData(Int_t signal) {return 0;}; /* Ref time subtracted */
-  virtual Int_t GetRawData(Int_t signal) {return 0;} /* Ref time not subtracted */
-  virtual ESignalType GetSignalType(Int_t signal) {return kUndefined;}
+  virtual void SetData(Int_t /* signal */, Int_t /* data */) {};
+  virtual void SetSample(Int_t /* signal */, Int_t /* data */) {};
+  virtual void SetDataTimePedestalPeak(Int_t /* signal */, Int_t /* data */,
+				       Int_t /* time */, Int_t /* pedestal */, Int_t /* peak */) {};
+  virtual Int_t GetData(Int_t /* signal */) {return 0;}; /* Ref time subtracted */
+  virtual Int_t GetRawData(Int_t /* signal */) {return 0;} /* Ref time not subtracted */
+  virtual ESignalType GetSignalType(Int_t /* signal */) {return kUndefined;}
   virtual Int_t GetNSignals() { return 1;}
 
-  virtual void SetReference(Int_t signal, Int_t reference) {};
-  virtual Bool_t HasReference(Int_t signal) {return kFALSE;};
-  virtual Int_t GetReference(Int_t signal) {return 0;};
+  virtual void SetReference(Int_t /* signal */, Int_t /* reference */) {};
+  virtual Bool_t HasReference(Int_t /* signal */) {return kFALSE;};
+  virtual Int_t GetReference(Int_t /* signal */) {return 0;};
 
-  virtual void SetF250Params(Int_t NSA, Int_t NSB, Int_t NPED) {};
+  virtual void SetF250Params(Int_t /* NSA */, Int_t /* NSB */, Int_t /* NPED */) {};
 
   // Derived objects must be sortable and supply Compare method
   //  virtual Bool_t  IsSortable () const {return kFALSE; }

src/THcSpacePoint.h

@@ -29,7 +29,7 @@ public:
   };
 
   void SetXY(Double_t x, Double_t y) {fX = x; fY = y;};
-  void Clear(Option_t* opt="") {fNHits=0; fNCombos=0; fHits.clear();};
+  void Clear(Option_t* /* opt */ ="") {fNHits=0; fNCombos=0; fHits.clear();};
   void AddHit(THcDCHit* hit) {
     Hit newhit;
     newhit.dchit = hit;

src/include/hcana/HallC_Data.h

@@ -15,7 +15,7 @@ namespace hallc {
       static const UInt_t MaxNSamples = 511;
       // From THcRawAdcHit.h
       PulseWaveForm() {}
-      PulseWaveForm(Int_t* buf, Int_t size = MaxNSamples) { std::copy_n(buf, MaxNSamples, std::begin(_buffer)); }
+      PulseWaveForm(Int_t* buf, Int_t size = MaxNSamples) { std::copy_n(buf, size, std::begin(_buffer)); }
       virtual ~PulseWaveForm() {}
 
       void ZeroBuffer() { std::fill(std::begin(_buffer), std::end(_buffer), 0); }