Charm++: Ignore compiler warnings while configuring (#1981)

var/spack/repos/builtin/packages/charm/package.py

@@ -48,6 +48,8 @@ class Charm(Package):
     # Support OpenMPI; see
     # <https://charm.cs.illinois.edu/redmine/issues/1206>
     patch("mpi.patch")
+    # Ignore compiler warnings while configuring
+    patch("strictpass.patch")
 
     # Communication mechanisms (choose exactly one)
     # TODO: Support Blue Gene/Q PAMI, Cray GNI, Cray shmem, CUDA

var/spack/repos/builtin/packages/charm/strictpass.patch

+--- old/src/scripts/configure
++++ new/src/scripts/configure
+@@ -2146,13 +2146,6 @@
+ 	test_result $? "$1" "$2" "$3"
+  	strictpass=$pass
+ 	strictfail=$fail
+-        if test $pass -eq 1
+-	then
+- 	  if cat out | grep -i "warn" > /dev/null 2>&1
+-	  then
+-	    strictpass="0" && strictfail="1"
+-          fi
+-        fi
+ 	cat out >> $charmout
+ 	/bin/rm -f out
+ }