Need to check the binary is not a Mach-o binary in a linux package or an ELF...

Need to check the binary is not a Mach-o binary in a linux package or an ELF binary in a macOS package.

lib/spack/spack/binary_distribution.py

@@ -180,7 +180,11 @@ def write_buildinfo_file(spec, workdir, rel=False):
                         tty.warn(msg)
 
             if relocate.needs_binary_relocation(m_type, m_subtype):
-                if not filename.endswith('.o'):
+                if ((m_subtype in ('x-executable', 'x-sharedlib')
+                    and platform.sys != 'Darwin') or
+                   (m_subtype in ('x-mach-binary')
+                    and platform.sys == 'Darwin') or
+                   (not filename.endswith('.o'))):
                     rel_path_name = os.path.relpath(path_name, prefix)
                     binary_to_relocate.append(rel_path_name)
             if relocate.needs_text_relocation(m_type, m_subtype):