Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
S
Spack
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
eic_tools
Spack
Commits
db59f87e
Commit
db59f87e
authored
8 years ago
by
Todd Gamblin
Browse files
Options
Downloads
Patches
Plain Diff
Update README.md for PEP8
parent
240f1fd2
Branches
13-add-and-use-local-storage-in-pipeline
Branches containing commit
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
README.md
+14
-7
14 additions, 7 deletions
README.md
with
14 additions
and
7 deletions
README.md
+
14
−
7
View file @
db59f87e
...
@@ -58,17 +58,24 @@ can join it here:
...
@@ -58,17 +58,24 @@ can join it here:
### Contributions
### Contributions
At the moment, c
ontributing to Spack is relatively
simple
. Just send us
C
ontributing to Spack is relatively. Just send us
a
a
[
pull request
](
https://help.github.com/articles/using-pull-requests/
)
.
[
pull request
](
https://help.github.com/articles/using-pull-requests/
)
.
When you send your request, make
``develop``
the destination branch on the
When you send your request, make
``develop``
the destination branch on the
[
Spack repository
](
https://github.com/LLNL/spack
)
.
[
Spack repository
](
https://github.com/LLNL/spack
)
.
Your contribution will need to pass all the tests run by the
`spack test`
Before you send a PR, your code should pass the following checks:
command, as well as the formatting checks in
`share/spack/qa/run-flake8`
.
You should run both of these before submitting your pull request, to
ensure that the online checks succeed.
Spack is using a rough approximation of the
[
Git
*
Your contribution will need to pass the
`spack test`
command.
Run this before submitting your PR.
*
Also run the
`share/spack/qa/run-flake8`
script to check for PEP8 compliance.
To encourage contributions and readability by a broad audience,
Spack uses the
[
PEP8
](
https://www.python.org/dev/peps/pep-0008/
)
coding
standard with
[
a few exceptions
](
https://github.com/LLNL/spack/blob/develop/.flake8
)
.
We enforce these guidelines with
[
Travis CI
](
https://travis-ci.org/LLNL/spack
)
.
Spack uses a rough approximation of the
[
Git
Flow
](
http://nvie.com/posts/a-successful-git-branching-model/
)
Flow
](
http://nvie.com/posts/a-successful-git-branching-model/
)
branching model. The
``develop``
branch contains the latest
branching model. The
``develop``
branch contains the latest
contributions, and
``master``
is always tagged and points to the
contributions, and
``master``
is always tagged and points to the
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment