CDash fixes (#2438)

use short spec instead of spec as CDash has a limitation in name length
mark all problems as 'FAILED' as CDash does not understand "ERRORED" status

lib/spack/spack/cmd/install.py

@@ -130,7 +130,7 @@ def dump(self, filename):
         )
         self.root.set('failures', str(number_of_failures))
         self.root.set('tests', str(len(self.tests)))
-        self.root.set('name', str(self.spec))
+        self.root.set('name', self.spec.short_spec)
         self.root.set('hostname', platform.node())
 
         for item in self.tests:
@@ -247,7 +247,7 @@ def wrapper(self, *args, ** kwargs):
                 test_case.set_duration(duration)
                 text = fetch_text(self.build_log_path)
                 test_case.set_result(
-                    TestResult.ERRORED,
+                    TestResult.FAILED,
                     message='Unable to fetch package',
                     text=text
                 )
@@ -257,7 +257,7 @@ def wrapper(self, *args, ** kwargs):
                 test_case.set_duration(duration)
                 text = fetch_text(self.build_log_path)
                 test_case.set_result(
-                    TestResult.ERRORED,
+                    TestResult.FAILED,
                     message='Unexpected exception thrown during install',
                     text=text
                 )
@@ -267,7 +267,7 @@ def wrapper(self, *args, ** kwargs):
                 test_case.set_duration(duration)
                 text = fetch_text(self.build_log_path)
                 test_case.set_result(
-                    TestResult.ERRORED,
+                    TestResult.FAILED,
                     message='Unknown error',
                     text=text
                 )