Feature Proposal : Make All Python Extensions User Configuration Independent (#1435)

* Updated all Python extension packages to use 'setup_py' on install.

* Fixed a few minor style issues with the updated Python packages.

share/spack/csh/convert-pyext.sh

-#!/bin/bash --noprofile
-PYEXT_REGEX=".*/.*/package.py"
-
-find var/spack/repos/builtin/packages/ -type f -regextype sed -regex ${PYEXT_REGEX} -exec \
-    sed -i 's/python('\''setup.py'\'', /setup_py(/' {} \;

var/spack/repos/builtin/packages/fenics/package.py

@@ -143,7 +143,7 @@ def cmake_is_on(self, option):
     def install(self, spec, prefix):
         for package in ['ufl', 'ffc', 'fiat', 'instant']:
             with working_dir(join_path('depends', package)):
-                python('setup.py', 'install', '--prefix=%s' % prefix)
+                setup_py('install', '--prefix=%s' % prefix)
 
         cmake_args = [
             '-DCMAKE_BUILD_TYPE:STRING={0}'.format(

var/spack/repos/builtin/packages/py-3to2/package.py

@@ -37,4 +37,4 @@ class Py3to2(Package):
     extends('python')
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-SQLAlchemy/package.py

@@ -36,4 +36,4 @@ class PySqlalchemy(Package):
     extends('python')
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-argcomplete/package.py

@@ -36,4 +36,4 @@ class PyArgcomplete(Package):
     extends('python')
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-astroid/package.py

@@ -42,4 +42,4 @@ class PyAstroid(Package):
     depends_on('py-six', type=nolink)
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-astropy/package.py

@@ -56,6 +56,5 @@ class PyAstropy(Package):
     depends_on('expat')
 
     def install(self, spec, prefix):
-        python('setup.py', 'build', '--use-system-cfitsio',
-               '--use-system-expat')
-        python('setup.py', 'install', '--prefix={0}'.format(prefix))
+        setup_py('build', '--use-system-cfitsio', '--use-system-expat')
+        setup_py('install', '--prefix={0}'.format(prefix))

var/spack/repos/builtin/packages/py-basemap/package.py

@@ -43,4 +43,4 @@ class PyBasemap(Package):
 
     def install(self, spec, prefix):
         env['GEOS_DIR'] = spec['geos'].prefix
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-beautifulsoup4/package.py

@@ -40,4 +40,4 @@ class PyBeautifulsoup4(Package):
     depends_on('py-setuptools', type='build')
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix={0}'.format(prefix))
+        setup_py('install', '--prefix={0}'.format(prefix))

var/spack/repos/builtin/packages/py-biopython/package.py

@@ -41,4 +41,4 @@ class PyBiopython(Package):
     depends_on('py-numpy', type=nolink)
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-blessings/package.py

@@ -37,4 +37,4 @@ class PyBlessings(Package):
     extends("python")
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-bottleneck/package.py

@@ -36,4 +36,4 @@ class PyBottleneck(Package):
     depends_on('py-numpy', type=nolink)
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-cffi/package.py

@@ -49,4 +49,4 @@ def install(self, spec, prefix):
         # building the shared library.
         os.environ['LDSHARED'] = "{0} -shared -pthread".format(spack_cc)
 
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-coverage/package.py

@@ -38,4 +38,4 @@ class PyCoverage(Package):
     extends('python')
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-csvkit/package.py

@@ -44,4 +44,4 @@ class PyCsvkit(Package):
     depends_on('py-openpyxl', type=nolink)
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-cython/package.py

@@ -40,4 +40,4 @@ class PyCython(Package):
     extends('python')
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-dask/package.py

@@ -37,4 +37,4 @@ class PyDask(Package):
     depends_on('py-setuptools', type='build')
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-dateutil/package.py

@@ -39,4 +39,4 @@ class PyDateutil(Package):
     depends_on('py-six', type=nolink)
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-dbf/package.py

@@ -37,4 +37,4 @@ class PyDbf(Package):
     extends('python')
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)

var/spack/repos/builtin/packages/py-decorator/package.py

@@ -39,4 +39,4 @@ class PyDecorator(Package):
     depends_on('py-setuptools', type='build')
 
     def install(self, spec, prefix):
-        python('setup.py', 'install', '--prefix=%s' % prefix)
+        setup_py('install', '--prefix=%s' % prefix)