tests: removed code duplication (#14596)
- [x] Factored to a common place the fixture `testing_gpg_directory`, renamed it as `mock_gnupghome` - [x] Removed altogether the function `has_gnupg2` For `has_gnupg2`, since we were not trying to parse the version from the output of: ```console $ gpg2 --version ``` this is effectively equivalent to check if `spack.util.gpg.GPG.gpg()` was found. If we need to ensure version is `^2.X` it's probably better to do it in `spack.util.gpg.GPG.gpg()` than in a separate function.
Showing
- lib/spack/spack/binary_distribution.py 18 additions, 23 deletionslib/spack/spack/binary_distribution.py
- lib/spack/spack/test/ci.py 1 addition, 10 deletionslib/spack/spack/test/ci.py
- lib/spack/spack/test/cmd/ci.py 2 additions, 11 deletionslib/spack/spack/test/cmd/ci.py
- lib/spack/spack/test/cmd/gpg.py 5 additions, 20 deletionslib/spack/spack/test/cmd/gpg.py
- lib/spack/spack/test/conftest.py 8 additions, 0 deletionslib/spack/spack/test/conftest.py
- lib/spack/spack/test/packaging.py 3 additions, 19 deletionslib/spack/spack/test/packaging.py
Loading
Please register or sign in to comment