Skip to content
Snippets Groups Projects
Unverified Commit 621388e5 authored by Massimiliano Culpo's avatar Massimiliano Culpo Committed by GitHub
Browse files

Restore multiprocessing in unit tests (#6949)

* Revert "Travis: use --concurrency=multiprocessing only on build tests (#6872)"

This reverts commit 596d4637.

* Removing 'coverage combine' in test script

According to what was discovered in #6887, one of the problems is
calling 'coverage combine' twice without the '-a' flag. This removes
the first call within our test scripts.
parent cf736ae9
No related branches found
No related tags found
No related merge requests found
...@@ -2,6 +2,7 @@ ...@@ -2,6 +2,7 @@
# .coveragerc to control coverage.py # .coveragerc to control coverage.py
[run] [run]
parallel = True parallel = True
concurrency = multiprocessing
branch = True branch = True
source = lib source = lib
omit = omit =
......
...@@ -26,4 +26,3 @@ spack config get compilers ...@@ -26,4 +26,3 @@ spack config get compilers
# Run some build smoke tests, potentially with code coverage # Run some build smoke tests, potentially with code coverage
${coverage_run} bin/spack install ${SPEC} ${coverage_run} bin/spack install ${SPEC}
${coverage_combine}
...@@ -29,4 +29,3 @@ ${coverage_run} bin/spack -p --lines 20 spec mpileaks ...@@ -29,4 +29,3 @@ ${coverage_run} bin/spack -p --lines 20 spec mpileaks
# Run unit tests with code coverage # Run unit tests with code coverage
${coverage_run} bin/spack test "$@" ${coverage_run} bin/spack test "$@"
${coverage_combine}
...@@ -11,18 +11,12 @@ SPACK_ROOT="$QA_DIR/../../.." ...@@ -11,18 +11,12 @@ SPACK_ROOT="$QA_DIR/../../.."
. "$SPACK_ROOT/share/spack/setup-env.sh" . "$SPACK_ROOT/share/spack/setup-env.sh"
# Set up some variables for running coverage tests. # Set up some variables for running coverage tests.
if [[ "$COVERAGE" == "true" && "$TEST_SUITE" == "unit" ]]; then if [[ "$COVERAGE" == true ]]; then
coverage=coverage coverage=coverage
coverage_run="coverage run" coverage_run="coverage run"
coverage_combine="coverage combine"
elif [[ "$COVERAGE" == "true" && "$TEST_SUITE" == "build" ]]; then
coverage=coverage
coverage_run="coverage run --concurrency=multiprocessing"
coverage_combine="coverage combine"
else else
coverage="" coverage=""
coverage_run="" coverage_run=""
coverage_combine=""
fi fi
# #
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment