Add latest version of zstd (#13340)

* Add latest version of zstd

* setup_environment -> setup_build_environment

var/spack/repos/builtin/packages/zstd/package.py

@@ -12,8 +12,9 @@ class Zstd(MakefilePackage):
     better compression ratios."""
 
     homepage = "http://facebook.github.io/zstd/"
-    url      = "https://github.com/facebook/zstd/archive/v1.4.2.tar.gz"
+    url      = "https://github.com/facebook/zstd/archive/v1.4.3.tar.gz"
 
+    version('1.4.3', sha256='5eda3502ecc285c3c92ee0cc8cd002234dee39d539b3f692997a0e80de1d33de')
     version('1.4.2', sha256='7a6e1dad34054b35e2e847eb3289be8820a5d378228802239852f913c6dcf6a7')
     version('1.4.0', sha256='63be339137d2b683c6d19a9e34f4fb684790e864fee13c7dd40e197a64c705c1')
     version('1.3.8', sha256='90d902a1282cc4e197a8023b6d6e8d331c1fd1dfe60f7f8e4ee9da40da886dc3')
@@ -22,9 +23,11 @@ class Zstd(MakefilePackage):
 
     variant('pic', default=True, description='Build position independent code')
 
-    def setup_environment(self, spack_env, run_env):
+    depends_on('zlib')
+
+    def setup_build_environment(self, env):
         if '+pic' in self.spec:
-            spack_env.append_flags('CFLAGS', self.compiler.pic_flag)
+            env.append_flags('CFLAGS', self.compiler.pic_flag)
 
     def build(self, spec, prefix):
         make('PREFIX={0}'.format(prefix))