Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
S
Spack
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
eic_tools
Spack
Commits
39725e07
Commit
39725e07
authored
6 years ago
by
Adam J. Stewart
Committed by
Massimiliano Culpo
6 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Typo fixes in .flake8 comments (#10399)
parent
bb1f8b0e
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
.flake8
+13
-7
13 additions, 7 deletions
.flake8
.flake8_packages
+6
-4
6 additions, 4 deletions
.flake8_packages
with
19 additions
and
11 deletions
.flake8
+
13
−
7
View file @
39725e07
# -*- conf -*-
# -*- conf -*-
# flake8 settings for Spack core files.
# flake8 settings for Spack core files.
#
#
# These exceptions ar for Spack core files. We're slightly more lenient
# These exceptions ar
e
for Spack core files. We're slightly more lenient
# with packages. See .flake8_packages for that.
# with packages. See .flake8_packages for that.
#
#
#
Let people line things up nicely:
#
E1: Indentation
# - E129: visually indented line with same indent as next logical line
# - E129: visually indented line with same indent as next logical line
#
# E2: Whitespace
# - E221: multiple spaces before operator
# - E221: multiple spaces before operator
# - E241: multiple spaces after ','
# - E241: multiple spaces after ','
# - E272: multiple spaces before keyword
# - E272: multiple spaces before keyword
#
#
# Let people use terse Python features:
# E7: Statement
# - E731: lambda expressions
# - E731: do not assign a lambda expression, use a def
#
# W5: Line break warning
# - W503: line break before binary operator
# - W504: line break after binary operator
#
#
# These are required to get the package.py files to test clean:
# These are required to get the package.py files to test clean:
# - F999: syntax error in doctest
# - F999: syntax error in doctest
#
#
#
Exempt to allow decorator classes to be lowercase, but follow otherwise:
#
N8: PEP8-naming
# - N801:
CapWords for class names.
# - N801:
class names should use CapWords convention
#
#
[
flake8
]
[
flake8
]
ignore
=
E129
,
E221
,
E241
,
E272
,
E731
,
F999
,
N801
,
W503
,
W504
ignore
=
E129
,
E221
,
E241
,
E272
,
E731
,
W503
,
W504
,
F999
,
N801
max
-
line
-
length
=
79
max
-
line
-
length
=
79
This diff is collapsed.
Click to expand it.
.flake8_packages
+
6
−
4
View file @
39725e07
...
@@ -7,16 +7,18 @@
...
@@ -7,16 +7,18 @@
# wildcard import and dependencies can set globals for their
# wildcard import and dependencies can set globals for their
# dependents. So we add exceptions for checks related to undefined names.
# dependents. So we add exceptions for checks related to undefined names.
#
#
# Note that we also add *per-line* exemptions for certain patters in the
# Note that we also add *per-line* exemptions for certain patter
n
s in the
# `spack flake8` command. This is where F403 for `from spack import *`
# `spack flake8` command. This is where F403 for `from spack import *`
# is added (beause we *only* allow that wildcard).
# is added (beause we *only* allow that wildcard).
#
#
# See .flake8 for regular exceptions.
# See .flake8 for regular exceptions.
#
#
#
Redefinition exceptions:
#
F4: Import
# - F405: `name` may be undefined, or undefined from star imports: `module`
# - F405: `name` may be undefined, or undefined from star imports: `module`
# - F821: undefined name `name` (needed for cmake, configure, etc.)
#
# F8: Name
# - F821: undefined name `name`
#
#
[
flake8
]
[
flake8
]
ignore
=
E129
,
E221
,
E241
,
E272
,
E731
,
F999
,
F405
,
F821
,
W503
,
W504
ignore
=
E129
,
E221
,
E241
,
E272
,
E731
,
W503
,
W504
,
F405
,
F821
,
F999
max
-
line
-
length
=
79
max
-
line
-
length
=
79
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment