Merge pull request #1235 from davydden/pkg/p4est_run_tests

p4est: use run_tests instead of a variant

var/spack/repos/builtin/packages/p4est/package.py

@@ -24,46 +24,42 @@
 ##############################################################################
 from spack import *
 
+
 class P4est(Package):
-    """Dynamic management of a collection (a forest) of adaptive octrees in parallel"""
+    """Dynamic management of a collection (a forest) of adaptive octrees in
+    parallel"""
     homepage = "http://www.p4est.org"
     url      = "http://p4est.github.io/release/p4est-1.1.tar.gz"
 
     version('1.1', '37ba7f4410958cfb38a2140339dbf64f')
 
-    variant('tests', default=True, description='Run small tests')
-
     # build dependencies
     depends_on('automake', type='build')
     depends_on('autoconf', type='build')
     depends_on('libtool@2.4.2:', type='build')
 
     # other dependencies
-    depends_on('lua') # Needed for the submodule sc
+    depends_on('lua')  # Needed for the submodule sc
     depends_on('mpi')
     depends_on('zlib')
 
     def install(self, spec, prefix):
-        options = ['--enable-mpi',
-                   '--enable-shared',
-                   '--disable-vtk-binary',
-                   '--without-blas',
-                   'CPPFLAGS=-DSC_LOG_PRIORITY=SC_LP_ESSENTIAL',
-                   'CFLAGS=-O2',
-                   'CC=%s'  % self.spec['mpi'].mpicc,
-                   'CXX=%s' % self.spec['mpi'].mpicxx,
-                   'FC=%s'  % self.spec['mpi'].mpifc,
-                   'F77=%s' % self.spec['mpi'].mpif77
-                  ]
+        options = [
+            '--enable-mpi',
+            '--enable-shared',
+            '--disable-vtk-binary',
+            '--without-blas',
+            'CPPFLAGS=-DSC_LOG_PRIORITY=SC_LP_ESSENTIAL',
+            'CFLAGS=-O2',
+            'CC=%s'  % self.spec['mpi'].mpicc,
+            'CXX=%s' % self.spec['mpi'].mpicxx,
+            'FC=%s'  % self.spec['mpi'].mpifc,
+            'F77=%s' % self.spec['mpi'].mpif77
+        ]
 
         configure('--prefix=%s' % prefix, *options)
 
         make()
-        # Make tests optional as sometimes mpiexec can't be run with an error:
-        # mpiexec has detected an attempt to run as root.
-        # Running at root is *strongly* discouraged as any mistake (e.g., in
-        # defining TMPDIR) or bug can result in catastrophic damage to the OS
-        # file system, leaving your system in an unusable state.
-        if '+tests' in self.spec:
-          make("check")
+        if self.run_tests:
+            make("check")
         make("install")