beast1 package: add version 1.10.4, use url_for_version (#11009)

var/spack/repos/builtin/packages/beast1/package.py

@@ -11,10 +11,9 @@ class Beast1(Package):
        analysis of molecular sequences using MCMC."""
 
     homepage = "http://beast.community/"
-    url      = "https://github.com/beast-dev/beast-mcmc/releases/download/v1.8.4/BEASTv1.8.4.tgz"
 
-    version('1.10.0', 'bcf2f2c074319360ec8a2ebad57d2e57', 
-            url='https://github.com/beast-dev/beast-mcmc/releases/download/v1.10.0/BEAST_v1.10.0.tgz')
+    version('1.10.4', sha256='be652c4d55953f7c6c7a9d3eb3de203c77dc380e81ad81cfe0492408990c36a8')
+    version('1.10.0', 'bcf2f2c074319360ec8a2ebad57d2e57')
     version('1.8.4', 'cb8752340c1f77a22d39ca4fe09687b0')
 
     variant('beagle', default=True, description='Build with libbeagle support')
@@ -22,6 +21,10 @@ class Beast1(Package):
     depends_on('java', type='run')
     depends_on('libbeagle', type=('build', 'link', 'run'), when="+beagle")
 
+    def url_for_version(self, ver):
+        base = 'https://github.com/beast-dev/beast-mcmc/releases/download'
+        return '{0}/v{1}/BEASTv{1}.tgz'.format(base, ver.dotted)
+
     def setup_environment(self, spack_env, run_env):
         run_env.set('BEAST1', self.prefix)