-
- Downloads
Fix satisfaction checks for excluding variants from matrices (#16893)
Because of the way abstract variants are implemented, the following spec matrix does not work as intended: ``` matrix: - [foo] - [bar=a, bar=b] exclude: - bar=a ``` because abstract variants always satisfy any variant of the same name, regardless of values. This PR converts abstract variants to whatever their appropriate type is before running satisfaction checks for the excludes clause in a matrix. fixes #16841
Showing
- lib/spack/spack/spec_list.py 12 additions, 0 deletionslib/spack/spack/spec_list.py
- lib/spack/spack/test/cmd/dependents.py 5 additions, 5 deletionslib/spack/spack/test/cmd/dependents.py
- lib/spack/spack/test/spec_list.py 7 additions, 0 deletionslib/spack/spack/test/spec_list.py
- lib/spack/spack/test/spec_semantics.py 42 additions, 42 deletionslib/spack/spack/test/spec_semantics.py
- lib/spack/spack/test/spec_yaml.py 1 addition, 1 deletionlib/spack/spack/test/spec_yaml.py
- lib/spack/spack/variant.py 12 additions, 1 deletionlib/spack/spack/variant.py
- var/spack/repos/builtin.mock/packages/multivalue-variant/package.py 0 additions, 0 deletions...repos/builtin.mock/packages/multivalue-variant/package.py
- var/spack/repos/builtin.mock/packages/singlevalue-variant-dependent/package.py 1 addition, 1 deletion...in.mock/packages/singlevalue-variant-dependent/package.py
Loading
Please register or sign in to comment