Skip to content
Snippets Groups Projects
  • Brett Viren's avatar
    2d1430da
    Address all coments in @trws's latest comment in PR #869. · 2d1430da
    Brett Viren authored
    I addressed them by factoring the code better to follow the visitor
    pattern.  This will allow actions to be easily added in the future.
    These may not even be file sytsem views.  One could add actions to
    generate shell init scripts, JSON DAG-dumpers, GraphViz DOT file
    generators, etc (yes, some of these are alread in there - just to give
    the idea).
    
    Also added is a top-level test
    
     $ source share/spack/setup-env.sh
     $ ./share/spack/examples/test_view.sh
    
    Read the top of that script first.
    2d1430da
    History
    Address all coments in @trws's latest comment in PR #869.
    Brett Viren authored
    I addressed them by factoring the code better to follow the visitor
    pattern.  This will allow actions to be easily added in the future.
    These may not even be file sytsem views.  One could add actions to
    generate shell init scripts, JSON DAG-dumpers, GraphViz DOT file
    generators, etc (yes, some of these are alread in there - just to give
    the idea).
    
    Also added is a top-level test
    
     $ source share/spack/setup-env.sh
     $ ./share/spack/examples/test_view.sh
    
    Read the top of that script first.