Spack: simplify local extension package for podio

spack/packages/podio/cpack.patch

---- a/CMakeLists.txt
-+++ b/CMakeLists.txt
-@@ -86,7 +86,7 @@ include(cmake/podioMacros.cmake)
- include(CTest)
- 
- #--- enable CPack --------------------------------------------------------------
--include(cmake/podioCPack.cmake)
-+#include(cmake/podioCPack.cmake)
- 
- #--- target for Doxygen documentation ------------------------------------------
- if(CREATE_DOC)

spack/packages/podio/dictloading.patch

-diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
-index 120a899..05991f1 100755
---- a/src/CMakeLists.txt
-+++ b/src/CMakeLists.txt
-@@ -41,7 +41,7 @@ SET(headers
-   ${CMAKE_SOURCE_DIR}/include/podio/PythonEventStore.h
-   )
- PODIO_GENERATE_DICTIONARY(podioDict ${headers} SELECTION selection.xml
--  OPTIONS --library ${CMAKE_SHARED_LIBRARY_PREFIX}podio${CMAKE_SHARED_LIBRARY_SUFFIX}
-+  OPTIONS --library ${CMAKE_SHARED_LIBRARY_PREFIX}podioDict${CMAKE_SHARED_LIBRARY_SUFFIX}
-   )
- # prevent generating dictionary twice
- set_target_properties(podioDict-dictgen PROPERTIES EXCLUDE_FROM_ALL TRUE)
-@@ -58,5 +58,5 @@ install(TARGETS podio podioDict podioRootIO
- install(DIRECTORY ${PROJECT_SOURCE_DIR}/include/podio DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}")
- install(FILES
-   ${CMAKE_CURRENT_BINARY_DIR}/podioDictDict.rootmap
--  ${CMAKE_CURRENT_BINARY_DIR}/libpodio_rdict.pcm
-+  ${CMAKE_CURRENT_BINARY_DIR}/libpodioDict_rdict.pcm
-   DESTINATION "${CMAKE_INSTALL_LIBDIR}")

spack/packages/podio/package.py

-# Copyright 2013-2021 Lawrence Livermore National Security, LLC and other
-# Spack Project Developers. See the top-level COPYRIGHT file for details.
-#
-# SPDX-License-Identifier: (Apache-2.0 OR MIT)
+from spack import *
+from spack.pkg.builtin.podio import Podio as BuiltinPodio
 
 
-class Podio(CMakePackage):
-    """PODIO, or plain-old-data I/O, is a C++ library to support the creation
-    and handling of data models in particle physics."""
-
-    homepage = "https://github.com/AIDASoft/podio"
-    url      = "https://github.com/AIDASoft/podio/archive/v00-09-02.tar.gz"
-    git      = "https://github.com/AIDASoft/podio.git"
-
-    maintainers = ['vvolkl', 'drbenmorgan']
-
-    tags = ["hep", "key4hep"]
-
-    version('master', branch='master')
-    version('0.14', sha256='47f99f1190dc71d6deb52a2b1831250515dbd5c9e0f263c3c8553ffc5b260dfb')
-    version('0.13.2', sha256='645f6915ca6f34789157c0a9dc8b0e9ec901e019b96eb8a68fb39011602e92eb')
-    version('0.13.1', sha256='2ae561c2a0e46c44245aa2098772374ad246c9fcb1956875c95c69c963501353')
-    version('0.13', sha256='e9cbd4e25730003d3706ad82e28b15cb5bdc524a78b0a26e90b89ea852101498')
-    version('0.12', sha256='1729a2ce21e8b307fc37dfb9a9f5ae031e9f4be4992385cf99dba3e5fdf5323a')
-    version('0.11', sha256='4b2765566a14f0ddece2c894634e0a8e4f42f3e44392addb9110d856f6267fb6')
-    version('0.10', sha256='b5b42770ec8b96bcd2748abc05669dd3e4d4cc84f81ed57d57d2eda1ade90ef2')
-    version('0.9.2', sha256='8234d1b9636029124235ef81199a1220968dcc7fdaeab81cdc96a47af332d240')
-    version('0.9', sha256='3cde67556b6b76fd2d004adfaa3b3b6173a110c0c209792bfdb5f9353e21076f')
-    version('0.8', sha256='9d035a7f5ebfae5279a17405003206853271af692f762e2bac8e73825f2af327')
-
-    variant('sio', default=False,
-            description='Build the SIO I/O backend')
-
-    # cpack config throws an error on some systems
-    patch('cpack.patch', when="@:0.10.0")
-    patch('dictloading.patch', when="@0.10.0")
-    patch('python-tests.patch', when='@:0.14.0')
-
-    # issue with build braking for spack as the search-and-replace for "root" 
+class Podio(BuiltinPodio):
+    # issue with build breaking for spack as the search-and-replace for "root"
     # erroneously selects the all files as the build happens under /tmp/root
     patch('cmake.patch', when="@0.13.1:0.14")
-
-    depends_on('root@6.08.06: cxxstd=17')
-
-    depends_on('cmake@3.8:', type='build')
-    depends_on('python', type=('build', 'run'))
-    depends_on('py-pyyaml', type=('build', 'run'))
-    depends_on('py-jinja2@2.10.1:', type=('build', 'run'), when='@0.12.0:')
-    depends_on('sio', type=('build', 'link'), when='+sio')
-    depends_on('catch2@3.0.1:', type=('test'), when="@0.13:")
-
-    conflicts('+sio', when='@:0.12', msg='sio support requires at least podio@0.13')
-
-    def cmake_args(self):
-        args = [
-            self.define_from_variant('ENABLE_SIO', 'sio'),
-            self.define("BUILD_TESTING", self.run_tests),
-        ]
-        return args
-
-    def setup_run_environment(self, env):
-        env.prepend_path('PYTHONPATH', self.prefix.python)
-
-    def url_for_version(self, version):
-        """Translate version numbers to ilcsoft conventions.
-        in spack, the convention is: 0.1 (or 0.1.0) 0.1.1, 0.2, 0.2.1 ...
-        in ilcsoft, releases are dashed and padded with a leading zero
-        the patch version is omitted when 0
-        so for example v01-12-01, v01-12 ...
-        :param self: spack package class that has a url
-        :type self: class: `spack.PackageBase`
-        :param version: version
-        :type param: str
-        """
-        base_url = self.url.rsplit('/', 1)[0]
-
-        if len(version) == 1:
-            major = version[0]
-            minor, patch = 0, 0
-        elif len(version) == 2:
-            major, minor = version
-            patch = 0
-        else:
-            major, minor, patch = version
-
-        # By now the data is normalized enough to handle it easily depending
-        # on the value of the patch version
-        if patch == 0:
-            version_str = 'v%02d-%02d.tar.gz' % (major, minor)
-        else:
-            version_str = 'v%02d-%02d-%02d.tar.gz' % (major, minor, patch)
-
-        return base_url + '/' + version_str

spack/packages/podio/python-tests.patch

-index 5b6e13e..ac9ccf5 100644
---- a/tests/CMakeLists.txt
-+++ b/tests/CMakeLists.txt
-@@ -106,7 +106,7 @@ endif()
- add_test( NAME pyunittest COMMAND python -m unittest discover -s ${CMAKE_SOURCE_DIR}/python)
- set_property(TEST pyunittest
-              PROPERTY ENVIRONMENT
--                      LD_LIBRARY_PATH=${CMAKE_CURRENT_BINARY_DIR}:${CMAKE_BINARY_DIR}/src:$ENV{LD_LIBRARY_PATH}
-+                      LD_LIBRARY_PATH=${CMAKE_CURRENT_BINARY_DIR}:${CMAKE_BINARY_DIR}/src:$<TARGET_FILE_DIR:ROOT::Tree>
-                       PYTHONPATH=${CMAKE_SOURCE_DIR}/python:$ENV{PYTHONPATH}
-                       ROOT_INCLUDE_PATH=${CMAKE_SOURCE_DIR}/tests/datamodel:${ROOT_INCLUDE_PATH})
- set_property(TEST pyunittest PROPERTY DEPENDS write)