Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • Project Juggler Project Juggler
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 33
    • Issues 33
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 23
    • Merge requests 23
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • EIC
  • Project JugglerProject Juggler
  • Merge requests
  • !494

Updated ACTS seeding code fixing multiple issues

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Yue Shi Lai requested to merge seeding-epic into main Nov 05, 2022
  • Overview 2
  • Commits 5
  • Pipelines 6
  • Changes 1

Avoid NaN and std::bad_alloc inside ACTS during the grid creation, due to specific pseudorapidity coverage, field strength, and minimum pT; custom association of hit to tracking surfaces; additional memory debugging checks

The following issues with the previous code are addressed:

  • std::bad_alloc inside ACTS for virtually any EIC acceptance coverage, field strength and minimum pT (!). Note that given an acceptance out to 3-4, the minimum pT has to be set very low, as ACTS does not permit this mandatory cut to be set by the momentum magnitude.
  • Inefficient and sometimes incorrect hit-surface association, fixed by (re-)determine the hit-surface association through geometry service inside the seeding code. Removed source links as input, as this is now not needed anymore.
  • Removed eicd/edm4eic inheritance, which appears to has side-effects impacting seeding efficiency at 40 degrees angle
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: seeding-epic