clang-tidy: fix source_location issues

.gitlab-ci.yml

@@ -90,7 +90,7 @@ analysis:clang-tidy:
     - juggler:local
   script:
     - |
-      run-clang-tidy-13 -p build -j20 -export-fixes clang_tidy_fixes.yml
+      run-clang-tidy-13 -p build -j20 -export-fixes clang_tidy_fixes.yml -extra-arg='-std=c++17'
   artifacts:
     expire_in: 1 week
     paths:

JugBase/src/components/EICDataSvc.cpp

@@ -2,6 +2,7 @@
 
 // Instantiation of a static factory class used by clients to create
 // instances of this service
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(EICDataSvc)
 
 /// Standard Constructor

JugBase/src/components/GeoSvc.cpp

@@ -75,6 +75,7 @@ void draw_surfaces(std::shared_ptr<const Acts::TrackingGeometry> trk_geo, const
 
 using namespace Gaudi;
 
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(GeoSvc)
 
 GeoSvc::GeoSvc(const std::string& name, ISvcLocator* svc)

JugBase/src/components/InputCopier.cpp

@@ -59,12 +59,15 @@ namespace Jug {
     };
 
     using CalorimeterColCopier = InputCopier<edm4hep::SimCalorimeterHitCollection, edm4hep::SimCalorimeterHitCollection>;
+    // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
     DECLARE_COMPONENT(CalorimeterColCopier)
 
     using TrackerColCopier = InputCopier<edm4hep::SimTrackerHitCollection, edm4hep::SimTrackerHitCollection>;
+    // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
     DECLARE_COMPONENT(TrackerColCopier)
 
     using MCCopier = InputCopier<edm4hep::MCParticleCollection, edm4hep::MCParticleCollection>;
+    // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
     DECLARE_COMPONENT(MCCopier)
 
   } // namespace Examples

JugBase/src/components/ParticleSvc.cpp

 #include "ParticleSvc.h"
 
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(ParticleSvc)
 
 namespace {

JugBase/src/components/PodioInput.cpp

@@ -6,6 +6,7 @@
 #include "JugBase/DataWrapper.h"
 #include "JugBase/PodioDataSvc.h"
 
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(PodioInput)
 
 PodioInput::PodioInput(const std::string& name, ISvcLocator* svcLoc) : GaudiAlgorithm(name, svcLoc) {}

JugBase/src/components/PodioOutput.cpp

@@ -5,6 +5,7 @@
 #include "TFile.h"
 #include "rootutils.h"
 
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(PodioOutput)
 
 PodioOutput::PodioOutput(const std::string& name, ISvcLocator* svcLoc)

JugDigi/src/components/CalorimeterBirksCorr.cpp

@@ -97,6 +97,7 @@ namespace Jug::Digi {
       return StatusCode::SUCCESS;
     }
   };
+  // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
   DECLARE_COMPONENT(CalorimeterBirksCorr)
 
 } // namespace Jug::Digi

JugDigi/src/components/CalorimeterHitDigi.cpp

@@ -247,6 +247,7 @@ namespace Jug::Digi {
       }
     }
   };
+  // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
   DECLARE_COMPONENT(CalorimeterHitDigi)
 
 } // namespace Jug::Digi

JugDigi/src/components/PhotoMultiplierDigi.cpp

@@ -211,6 +211,7 @@ private:
     }
 };
 
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(PhotoMultiplierDigi)
 
 } // namespace Jug::Digi

JugDigi/src/components/SiliconTrackerDigi.cpp

@@ -92,6 +92,7 @@ public:
     return StatusCode::SUCCESS;
   }
 };
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(SiliconTrackerDigi)
 
 } // namespace Jug::Digi

JugDigi/src/components/SimTrackerHitsCollector.cpp

@@ -65,6 +65,7 @@ namespace Jug::Digi {
         return StatusCode::SUCCESS;
       }
     };
+    // NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
     DECLARE_COMPONENT(SimTrackerHitsCollector)
 
 } // namespace Jug::Digi

JugFast/src/components/ClusterMerger.cpp

@@ -137,6 +137,7 @@ public:
     return matched;
   }
 };
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(ClusterMerger)
 
 } // namespace Jug::Fast

JugFast/src/components/InclusiveKinematicsTruth.cpp

@@ -161,6 +161,7 @@ public:
   }
 };
 
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(InclusiveKinematicsTruth)
 
 } // namespace Jug::Fast

JugFast/src/components/MC2SmearedParticle.cpp

@@ -88,6 +88,7 @@ public:
   }
 };
 
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(MC2SmearedParticle)
 
 } // namespace Jug::Fast

JugFast/src/components/MatchClusters.cpp

@@ -196,6 +196,7 @@ private:
   }
 }; // namespace Jug::Fast
 
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(MatchClusters)
 
 } // namespace Jug::Fast

JugFast/src/components/ParticlesWithTruthPID.cpp

@@ -149,6 +149,7 @@ public:
   }
 }; // namespace Jug::Fast
 
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(ParticlesWithTruthPID)
 
 } // namespace Jug::Fast

JugFast/src/components/SmearedFarForwardParticles.cpp

@@ -409,6 +409,7 @@ private:
   }
 };
 
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(SmearedFarForwardParticles)
 
 } // namespace Jug::Fast

JugFast/src/components/TruthClustering.cpp

@@ -79,6 +79,7 @@ public:
   }
 };
 
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(TruthClustering)
 
 } // namespace Jug::Fast

JugFast/src/components/TruthEnergyPositionClusterMerger.cpp

@@ -182,6 +182,7 @@ public:
     return matched;
   }
 };
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-non-const-global-variables)
 DECLARE_COMPONENT(TruthEnergyPositionClusterMerger)
 
 } // namespace Jug::Fast