Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • I irt
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • EIC
  • irt
  • Issues
  • #5
Closed
Open
Issue created Nov 15, 2021 by Whitney Armstrong@whitOwner

Friendly coding suggestions:

Here are some comments I have to make while briefly going through the code.

  1. ROOT's TObject is not really needed anymore.
  2. Avoid using ROOT specific-stuff unless it is really needed. Example from my experience, TRef is usually more of a headache than helpful.
  3. From my other issue about using #include quotes : https://stackoverflow.com/a/3162067/13377601
  4. Avoid unnecessary inheritance. Example: TObject -> TransientParticle -> {ChargedParticle, OpticalPhoton}. I do not see any polymorphism in the interface so there is no need for inheritance at all here.
  5. The code is hard to read with all the pre-processor defines and logic.
  6. The IRT::Solve member function should (ideally) be const.
Assignee
Assign to
Time tracking