Skip to content
Snippets Groups Projects

Cleaning up env file

Merged Whitney Armstrong requested to merge cleanup_env_file into master
1 unresolved thread

Needed to fix common_bench!83 (merged)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
192 157 benchmarks:reconstruction:
193 158 stage: trigger
194 159 variables:
195 GITHUB_SHA: "${GITHUB_SHA}"
  • And you broke our integration with GitHub CI again with this MR. Put this back please. And don't merge without review (or don't change things after review).

    FYI @sly2j

  • @wdconinc Could you please create a new issue explaining what is going on with this github variable?

  • There's no issue to report here. Only remove variables that you know are unused. GitHub pipelines needs eicweb to report success of failure of pipelines run on eicweb. That is achieved with a GitHub repo and commit sha passed to the eicweb pipeline when triggered and a GitHub token stored as secret in the benchmarks projects here. Eicweb pipelines that trigger other eicweb pipelines must pass these variables to downstream too.

  • Please register or sign in to reply
Please register or sign in to reply
Loading