Skip to content
Snippets Groups Projects

Draft: add bin/build_eicrecon.sh (like the build_detector.sh)

Open Dmitry Kalinkin requested to merge pr/build_eicrecon into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dmitry Kalinkin added 1 commit

    added 1 commit

    • e5f3bf54 - add bin/build_eicrecon.sh (like the build_detector.sh)

    Compare with previous version

  • Not the correct repo for this. It should go in the container. The detector is included here because the detector should change. Any reconstruction should go in the container which will be used in the benchmarks.

    Otherwise the build logic and workflow gets another fork in it.

    @sly2j and @wdconinc please comment

  • Whitney Armstrong marked this merge request as draft

    marked this merge request as draft

  • There is as little (or as much) justification for building the geometry here as in the container. Both change just as frequently, and both can be implemented in the container in exactly the same way.

    I'm also less interested in these philosophical distinctions than in people getting work done that affects the tdr, so I err on the side of letting this get merged.

  • I understand but adding to the container would make the version tracking easier. The benchmarks were setup with version tracking of the container and the detector. Adding the build here would mean tracking a third version through the pipelines. It is easier to add to the version set of the container.

Please register or sign in to reply
Loading