Draft: add bin/build_eicrecon.sh (like the build_detector.sh)
Merge request reports
Activity
added 1 commit
- e5f3bf54 - add bin/build_eicrecon.sh (like the build_detector.sh)
Not the correct repo for this. It should go in the container. The detector is included here because the detector should change. Any reconstruction should go in the container which will be used in the benchmarks.
Otherwise the build logic and workflow gets another fork in it.
There is as little (or as much) justification for building the geometry here as in the container. Both change just as frequently, and both can be implemented in the container in exactly the same way.
I'm also less interested in these philosophical distinctions than in people getting work done that affects the tdr, so I err on the side of letting this get merged.
I understand but adding to the container would make the version tracking easier. The benchmarks were setup with version tracking of the container and the detector. Adding the build here would mean tracking a third version through the pipelines. It is easier to add to the version set of the container.