Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • N NPDet
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • EIC
  • NPDet
  • Merge requests
  • !26

Roman pots

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tom Polakovic requested to merge Polakovic/NPDet:master into master Mar 26, 2020
  • Overview 4
  • Commits 13
  • Pipelines 6
  • Changes 4

Right now, the code generates a RP unit which is a pair of two Pots and the description has a boolean that rotates the whole unit by 90 degrees. The description also allows for variable detector insertion depth, and support, detector and frame dimensions (the frame is not yet implemented in code - I have to meditate a bit more on that).

It compiles but throws a runtime error, probably because of the XML parsing (there's a FIXME in the code). That should be fixed soon.

The next step is to add layers into a single detector. That will be easy once I'm happy with the current state.

Just so you're notified, @whit.

Edited Mar 30, 2020 by Whitney Armstrong
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master