From 9b63651dfddc77bcc2e5a0607d7bcda39b793023 Mon Sep 17 00:00:00 2001
From: Brad Sawatzky <brads@jlab.org>
Date: Mon, 12 Apr 2021 18:07:48 -0400
Subject: [PATCH] ROOT build_dir fix/workaround
- Set the default build_dir to be under $PWD instead of $HOME
- should work better under a group account (with different personal
directories)
- Make the ROOT build process use a flat build directory by setting
second arg to kTRUE in gSystem->SetBuildDir()
- This avoids an apparent race condition in ROOT associated with child
directory creation in the default 'kFALSE' mode.
- The default mode will work correctly on the 2nd execution since the
child directories are created, ROOT just doesn't notice in time.
This would be fine for interactive use, but not great for the Farm
environment, hence the change.
- The flat build_dir namesapce does open a different corner-case
of course. However, I think this is an unlikely condition.
Things would be pretty broken/strange for two different scripts with
the same basename (but different internal code) to be compiled and
loaded without some significant warnings/errors anyway (famous last
words...)
---
.rootlogon.C | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/.rootlogon.C b/.rootlogon.C
index bc835dd..025be51 100644
--- a/.rootlogon.C
+++ b/.rootlogon.C
@@ -7,9 +7,9 @@ void _rootlogon() {
// check if we requested a special build directory through the environment,
const char* build_dir_from_env = gSystem->Getenv("ROOT_BUILD_TMPDIR");
- const std::string build_dir = build_dir_from_env ? build_dir_from_env : "$HOME/.root_build_dir";
+ const std::string build_dir = build_dir_from_env ? build_dir_from_env : "$PWD/.root_build_dir";
- // ensure the build directory exists to avoid crashes due a directory
+ // ensure the build directory exists to avoid crashes due to it missing
// note: in principle this allows us to execute arbitrary code, but seeing
// as this can only be manipulated through the shell environment in the
// first place this should not be a safety concern.
@@ -18,7 +18,12 @@ void _rootlogon() {
// Communicate what build directory we are using
std::cout << "---> Setting ACLiC build directory to: " << build_dir << "\n\n";
- gSystem->SetBuildDir(build_dir.c_str());
+ // Make the ROOT build process use a flat build directory by setting
+ // second arg to kTRUE. This avoids an apparent race condition in ROOT
+ // associated with child directory creation in the default 'kFALSE' mode.
+ // The default mode will work correctly on the 2nd execution. OK for
+ // interactive use, but not great for the Farm environment.
+ gSystem->SetBuildDir(build_dir.c_str(), kTRUE);
// Ensure we have our environment setup
gROOT->ProcessLine(".include /usr/local/include/hcana");
--
GitLab