EIC issueshttps://eicweb.phy.anl.gov/groups/EIC/-/issues2022-06-25T03:39:33Zhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/99TrackProjector: generalize by passing target surface as option2022-06-25T03:39:33ZWouter DeconinckTrackProjector: generalize by passing target surface as optionThe current [TrackProjector](https://eicweb.phy.anl.gov/EIC/juggler/-/blob/master/JugTrack/src/components/TrackProjector.cpp) has some hardcoded assumptions, i.e. https://eicweb.phy.anl.gov/EIC/juggler/-/blob/master/JugTrack/src/componen...The current [TrackProjector](https://eicweb.phy.anl.gov/EIC/juggler/-/blob/master/JugTrack/src/components/TrackProjector.cpp) has some hardcoded assumptions, i.e. https://eicweb.phy.anl.gov/EIC/juggler/-/blob/master/JugTrack/src/components/TrackProjector.cpp#L128-129
```c++
if (pathlength_at_reflayer<0 && volume==29 && layer==4 && trackstate.hasCalibrated()) pathlength_at_reflayer = pathlength; // 2nd outter barrel
if (pathlength_at_reflayer<0 && pathlength>1700) pathlength_at_reflayer = pathlength; // endcap GEM layer
```
We should change this to be more generic.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/ecce/-/issues/18dRICH: increase z-length, and add space for services2022-07-20T09:18:10ZChristopher DilksdRICH: increase z-length, and add space for servicesnew dimensions and z-position from <https://indico.bnl.gov/event/16314/>
![2022-07-19-203317_783x439_scrot](/uploads/8cb4dcd2541e7f072548d3d6aa3717cf/2022-07-19-203317_783x439_scrot.png)new dimensions and z-position from <https://indico.bnl.gov/event/16314/>
![2022-07-19-203317_783x439_scrot](/uploads/8cb4dcd2541e7f072548d3d6aa3717cf/2022-07-19-203317_783x439_scrot.png)Christopher DilksChristopher Dilkshttps://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/issues/64Check ZDC particle gun acceptance2022-07-05T19:45:16ZAlex JentschCheck ZDC particle gun acceptanceAlex JentschAlex Jentschhttps://eicweb.phy.anl.gov/EIC/detectors/ip6/-/issues/56ZDC rotation and alignment2022-06-22T14:01:25ZAlex JentschZDC rotation and alignmentAlex JentschAlex Jentschhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/98Enable -Wsign-conversion to avoid implicit conversions2022-06-22T01:24:09ZWouter DeconinckEnable -Wsign-conversion to avoid implicit conversionsYet another signed to unsigned implicit conversion caused under threshold reconstructed hit energies to overflow... !423 !415 #90Yet another signed to unsigned implicit conversion caused under threshold reconstructed hit energies to overflow... !423 !415 #90Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/97ClusterRecoCoG introduces NaN in cluster energies2022-07-05T15:09:06ZWouter DeconinckClusterRecoCoG introduces NaN in cluster energiesFor `tw == 0` the following [lines](https://eicweb.phy.anl.gov/EIC/juggler/-/blob/master/JugReco/src/components/ClusterRecoCoG.cpp#L199) introduce a `NaN`:
```c++
if (tw == 0.) {
warning() << "zero total weights encountered, yo...For `tw == 0` the following [lines](https://eicweb.phy.anl.gov/EIC/juggler/-/blob/master/JugReco/src/components/ClusterRecoCoG.cpp#L199) introduce a `NaN`:
```c++
if (tw == 0.) {
warning() << "zero total weights encountered, you may want to adjust your weighting parameter." << endmsg;
}
cl.setPosition(v / tw);
```Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/irt/-/issues/7refactor `EVALUATION` for the `edm4hep` update2022-08-04T17:04:10ZChristopher Dilksrefactor `EVALUATION` for the `edm4hep` updateSince the data model has changed, we need to refactor some of the `evaluation` code. Things to do include:
- update our usage of `eic::Index`, since we now use PODIO relations instead
- should we use `edm4hep::MCParticle` to replace `dd4...Since the data model has changed, we need to refactor some of the `evaluation` code. Things to do include:
- update our usage of `eic::Index`, since we now use PODIO relations instead
- should we use `edm4hep::MCParticle` to replace `dd4pod::Geant4Particle`?
- how to match `ReconstructedParticle` to the MC generated particle? we no longer have `mcID`, do we need to add a relation in `eicd`?https://eicweb.phy.anl.gov/EIC/juggler/-/issues/96Implement SimTrackerHitsMerger to overlay/merge background events2022-06-18T03:28:20ZWouter DeconinckImplement SimTrackerHitsMerger to overlay/merge background eventsSimTrackerHitsCollector is an example class implementation.
Specs:
- SimTrackerHitsMerger can take a number of input collections, along with probabilities for each to be picked,
- With probability, it merges one of each of the input col...SimTrackerHitsCollector is an example class implementation.
Specs:
- SimTrackerHitsMerger can take a number of input collections, along with probabilities for each to be picked,
- With probability, it merges one of each of the input collections into the output collection.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/ecce/-/issues/17dRICH: produce IRT geometry objects2022-07-21T04:18:58ZChristopher DilksdRICH: produce IRT geometry objectsWe would like to connect the IRT geometry objects to the geometry description. We have tried doing this at the `Juggler` level, using `GeoSvc`, but find it more practical to keep the IRT geometry code integrated directly *with* the detec...We would like to connect the IRT geometry objects to the geometry description. We have tried doing this at the `Juggler` level, using `GeoSvc`, but find it more practical to keep the IRT geometry code integrated directly *with* the detector geometry code. We could automate the production of a "configuration" file containing IRT geometry objects, generated by `src/DRICH_geo.cpp` as needed.
This is how we ran for ATHENA, using https://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/331 but we will need to think about how to best handle the extra configuration file in CI pipelines.Christopher DilksChristopher Dilkshttps://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/issues/63Job Failed #707754: intermittent field map errors2022-06-14T21:00:48ZWouter DeconinckJob Failed #707754: intermittent field map errorsJob [#707754](https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/707754) failed for c2501e8ac89d393cf7da919715a14e5ad96752f6:Job [#707754](https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/707754) failed for c2501e8ac89d393cf7da919715a14e5ad96752f6:https://eicweb.phy.anl.gov/EIC/benchmarks/common_bench/-/issues/6Add JUGGLER_DETECTOR_CONFIG2022-06-15T00:40:25ZWouter DeconinckAdd JUGGLER_DETECTOR_CONFIGWe need a way to specify the geometry entry point for benchmarks.We need a way to specify the geometry entry point for benchmarks.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/ecce/-/issues/16Revert e20517c042f107fa539e7a77100ebba0f3ea63a8 (source dir pollution)2022-06-15T00:05:21ZWouter DeconinckRevert e20517c042f107fa539e7a77100ebba0f3ea63a8 (source dir pollution)e20517c042f107fa539e7a77100ebba0f3ea63a8 was introduced because downstream uses DETECTOR_PATH pointing to the source directory.e20517c042f107fa539e7a77100ebba0f3ea63a8 was introduced because downstream uses DETECTOR_PATH pointing to the source directory.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/common_bench/-/issues/5DETECTOR_PATH should point to CMAKE_INSTALL_PREFIX subtree, not source dir2023-10-02T00:31:22ZWouter DeconinckDETECTOR_PATH should point to CMAKE_INSTALL_PREFIX subtree, not source dirRight now DETECTOR_PATH is set (in `env.sh`) to ${LOCAL_PREFIX}/detector which is where the detector geometry repository is cloned into.
```console
## detector prefix: prefix for the detector definitions
export DETECTOR_PREFIX="${LOCAL_P...Right now DETECTOR_PATH is set (in `env.sh`) to ${LOCAL_PREFIX}/detector which is where the detector geometry repository is cloned into.
```console
## detector prefix: prefix for the detector definitions
export DETECTOR_PREFIX="${LOCAL_PREFIX}/detector"
mkdir -p ${DETECTOR_PREFIX}
## detector path: actual detector definition path
export DETECTOR_PATH="${DETECTOR_PREFIX}/${JUGGLER_DETECTOR}"
```
That means any `make install` doesn't actually get used.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/95JugFast::MatchClusters needs updating for EDM4hep migration2022-06-10T18:30:37ZSylvester JoostenJugFast::MatchClusters needs updating for EDM4hep migrationhttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/47JugFast::MatchClusters needs updating for EDM4hep migration2022-06-10T18:30:38ZSylvester JoostenJugFast::MatchClusters needs updating for EDM4hep migrationhttps://eicweb.phy.anl.gov/EIC/detectors/ecce/-/issues/15How can we identify downstream (in sh or py files) which features are include...2022-06-07T02:44:33ZWouter DeconinckHow can we identify downstream (in sh or py files) which features are included in the detector?Use cases:
* we want to run a job only when the geometry has MRICH, but not when the geometry has PFRICH.
* we want a python options file to include the imaging layer algorithms when we have an imaging calorimeter.
We are using JUGGLER_...Use cases:
* we want to run a job only when the geometry has MRICH, but not when the geometry has PFRICH.
* we want a python options file to include the imaging layer algorithms when we have an imaging calorimeter.
We are using JUGGLER_DETECTOR and JUGGLER_DETECTOR_VERSION, but that doesn't scale beyond acadia/other and athena/ecce, not more fine-grained.https://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/issues/87Re-enable layer-based energy profile in imaging_ecal benchmarks2022-06-05T21:46:37ZWouter DeconinckRe-enable layer-based energy profile in imaging_ecal benchmarks- [ ] 27fa81442d5cba3634e6c70f92dcf734872e48c2
- [ ] 7268d02a51f983c1dfecac0c7592b1d288d06f1d
This will require some thinking about how to get `utils.py` `get_layers_data` to return the same structures.- [ ] 27fa81442d5cba3634e6c70f92dcf734872e48c2
- [ ] 7268d02a51f983c1dfecac0c7592b1d288d06f1d
This will require some thinking about how to get `utils.py` `get_layers_data` to return the same structures.https://eicweb.phy.anl.gov/EIC/juggler/-/issues/94Ensure MRs from forks do not fail due to missing docker secrets2022-06-01T18:23:57ZWouter DeconinckEnsure MRs from forks do not fail due to missing docker secretsThis likely is just a matter of skipping the docker push when no secrets are available.This likely is just a matter of skipping the docker push when no secrets are available.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/ecce/-/issues/14Add options for envelopes where we use assemblies2022-06-02T23:14:07ZWouter DeconinckAdd options for envelopes where we use assembliesBetter performance, better graphics rendering.
E.g.
- [x] HomogeneousCalorimeter_geo: add_disk
- [x] HomogeneousCalorimeter_geo: add_array
- [ ] ~~HomogeneousCalorimeter_geo: add_lines~~Better performance, better graphics rendering.
E.g.
- [x] HomogeneousCalorimeter_geo: add_disk
- [x] HomogeneousCalorimeter_geo: add_array
- [ ] ~~HomogeneousCalorimeter_geo: add_lines~~Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/ecce/-/issues/13Certificate issue when downloading field map: CAfile:/etc/pki/tls/certs/ca-bu...2022-07-21T15:44:47ZWouter DeconinckCertificate issue when downloading field map: CAfile:/etc/pki/tls/certs/ca-bundle.crt```
Compact INFO ++ Converted subdetector:SolenoidCoilBarrel of type athena_SolenoidCoil
Compact INFO ++ Converted subdetector:SolenoidCoilEndcapP of type ref_SolenoidEndcap
Compact INFO ++ Converted subdete...```
Compact INFO ++ Converted subdetector:SolenoidCoilBarrel of type athena_SolenoidCoil
Compact INFO ++ Converted subdetector:SolenoidCoilEndcapP of type ref_SolenoidEndcap
Compact INFO ++ Converted subdetector:SolenoidCoilEndcapN of type ref_SolenoidEndcap
FileLoader INFO Cache
FileLoader INFO Downloading fieldmaps/EIC_v.2.0.3_Magnetic_Field_Map_2021_09_28_radial_coords_cm_T.Bmap.txt as hash 6567da5a4887ad9b with curl --retry 5 -f https://eicweb.phy.anl.gov/EIC/detectors/athena/uploads/fd64db33e1c99547ab1840d8847fd1c1/EIC_v.2.0.3_Magnetic_Field_Map_2021_09_28_radial_coords_cm_T.Bmap.txt -o fieldmaps/6567da5a4887ad9b
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- 0 0 0 0 0 0 0 0 --:--:-- --:--:-- 0 0 0 0 0 0 0 0 --:--:-- --:--:----:--:-- 0
curl: (77) error setting certificate verify locations: CAfile:/etc/pki/tls/certs/ca-bundle.crt CApath: none
FileLoader ERROR unable to run cmd curl --retry 5 -f https://eicweb.phy.anl.gov/EIC/detectors/athena/uploads/fd64db33e1c99547ab1840d8847fd1c1/EIC_v.2.0.3_Magnetic_Field_Map_2021_09_28_radial_coords_cm_T.Bmap.txt -o fieldmaps/6567da5a4887ad9b
FileLoader ERROR check command and retry
nightly> akshaya@narval1:~/projects/def-wdconinc/akshaya/EIC$
```