EIC issueshttps://eicweb.phy.anl.gov/groups/EIC/-/issues2022-03-27T23:57:44Zhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/89Fill association simID with `part.id()` instead of `part.getObjectID().index`2022-03-27T23:57:44ZWouter DeconinckFill association simID with `part.id()` instead of `part.getObjectID().index`Seems limited to a few instances only, but we are probably not writing associations everywhere we should be writing them.Seems limited to a few instances only, but we are probably not writing associations everywhere we should be writing them.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/compton/-/issues/1Implementing full EIC magnet set2022-04-03T20:13:19ZWouter DeconinckImplementing full EIC magnet setWe should expand the number of magnets that are currently implemented in the geometry from the single one that is there now. To get started, click on the "create merge request" link on this issue, then start a Web IDE (or check out a bra...We should expand the number of magnets that are currently implemented in the geometry from the single one that is there now. To get started, click on the "create merge request" link on this issue, then start a Web IDE (or check out a branch).Omar HassanOmar Hassanhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/149Dump geometry CI job should also produce FF geometry separately2022-03-19T16:45:32ZWouter DeconinckDump geometry CI job should also produce FF geometry separatelyCurrently we produce root files with geometry output for all types of component-combinations, but nothing specific to FF. @ajentschCurrently we produce root files with geometry output for all types of component-combinations, but nothing specific to FF. @ajentschWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/42Job Failed #597011: fast_ff association failure2022-03-01T21:39:07ZWouter DeconinckJob Failed #597011: fast_ff association failureJob [#597011](https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/597011) failed for 8595e1ccbfee59b6df7c85120cb4359e50d7536b:Job [#597011](https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/597011) failed for 8595e1ccbfee59b6df7c85120cb4359e50d7536b:Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/86Raw (digitized) hit model redundant, use single unified RawHit2022-02-28T23:28:50ZSylvester JoostenRaw (digitized) hit model redundant, use single unified RawHitCurrently all digitized hit structures store the same basic information: 64bit cell ID, 32bit time stamp and 32bit value. There is no good reason for them to be separate classes. We should unify them into a single RawHit structure as thi...Currently all digitized hit structures store the same basic information: 64bit cell ID, 32bit time stamp and 32bit value. There is no good reason for them to be separate classes. We should unify them into a single RawHit structure as this will provide us with more flexibility down the road. And when needed we can add data structures that actually store different information as we go. Proposed structure:
```
RawHit:
Description: Raw detector hit storing one 32-bit word of information
Members:
- uint64_t cellID
- uint32_t timeStamp
- uint32_t value
```https://eicweb.phy.anl.gov/EIC/detectors/ip6/-/issues/53Update ZDC Material and Cracks2022-02-25T21:52:09ZJihee KimUpdate ZDC Material and CracksUpdate standard scintillator material and cracksUpdate standard scintillator material and cracksJihee KimJihee Kimhttps://eicweb.phy.anl.gov/EIC/eicd/-/issues/25C++17 compatibility for vector_utils.h2022-02-22T22:55:32ZSylvester JoostenC++17 compatibility for vector_utils.hvector_utils.h right now requires C++20 (concepts). This clashes with ROOT versions compiled with C++17 only. We can resolve this by having a fall-back implementation (vector_utils_legacy.h) that is loaded when Concepts are not available...vector_utils.h right now requires C++20 (concepts). This clashes with ROOT versions compiled with C++17 only. We can resolve this by having a fall-back implementation (vector_utils_legacy.h) that is loaded when Concepts are not available that is as close as possible to the version with concepts in functionality.Sylvester JoostenSylvester Joostenhttps://eicweb.phy.anl.gov/EIC/eicd/-/issues/24Move closer to EDM4hep (part 2)2022-03-01T18:49:42ZSylvester JoostenMove closer to EDM4hep (part 2)- [x] Remove remaining overlapping datatypes in favor of includes from EDM4hep
- [x] Migrate away from using eic::Index in favor of explicit relations
- [x] Use get/set syntax consistent with EDM4hep- [x] Remove remaining overlapping datatypes in favor of includes from EDM4hep
- [x] Migrate away from using eic::Index in favor of explicit relations
- [x] Use get/set syntax consistent with EDM4hephttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/146DRICHHits (usually) empty after the change of `sens.setType("photoncounter")`...2022-06-12T06:15:38ZChristopher DilksDRICHHits (usually) empty after the change of `sens.setType("photoncounter")` to `tracker`After https://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/330 was merged, the `DRICHHits` branch is usually empty (or there are only a few sporadic entries). If I try reverting the type back to `photoncounter`, we see the ex...After https://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/330 was merged, the `DRICHHits` branch is usually empty (or there are only a few sporadic entries). If I try reverting the type back to `photoncounter`, we see the expected distribution.
Using MR https://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/332 for testing: see artifact `test.png` from job `test_drich`
Steps to reproduce (executed from top-level `athena` directory):
```
npsim --runType run --compactFile compact/subsystem_views/drich_only.xml --macro test.mac --outputFile test.root --enableG4GPS
```
where `test.mac` is
```
/control/verbose 2
/run/initialize
/gps/verbose 2
/gps/particle pi+
/gps/number 1
/gps/ene/mono 20 GeV
/gps/position 0 0 0 cm
/gps/direction 0.25 0.0 1.0
/run/beamOn 50
```
Opening `test.root` and running `events->Draw("DRICHHits.position.x")` should produce a distribution that looks like the attached image, but is coming out empty (or sometimes a few sporadic hits)
It is likely the pfRICH is also affected.
![photoncounter](/uploads/b0d3bad0892f26ccb60ffe8e94b8dd27/photoncounter.png)https://eicweb.phy.anl.gov/EIC/detectors/ip6/-/issues/52Job Failed #573335 overlap_check fails due to missing juggler.env2022-02-13T18:53:21ZWouter DeconinckJob Failed #573335 overlap_check fails due to missing juggler.envJob [#573335](https://eicweb.phy.anl.gov/EIC/detectors/ip6/-/jobs/573335) failed for aa072ca71b60c0beddbf8feba0f926b34bac1d30:Job [#573335](https://eicweb.phy.anl.gov/EIC/detectors/ip6/-/jobs/573335) failed for aa072ca71b60c0beddbf8feba0f926b34bac1d30:Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/irt/-/issues/6rename eRICH to pfRICH2022-02-12T02:15:35ZChristopher Dilksrename eRICH to pfRICHthis change is starting to happen in other repositories, we should make the change here toothis change is starting to happen in other repositories, we should make the change here tooChristopher DilksChristopher Dilkshttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/143RICH only compact files fail with `dd_web_display`2022-02-09T23:35:46ZChristopher DilksRICH only compact files fail with `dd_web_display````
$ dd_web_display --export athena/compact/subsystem_views/drich_only.xml
```
```
Warning in <TGeoManager>: Changing system of units to ROOT units (cm, s, GeV).
DocumentHandler FATAL +++ Error (TinyXML) parsing XML document:ip6/ip6_d...```
$ dd_web_display --export athena/compact/subsystem_views/drich_only.xml
```
```
Warning in <TGeoManager>: Changing system of units to ROOT units (cm, s, GeV).
DocumentHandler FATAL +++ Error (TinyXML) parsing XML document:ip6/ip6_defs.xml [ip6/ip6_defs.xml]
DocumentHandler FATAL +++ Error (TinyXML) XML parsing error:Failed to open file
DocumentHandler FATAL +++ Document:ip6/ip6_defs.xml Location Line:0 Column:0
dd4hep:XML ERROR ++ file:ip6/ip6_defs.xml error:Failed to open file
DocumentHandler ERROR +++ Exception (TinyXML): parse(path):dd4hep:XML: ++ file:ip6/ip6_defs.xml error:Failed to open file
****************************************************
* A runtime error has occured :
* Document::root: Invalid handle!
dd4hep: Error interpreting XML nodes of type <include/>
dd4hep: Error interpreting XML nodes of type <define/>
dd4hep: while parsing athena/compact/subsystem_views/drich_only.xml
* the program will have to be terminated - sorry.
****************************************************
```Christopher DilksChristopher Dilkshttps://eicweb.phy.anl.gov/EIC/detectors/ip6/-/issues/51WSciFi Material2022-02-05T00:43:50ZJihee KimWSciFi MaterialZDC Ecal
`Polystyrene` with birks constant 0.126 mm/MeVZDC Ecal
`Polystyrene` with birks constant 0.126 mm/MeVJihee KimJihee Kimhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/142curl in FileLoader fails with certificate error2022-06-01T04:02:46ZWouter Deconinckcurl in FileLoader fails with certificate error```
Info in <TGeoManager::SetTopVolume>: Top volume is world_volume. Master volume is world_volume
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total S...```
Info in <TGeoManager::SetTopVolume>: Top volume is world_volume. Master volume is world_volume
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (77) error setting certificate verify locations: CAfile: /etc/pki/tls/certs/ca-bundle.crt CApath: none
```Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/78Update RP/OMD coordinates to local2022-02-18T19:09:41ZAlex JentschUpdate RP/OMD coordinates to localhttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/40Add ZDC hit reconstruction to main options/reconstruction.py2022-02-23T23:35:48ZWouter DeconinckAdd ZDC hit reconstruction to main options/reconstruction.pySee e.g. https://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/merge_requests/203See e.g. https://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/merge_requests/203Shujie LiShujie Lihttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/140Allow for FileLoader to use a fs::recursive_directory_iterator to find the ca...2022-01-23T17:39:30ZWouter DeconinckAllow for FileLoader to use a fs::recursive_directory_iterator to find the cached fileWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/139Allow for FileLoader to parse environment variables as part of the cache path2022-01-23T16:51:14ZWouter DeconinckAllow for FileLoader to parse environment variables as part of the cache pathWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/39Revert 361265642022-01-17T01:28:52ZWouter DeconinckRevert 3612656436126564 was a backwards compatibility commit which can be reverted after upgrade to juggler 5.036126564 was a backwards compatibility commit which can be reverted after upgrade to juggler 5.0Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/NPDet/-/issues/86Remove redundant optical physics processes (fail to compile with geant4 11.0.0)2022-01-12T00:25:18ZWouter DeconinckRemove redundant optical physics processes (fail to compile with geant4 11.0.0)https://eicweb.phy.anl.gov/EIC/NPDet/-/tree/master/src/plugins/src
These EICScintillationPhysics etc processes are also upstream in DD4hep, and in DD4hep 1.19+1 they will work with geant4 11.0.0. We shouldn't keep them around here.https://eicweb.phy.anl.gov/EIC/NPDet/-/tree/master/src/plugins/src
These EICScintillationPhysics etc processes are also upstream in DD4hep, and in DD4hep 1.19+1 they will work with geant4 11.0.0. We shouldn't keep them around here.Wouter DeconinckWouter Deconinck