EIC issueshttps://eicweb.phy.anl.gov/groups/EIC/-/issues2023-09-22T01:15:31Zhttps://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/issues/67Add summary of files artifact2023-09-22T01:15:31ZWhitney ArmstrongAdd summary of files artifactAdd a summary of all the final artifacts so that they can be subsequently processed.
Rather than using the API to query all the files, grab this summary file to know all the available results.Add a summary of all the final artifacts so that they can be subsequently processed.
Rather than using the API to query all the files, grab this summary file to know all the available results.https://eicweb.phy.anl.gov/EIC/juggler/-/issues/110clang-tidy unhappy again2022-10-12T18:35:54ZSylvester Joostenclang-tidy unhappy againJob [#1014803](https://eicweb.phy.anl.gov/EIC/juggler/-/jobs/1014803) failed for abb2e4abccbf18b082b9db78d0117cdd056ab368:Job [#1014803](https://eicweb.phy.anl.gov/EIC/juggler/-/jobs/1014803) failed for abb2e4abccbf18b082b9db78d0117cdd056ab368:https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/issues/65Job Failed #954527 - detector benchmarks - histogram range needs to be adjusted2022-10-04T00:47:52ZMaria ZurekJob Failed #954527 - detector benchmarks - histogram range needs to be adjustedJob [#954527](https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/954527) failed for b4e06a2997dbffcf4ba57de59135211865fdc663:
The histogram range needs to be dynamically adjusted with the changing sapling fraction.Job [#954527](https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/954527) failed for b4e06a2997dbffcf4ba57de59135211865fdc663:
The histogram range needs to be dynamically adjusted with the changing sapling fraction.Maria ZurekMaria Zurekhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/109feat: add automatic Property and Service Readiness evaluation to algorithms2022-09-29T22:05:18ZSylvester Joostenfeat: add automatic Property and Service Readiness evaluation to algorithmshttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/52eicweb/physics_benchmarks (epic_imaging) failing2022-10-03T16:15:35ZDmitry Kalinkineicweb/physics_benchmarks (epic_imaging) failingFor current EPIC main branch:
https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/937964For current EPIC main branch:
https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/937964https://eicweb.phy.anl.gov/EIC/juggler/-/issues/108Feat: add obligatory description field to Algorithm and Property2022-09-29T20:47:10ZSylvester JoostenFeat: add obligatory description field to Algorithm and Propertyhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/107Feature: Override-able thread-safe (but not reproducible) RandomSvc for algor...2022-09-29T19:56:35ZSylvester JoostenFeature: Override-able thread-safe (but not reproducible) RandomSvc for algorithms.https://eicweb.phy.anl.gov/EIC/juggler/-/issues/105Better algorithms Property integration2022-09-27T15:58:25ZSylvester JoostenBetter algorithms Property integrationCurrently `Property` passing between the framework and `algorithms` is based around `std::any`. This is not optimal as the type erasure makes automizing framework class generation almost impossible. I propose to use `std::variant` instea...Currently `Property` passing between the framework and `algorithms` is based around `std::any`. This is not optimal as the type erasure makes automizing framework class generation almost impossible. I propose to use `std::variant` instead. There are of course drawbacks (more limited), but those aren't IMO that important:
- people shouldn't be passing tons of data into a Property anyway
- the current `std::any` interface is a little fragile against people specifying the wrong type in one of the places (fragile as in runtime errors). It's probably better to have explicit compiler errors in case there are inconsistencieshttps://eicweb.phy.anl.gov/EIC/NPDet/-/issues/89Handle PFRICH in `npsim.py`2022-10-03T21:42:13ZChristopher DilksHandle PFRICH in `npsim.py`In `npsim.py`, we have settings unique for the DRICH, but these also need to be applied for the PFRICH. Relevant snippet:
```python
# Some detectors are only sensitive to optical photons
SIM.filter.filters['opticalphotons'] = dict(
...In `npsim.py`, we have settings unique for the DRICH, but these also need to be applied for the PFRICH. Relevant snippet:
```python
# Some detectors are only sensitive to optical photons
SIM.filter.filters['opticalphotons'] = dict(
name='ParticleSelectFilter/OpticalPhotonSelector',
parameter={"particle": "opticalphoton"},
)
SIM.filter.mapDetFilter['DRICH'] = 'opticalphotons'
# Use the optical tracker for the DRICH
SIM.action.mapActions['DRICH'] = 'Geant4OpticalTrackerAction'
```https://eicweb.phy.anl.gov/EIC/juggler/-/issues/104Incomplete metadata from `PodioOutput`2022-08-19T14:11:19ZChristopher DilksIncomplete metadata from `PodioOutput`Calling
```
podio::EventStore::get<edm4hep::MCParticleCollection>("MCParticles");
```
using output of an algorithm where `MCParticles` is one of the collections that was just passed from input to output, fails with the claim that the col...Calling
```
podio::EventStore::get<edm4hep::MCParticleCollection>("MCParticles");
```
using output of an algorithm where `MCParticles` is one of the collections that was just passed from input to output, fails with the claim that the collection `MCParticles` is not found. This same algorithm also produces a new collection `DRICHPID`, and the following call is successful:
```
podio::EventStore::get<eicd::CherenkovParticleIDCollection>("DRICHPID");
```
Despite these differences, both collections are in the store, according to `podio::EventStore::getCollectionIDTable()->print();`. The underlying issue is likely incomplete metadata, in particular the `CollectionTypeInfo` branch.https://eicweb.phy.anl.gov/EIC/juggler/-/issues/103Many places have hard-coded `eicd::Vector3f` which should depend on data mode...2022-08-15T20:00:20ZWouter DeconinckMany places have hard-coded `eicd::Vector3f` which should depend on data model typesThe transition from eicd to edm4hep will be helped by remove the large number of hard-coded `eicd::Vector3f` types. Ideally some `auto` but probably realistically will need `using Vector3f = decltype()` constructs.The transition from eicd to edm4hep will be helped by remove the large number of hard-coded `eicd::Vector3f` types. Ideally some `auto` but probably realistically will need `using Vector3f = decltype()` constructs.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/51Job Failed #818723: improve stability of DIS resolution fits2022-09-28T02:46:11ZWouter DeconinckJob Failed #818723: improve stability of DIS resolution fitsJob [#818723](https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/818723) failed for 6553a83213107d0478f03eafc78bb1c12e96286c:Job [#818723](https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/818723) failed for 6553a83213107d0478f03eafc78bb1c12e96286c:Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/ecce/-/issues/19Add an (Open Source) license?2022-10-03T15:19:53ZDmitry KalinkinAdd an (Open Source) license?The project lacks COPYING/LICENSE file.
Similar to https://eicweb.phy.anl.gov/EIC/eicd/-/issues/28, https://eicweb.phy.anl.gov/EIC/NPDet/-/issues/87 and https://eicweb.phy.anl.gov/EIC/detectors/ip6/-/issues/58The project lacks COPYING/LICENSE file.
Similar to https://eicweb.phy.anl.gov/EIC/eicd/-/issues/28, https://eicweb.phy.anl.gov/EIC/NPDet/-/issues/87 and https://eicweb.phy.anl.gov/EIC/detectors/ip6/-/issues/58https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/48Job Failed #749451: HcalEndcapNRawHits requirement of 0.8 hits per event is t...2022-07-05T15:33:18ZWouter DeconinckJob Failed #749451: HcalEndcapNRawHits requirement of 0.8 hits per event is too strictJob [#749451](https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/749451) failed for 0b9af5ba731eacb396d59b7c8d9d74f60ff4f86c:Job [#749451](https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/749451) failed for 0b9af5ba731eacb396d59b7c8d9d74f60ff4f86c:Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/issues/88TrackProjector benchmark2022-06-29T03:32:40ZWouter DeconinckTrackProjector benchmarkEnable the track projector benchmarkEnable the track projector benchmarkWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/102Job Failed #727010: acts@:19.3.0 fails to compile TrackProjector2022-08-09T15:13:54ZWouter DeconinckJob Failed #727010: acts@:19.3.0 fails to compile TrackProjectorJob [#727010](https://eicweb.phy.anl.gov/EIC/juggler/-/jobs/727010) failed for af1ac54e8f170dc3d4074631089a58ebc5e99af8:
Upstream: https://github.com/acts-project/acts/pull/1289Job [#727010](https://eicweb.phy.anl.gov/EIC/juggler/-/jobs/727010) failed for af1ac54e8f170dc3d4074631089a58ebc5e99af8:
Upstream: https://github.com/acts-project/acts/pull/1289Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/101`m_BField->getField(pos,bCache).value()` compile failure in eigen with gcc@122022-06-25T00:10:05ZWouter Deconinck`m_BField->getField(pos,bCache).value()` compile failure in eigen with gcc@12```
291 inlined from 'void Eigen::PlainObjectBase<Derived>::_init1(const Eigen::DenseBase<ElseDerived>&) [with T = Eigen::Transpose<Eigen::CwiseBinaryOp<Eigen::internal::scalar_quotient_op<double, double>, const Eigen::Matrix...```
291 inlined from 'void Eigen::PlainObjectBase<Derived>::_init1(const Eigen::DenseBase<ElseDerived>&) [with T = Eigen::Transpose<Eigen::CwiseBinaryOp<Eigen::internal::scalar_quotient_op<double, double>, const Eigen::Matrix<d
ouble, 3, 1>, const Eigen::CwiseNullaryOp<Eigen::internal::scalar_constant_op<double>, const Eigen::Matrix<double, 3, 1> > > >; OtherDerived = Eigen::Transpose<Eigen::CwiseBinaryOp<Eigen::internal::scalar_quotient_op<double
, double>, const Eigen::Matrix<double, 3, 1>, const Eigen::CwiseNullaryOp<Eigen::internal::scalar_constant_op<double>, const Eigen::Matrix<double, 3, 1> > > >; Derived = Eigen::Matrix<double, 1, 3>]' at /opt/software/linux-
ubuntu22.04-skylake/gcc-12.1.0/eigen-3.4.0-xmmbrla23rhtxamudlr2l7362yihflsn/include/eigen3/Eigen/src/Core/PlainObjectBase.h:883:25,
292 inlined from 'Eigen::Matrix<_Scalar, _Rows, _Cols, _Options, _MaxRows, _MaxCols>::Matrix(const T&) [with T = Eigen::Transpose<Eigen::CwiseBinaryOp<Eigen::internal::scalar_quotient_op<double, double>, const Eigen::Matrix
<double, 3, 1>, const Eigen::CwiseNullaryOp<Eigen::internal::scalar_constant_op<double>, const Eigen::Matrix<double, 3, 1> > > >; _Scalar = double; int _Rows = 1; int _Cols = 3; int _Options = 1; int _MaxRows = 1; int _MaxC
ols = 3]' at /opt/software/linux-ubuntu22.04-skylake/gcc-12.1.0/eigen-3.4.0-xmmbrla23rhtxamudlr2l7362yihflsn/include/eigen3/Eigen/src/Core/Matrix.h:332:31,
293 inlined from 'Eigen::DenseBase<Derived>::EvalReturnType Eigen::DenseBase<Derived>::eval() const [with Derived = Eigen::Transpose<Eigen::CwiseBinaryOp<Eigen::internal::scalar_quotient_op<double, double>, const Eigen::Mat
rix<double, 3, 1>, const Eigen::CwiseNullaryOp<Eigen::internal::scalar_constant_op<double>, const Eigen::Matrix<double, 3, 1> > > >]' at /opt/software/linux-ubuntu22.04-skylake/gcc-12.1.0/eigen-3.4.0-xmmbrla23rhtxamudlr2l73
62yihflsn/include/eigen3/Eigen/src/Core/DenseBase.h:412:62,
294 inlined from 'std::ostream& Eigen::operator<<(std::ostream&, const DenseBase<Derived>&) [with Derived = Transpose<CwiseBinaryOp<internal::scalar_quotient_op<double, double>, const Matrix<double, 3, 1>, const CwiseNullar
yOp<internal::scalar_constant_op<double>, const Matrix<double, 3, 1> > > >]' at /opt/software/linux-ubuntu22.04-skylake/gcc-12.1.0/eigen-3.4.0-xmmbrla23rhtxamudlr2l7362yihflsn/include/eigen3/Eigen/src/Core/IO.h:253:32,
295 inlined from 'MsgStream& operator<<(MsgStream&, const T&) [with T = Eigen::Transpose<Eigen::CwiseBinaryOp<Eigen::internal::scalar_quotient_op<double, double>, const Eigen::Matrix<double, 3, 1>, const Eigen::CwiseNullary
Op<Eigen::internal::scalar_constant_op<double>, const Eigen::Matrix<double, 3, 1> > > >]' at /opt/software/linux-ubuntu22.04-skylake/gcc-12.1.0/gaudi-36.5-scgkwadreca7hlk34q57xs7ccyotugf7/include/GaudiKernel/MsgStream.h:304
:20,
296 inlined from 'virtual StatusCode Jug::Reco::CKFTracking::initialize()' at /home/wdconinc/.spack/stage/spack-stage-juggler-master-szupytavynub76mjf5bggc7fe77kczk5/spack-src/JugTrack/src/components/CKFTracking.cpp:92:64:
>> 297 /usr/lib/gcc/x86_64-linux-gnu/12/include/emmintrin.h:131:24: error: '*(__m128d_u*)((char*)&<unnamed> + offsetof(Eigen::Matrix<double, 3, 1, 0, 3, 1>,Eigen::Matrix<double, 3, 1, 0, 3, 1>::<unnamed>.Eigen::PlainObjectBase<Eig
en::Matrix<double, 3, 1, 0, 3, 1> >::<unnamed>.Eigen::MatrixBase<Eigen::Matrix<double, 3, 1, 0, 3, 1> >::<unnamed>.Eigen::DenseBase<Eigen::Matrix<double, 3, 1, 0, 3, 1> >::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<doub
le, 3, 1, 0, 3, 1>, 3>::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<double, 3, 1, 0, 3, 1>, 1>::<unnamed>.Eigen::DenseCoeffsBase<Eigen::Matrix<double, 3, 1, 0, 3, 1>, 0>::<unnamed>))' may be used uninitialized [-Werror=m
aybe-uninitialized]
298 131 | return *(__m128d_u *)__P;
299 | ^~~
300 /home/wdconinc/.spack/stage/spack-stage-juggler-master-szupytavynub76mjf5bggc7fe77kczk5/spack-src/JugTrack/src/components/CKFTracking.cpp: In member function 'virtual StatusCode Jug::Reco::CKFTracking::initialize()':
301 /home/wdconinc/.spack/stage/spack-stage-juggler-master-szupytavynub76mjf5bggc7fe77kczk5/spack-src/JugTrack/src/components/CKFTracking.cpp:91:68: note: '<anonymous>' declared here
302 91 | auto b = m_BField->getField({0.0,0.0,double(z)},bCache).value()/(Acts::UnitConstants::T);
303 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
```Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/100Build all algorithms to avoid stale code2022-06-25T04:12:34ZWouter DeconinckBuild all algorithms to avoid stale codeCurrently we use explicit lists of files in [gaudi_add_module](https://eicweb.phy.anl.gov/EIC/juggler/-/blob/master/JugTrack/CMakeLists.txt#L9) calls in the CMakeLists.txt. While GLOB is not recommended (since added files do not cause a ...Currently we use explicit lists of files in [gaudi_add_module](https://eicweb.phy.anl.gov/EIC/juggler/-/blob/master/JugTrack/CMakeLists.txt#L9) calls in the CMakeLists.txt. While GLOB is not recommended (since added files do not cause a change to CMakeLists.txt), we could enable this with `CONFIGURE_DEPENDS` or make it a two step procedure.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/ecce/-/issues/18dRICH: increase z-length, and add space for services2022-07-20T09:18:10ZChristopher DilksdRICH: increase z-length, and add space for servicesnew dimensions and z-position from <https://indico.bnl.gov/event/16314/>
![2022-07-19-203317_783x439_scrot](/uploads/8cb4dcd2541e7f072548d3d6aa3717cf/2022-07-19-203317_783x439_scrot.png)new dimensions and z-position from <https://indico.bnl.gov/event/16314/>
![2022-07-19-203317_783x439_scrot](/uploads/8cb4dcd2541e7f072548d3d6aa3717cf/2022-07-19-203317_783x439_scrot.png)Christopher DilksChristopher Dilkshttps://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/issues/64Check ZDC particle gun acceptance2022-07-05T19:45:16ZAlex JentschCheck ZDC particle gun acceptanceAlex JentschAlex Jentsch