EIC issueshttps://eicweb.phy.anl.gov/groups/EIC/-/issues2021-10-21T20:04:19Zhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/125TGeo overlap check now slower than GEANT4 check2021-10-21T20:04:19ZSylvester JoostenTGeo overlap check now slower than GEANT4 checkNeed to figure out what is going on, and if there are no issues trigger the downstream pipelines off the GEANT4 check instead.Need to figure out what is going on, and if there are no issues trigger the downstream pipelines off the GEANT4 check instead.https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/32Job Failed #393700: npsim fails to simulate ions in final state2021-10-22T00:25:51ZWouter DeconinckJob Failed #393700: npsim fails to simulate ions in final stateJob [#393700](https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/393700) failed for 72be9adec74438c4e9f79a1abb422be99a17fa58:Job [#393700](https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/393700) failed for 72be9adec74438c4e9f79a1abb422be99a17fa58:canyonlands-v2Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/64CKFTracking: reduce verbosity on failed tracks found2021-10-13T16:09:37ZWouter DeconinckCKFTracking: reduce verbosity on failed tracks foundFilling up logs at GB-level quantities...Filling up logs at GB-level quantities...Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/117dualize dRICh mirrors2021-11-18T19:42:00ZChristopher Dilksdualize dRICh mirrorsAdd a second spherical mirror for each dRICh sector, to help mitigate aberrations.
For `DeathValley`Add a second spherical mirror for each dRICh sector, to help mitigate aberrations.
For `DeathValley`canyonlands-v2Christopher DilksChristopher Dilkshttps://eicweb.phy.anl.gov/EIC/eicd/-/issues/20VectorXYZT operator+ and operator-2021-10-12T00:15:01ZWouter DeconinckVectorXYZT operator+ and operator-Currently not operators are defined on the four vectors.Currently not operators are defined on the four vectors.https://eicweb.phy.anl.gov/EIC/eicd/-/issues/19VectorXYZT::mag() may be confusing since not four-vector magnitude2022-02-24T02:43:09ZWouter DeconinckVectorXYZT::mag() may be confusing since not four-vector magnitude`mag()` is defined as
```code
double mag() const {return std::hypot(x, y, z);}
```
but the magnitude of a fourvector is traditionally defined as `mass()` (maybe up to a sign)
```code
double mass() const {return sqrt(t*t - x*x - y*y - z*z...`mag()` is defined as
```code
double mag() const {return std::hypot(x, y, z);}
```
but the magnitude of a fourvector is traditionally defined as `mass()` (maybe up to a sign)
```code
double mass() const {return sqrt(t*t - x*x - y*y - z*z);}
```
This might lead to confusion when people start to use this in things like `q2 = (ef-ei).mag()`.https://eicweb.phy.anl.gov/EIC/eicd/-/issues/18Provide constructor for eic::VectorXYZT from dd4pod::VectorXYZ and double2021-10-13T02:28:09ZWouter DeconinckProvide constructor for eic::VectorXYZT from dd4pod::VectorXYZ and doubleCreating an eic::VectorXYZT fourvector from a dd4pod mcparticles entry requires individual x,y,z setters. Ideally, we'd have
```code
for (const auto& p : mcparts) {
if (p.genStatus() == 4 && p.pdgID() == 11) {
// Incomi...Creating an eic::VectorXYZT fourvector from a dd4pod mcparticles entry requires individual x,y,z setters. Ideally, we'd have
```code
for (const auto& p : mcparts) {
if (p.genStatus() == 4 && p.pdgID() == 11) {
// Incoming electron
eic::VectorXYZT ei(p.ps(), p.E());
break;
}
}
```https://eicweb.phy.anl.gov/EIC/eicd/-/issues/17Use consistent namespaces and include directories2021-10-11T19:48:33ZWouter DeconinckUse consistent namespaces and include directoriesRight now we are using a mixture of
- header files in `eicd/`
- namespace `eic::` for data structures in CamelCase
- namespace `eicd::helpers::` for helper functions in lowercase
This causes confusion when
```code
#include "eicd/Reconst...Right now we are using a mixture of
- header files in `eicd/`
- namespace `eic::` for data structures in CamelCase
- namespace `eicd::helpers::` for helper functions in lowercase
This causes confusion when
```code
#include "eicd/ReconstructedParticleCollection.h"
```
provides `eic::ReconstructedParticleCollection`, but
```code
#include "eicd/helpers.h"
```
provides `eicd::helpers::momenta_from_tracking`.
Proposal:
- keep namespaces as `eic::`,
- change install paths to `eic/`,
- remove `eic::helpers::` as an intermediate namespace in favor of e.g. `eic::KinematicsHelpers::`,
- provide headers for helpers in the same structure are the intermediate namespaces, e.g.
```code
#include "eic/KinematicsHelpers.h"
```https://eicweb.phy.anl.gov/EIC/eicd/-/issues/16Provide single header to include for all collection types2021-10-11T19:05:15ZWouter DeconinckProvide single header to include for all collection typesDownstream analysis codes now require
```code
#include "eicd/InclusiveKinematicsCollection.h"
#include "eicd/ReconstructedParticleCollection.h"
```
while it may be easier and more transparent for users to use a single overall header
```c...Downstream analysis codes now require
```code
#include "eicd/InclusiveKinematicsCollection.h"
#include "eicd/ReconstructedParticleCollection.h"
```
while it may be easier and more transparent for users to use a single overall header
```code
#include "eicd.h"
```
or mabye
```code
#include "eicd/DataModel.h"
```https://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/115Add ACTS extensions to PID detectors2021-10-06T18:32:45ZWouter DeconinckAdd ACTS extensions to PID detectors@shujie @sly2j@shujie @sly2jhttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/27Proper digitization for homogenous forward endcap2021-10-22T00:31:07ZSylvester JoostenProper digitization for homogenous forward endcapNeed to apply energy resolution in the digitization stepNeed to apply energy resolution in the digitization stepcanyonlands-v2https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/25Number of Raw Hits per subsystem2021-10-17T23:10:23ZWhitney ArmstrongNumber of Raw Hits per subsystemFor DAQ data volume analysis
- https://dtn01.sdcc.bnl.gov:9000/minio/eictest/ATHENA/FULL/master/DIS/NC/18x275/minQ2=1/
need to add raw hits.
- Need silicon tracker, ECal, HCal.
- MRich/DRich noise (SiPM dark current)
- Far forward tr...For DAQ data volume analysis
- https://dtn01.sdcc.bnl.gov:9000/minio/eictest/ATHENA/FULL/master/DIS/NC/18x275/minQ2=1/
need to add raw hits.
- Need silicon tracker, ECal, HCal.
- MRich/DRich noise (SiPM dark current)
- Far forward tracker region (hitting magnets/flanges)2021-10-11https://eicweb.phy.anl.gov/EIC/juggler/-/issues/56Tower level digitization for positive HCAL2021-10-22T00:30:54ZSylvester JoostenTower level digitization for positive HCAL- [ ] Add tower-level digitization (summing all pads during digitization stage
- [ ] Update options files to use new digitization algorithm- [ ] Add tower-level digitization (summing all pads during digitization stage
- [ ] Update options files to use new digitization algorithmcanyonlands-v2Chao PengChao Penghttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/104Add realistic cooling for Gridpix2021-09-27T12:09:20ZDmitry RomanovAdd realistic cooling for Gridpix![image](/uploads/68875f659ef2067b6e2a7ef77b2dc81b/image.png)
![image](/uploads/087cf4722a47370225fdefe61163100f/image.png)
[4turns_coldplate.SLDPRT](/uploads/7647cd92d21142f7dd31e863ce0c608d/4turns_coldplate.SLDPRT)![image](/uploads/68875f659ef2067b6e2a7ef77b2dc81b/image.png)
![image](/uploads/087cf4722a47370225fdefe61163100f/image.png)
[4turns_coldplate.SLDPRT](/uploads/7647cd92d21142f7dd31e863ce0c608d/4turns_coldplate.SLDPRT)https://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/issues/74Add TOF benchmark2021-09-26T03:02:16ZZhenyu YeAdd TOF benchmarkZhenyu YeZhenyu Yehttps://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/issues/73Backward Ecal tower reconstruction2021-09-24T22:14:13ZWhitney ArmstrongBackward Ecal tower reconstructionhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/51Add both truth and reconstructed path lengths between IP and TOF (or any trac...2021-09-28T21:35:09ZZhenyu YeAdd both truth and reconstructed path lengths between IP and TOF (or any tracker) hitshttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/50drich track projection2021-09-24T16:51:25ZWhitney Armstrongdrich track projectionhttps://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/issues/72Job Failed #331842 - RDataFrame.Range().Display() not working?2021-09-22T23:05:20ZWouter DeconinckJob Failed #331842 - RDataFrame.Range().Display() not working?Job [#331842](https://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/jobs/331842) failed for f7acbfacdb5209055167a4167f3b7eda2bb78b3f:
This is all it's doing:
```cpp
ROOT::RDataFrame df("events", fname);
auto df0 = d...Job [#331842](https://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/jobs/331842) failed for f7acbfacdb5209055167a4167f3b7eda2bb78b3f:
This is all it's doing:
```cpp
ROOT::RDataFrame df("events", fname);
auto df0 = df.Range(10);
auto d1 = df0.Display(
{
"ForwardRomanPotParticles.p.x",
"ForwardRomanPotParticles.p.y",
"ForwardRomanPotParticles.p.z"
}
);
auto d2 = df0.Display(
{
"ForwardOffMTrackerParticles.p.x",
"ForwardOffMTrackerParticles.p.y",
"ForwardOffMTrackerParticles.p.z"
}
);
d1->Print();
d2->Print();
```Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/issues/56Update ZDC detector benchmark2022-06-21T21:37:26ZJihee KimUpdate ZDC detector benchmarkJihee KimJihee Kim