EIC issueshttps://eicweb.phy.anl.gov/groups/EIC/-/issues2022-04-23T21:08:20Zhttps://eicweb.phy.anl.gov/EIC/detectors/ecce/-/issues/4HcalBarrelInner (iHCAL) implementation2022-04-23T21:08:20ZWouter DeconinckHcalBarrelInner (iHCAL) implementationhttps://eicweb.phy.anl.gov/EIC/detectors/ecce/-/issues/3HcalEndcapP (LFHCAL) implementation2022-04-23T21:04:38ZWouter DeconinckHcalEndcapP (LFHCAL) implementationhttps://eicweb.phy.anl.gov/EIC/detectors/ecce/-/issues/2Reparametrize, cleanup, implement inner central detector2022-04-22T22:08:41ZSylvester JoostenReparametrize, cleanup, implement inner central detectorhttps://eicweb.phy.anl.gov/EIC/detectors/compton/-/issues/5Creating a preshower detector2022-04-13T20:35:03ZOmar HassanCreating a preshower detectorWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/compton/-/issues/4Creating a homogeneous calorimeter2022-04-13T20:33:52ZOmar HassanCreating a homogeneous calorimeterWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/compton/-/issues/3Creating a sampling calorimeter2022-04-13T20:33:20ZOmar HassanCreating a sampling calorimeterWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/compton/-/issues/2Create a tube!2022-04-13T20:24:54ZOmar HassanCreate a tube!Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/151CI overlap check tests missed small dRICH sensor overlaps2022-04-12T21:05:58ZChristopher DilksCI overlap check tests missed small dRICH sensor overlapsSome sensors in the dRICH have a very, very small overlap with each other. These overlaps were not identified by the overlap check tests in the CI, as shown in test MR https://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/352Some sensors in the dRICH have a very, very small overlap with each other. These overlaps were not identified by the overlap check tests in the CI, as shown in test MR https://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/352https://eicweb.phy.anl.gov/EIC/juggler/-/issues/88Use gsl::owner<T*> in places where clang-tidy suggests it2022-03-24T22:10:43ZWouter DeconinckUse gsl::owner<T*> in places where clang-tidy suggests itWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/44Job Failed #617560: Intermittent failure in u_omega in dd4hep::sim::HEPMC3Fil...2022-03-24T04:11:58ZWouter DeconinckJob Failed #617560: Intermittent failure in u_omega in dd4hep::sim::HEPMC3FileReader::readGenEvent, resolved on rerunJob [#617560](https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/617560) failed for 4ca6e19ff9499b9c65bce7b43e8a159cf156d262Job [#617560](https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/617560) failed for 4ca6e19ff9499b9c65bce7b43e8a159cf156d262https://eicweb.phy.anl.gov/EIC/juggler/-/issues/87Figure out cleaner solution to #403: non-const in initializer list needs narr...2022-03-21T23:46:01ZWouter DeconinckFigure out cleaner solution to #403: non-const in initializer list needs narrowingProblem: calculations are locally done in double, but need to be cast into float for output, ideally without any effort. We also want users to use nested initializer lists for the components of the output objects. And we don't want lots ...Problem: calculations are locally done in double, but need to be cast into float for output, ideally without any effort. We also want users to use nested initializer lists for the components of the output objects. And we don't want lots of warnings (or, even worse, errors in clang that work in gcc).
Too much `decltype` in https://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/403
Maybe add a utility:
```cpp
namespace eicd {
template <class Vector3, class Float = double>
Vector3 castToFloatVector(const Float v1, const Float v2, const Float v3) {
return {static_cast<float>(v1),
static_cast<float>(v2),
static_cast<float>(v3)};
}
}
```Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/43DEMP Pion FF Benchmark2022-03-21T17:08:42ZStephen JD KayDEMP Pion FF BenchmarkI'm going to try and create a new physics benchmark for my pion form factor studies. These studeis look at Deep Exclusive Meson Production (DEMP) reactions where we have a pion, electron and neutron in the final state. The neutron is ver...I'm going to try and create a new physics benchmark for my pion form factor studies. These studeis look at Deep Exclusive Meson Production (DEMP) reactions where we have a pion, electron and neutron in the final state. The neutron is very forward focused and will be detected in the ZDC. The pion and electron are detected in central detectors.
These events use a custom event generator which can be found here - https://github.com/JeffersonLab/DEMPGen
I've produced files from this generator and processed them through the ATHENA simulation. The next step is to analyse the events and see how well the events of interest can be identified. Goals of the benchmark are as follows -
1. Identify pi/e'/n tripe coincidence events
2. Produce event distributions for events of interest
3. Determine event rates binned in Q2 and -t, from this form factor values can be projected
To begin with, I'll just extract and plot some basic event information (at truth level to begin with) for the processed DEMP events. The end goal is effectively to add a new set of points to the attached plot where we have projections from the ATHENA simulation too.![fpi_ecce_err21](/uploads/d8a0852dccdb2b7d8645ae5f5fc4f097/fpi_ecce_err21.png)
If this works well, the next step would be to try and create a similar benchmark for Kaon FF studies.Stephen JD KayStephen JD Kayhttps://eicweb.phy.anl.gov/EIC/tutorials/eic_tutorial/-/issues/12Revise part5 with new data model (eic:: to eicd:: etc)2022-03-20T15:07:16ZWouter DeconinckRevise part5 with new data model (eic:: to eicd:: etc)Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/issues/62Automatically test any cxx files for compilability2022-03-19T17:10:33ZWouter DeconinckAutomatically test any cxx files for compilabilityEssentially
```bash
for i in benchmarks/* ; do b=$(basename $i) ; for d in scripts analysis ; do if [ -d benchmarks/$b/$d ] ; then compile_analyses.py --dir $d $b ; fi ; done ; done
```
but compile_analysis.py cannot fail when there are...Essentially
```bash
for i in benchmarks/* ; do b=$(basename $i) ; for d in scripts analysis ; do if [ -d benchmarks/$b/$d ] ; then compile_analyses.py --dir $d $b ; fi ; done ; done
```
but compile_analysis.py cannot fail when there are zero cxx files in the specified directory.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/150Use subsystem views for gdml and step exports2022-03-22T18:09:53ZWouter DeconinckUse subsystem views for gdml and step exportsWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/148HCal geometry development2022-03-04T19:23:20ZLeszek KosarzewskiHCal geometry developmenthttps://eicweb.phy.anl.gov/EIC/eicd/-/issues/26Raw (digitized) hit model redundant, use single unified RawHit2022-03-01T17:15:28ZSylvester JoostenRaw (digitized) hit model redundant, use single unified RawHitCurrently all digitized hit structures store the same basic information: 64bit cell ID, 32bit time stamp and 32bit value. There is no good reason for them to be separate classes. We should unify them into a single RawHit structure as thi...Currently all digitized hit structures store the same basic information: 64bit cell ID, 32bit time stamp and 32bit value. There is no good reason for them to be separate classes. We should unify them into a single RawHit structure as this will provide us with more flexibility down the road. And when needed we can add data structures that actually store different information as we go. Proposed structure:
```
RawHit:
Description: Raw detector hit storing one 32-bit word of information
Members:
- uint64_t cellID
- uint32_t timeStamp
- uint32_t value
```https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/41Merge all options/reconstruction.*py and use multiple PodioOutput writers wit...2022-02-23T22:57:06ZWouter DeconinckMerge all options/reconstruction.*py and use multiple PodioOutput writers with branch filtersThat will result in more consistent treatments.That will result in more consistent treatments.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/85Re-enable inclusive kinematics calculations2022-02-22T05:57:44ZWouter DeconinckRe-enable inclusive kinematics calculationshttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/386https://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/386Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/issues/61Job Failed #586572: sim_track_hits.cxx needs all tracker hit collections incl...2022-02-22T05:00:14ZWouter DeconinckJob Failed #586572: sim_track_hits.cxx needs all tracker hit collections included againJob [#586572](https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/586572) failed for 844289cd3ca4309ee397c60b034761cdd713a071:
In the transition to EDM4hep the hit collections were demultiplexed and the sim_track_hits.c...Job [#586572](https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/586572) failed for 844289cd3ca4309ee397c60b034761cdd713a071:
In the transition to EDM4hep the hit collections were demultiplexed and the sim_track_hits.cxx was modified to only look at 1 of those multiple collections. We need to change that back so all hits are included.Wouter DeconinckWouter Deconinck