EIC issueshttps://eicweb.phy.anl.gov/groups/EIC/-/issues2023-10-02T00:16:02Zhttps://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/issues/66Move repo to GitHub2023-10-02T00:16:02ZDmitry KalinkinMove repo to GitHubContributing to repos on eicweb is not a good experience. If we are to invite the collaboration to do this, this needs to be improved.Contributing to repos on eicweb is not a good experience. If we are to invite the collaboration to do this, this needs to be improved.https://eicweb.phy.anl.gov/EIC/juggler/-/issues/110clang-tidy unhappy again2022-10-12T18:35:54ZSylvester Joostenclang-tidy unhappy againJob [#1014803](https://eicweb.phy.anl.gov/EIC/juggler/-/jobs/1014803) failed for abb2e4abccbf18b082b9db78d0117cdd056ab368:Job [#1014803](https://eicweb.phy.anl.gov/EIC/juggler/-/jobs/1014803) failed for abb2e4abccbf18b082b9db78d0117cdd056ab368:https://eicweb.phy.anl.gov/EIC/NPDet/-/issues/90Support FastSim and GFlash2022-10-10T21:14:58ZWouter DeconinckSupport FastSim and GFlashE.g. https://github.com/MarkusFrankATcernch/DD4hep/blob/master/examples/ClientTests/scripts/SiliconBlockFastSim.py and related.E.g. https://github.com/MarkusFrankATcernch/DD4hep/blob/master/examples/ClientTests/scripts/SiliconBlockFastSim.py and related.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/issues/65Job Failed #954527 - detector benchmarks - histogram range needs to be adjusted2022-10-04T00:47:52ZMaria ZurekJob Failed #954527 - detector benchmarks - histogram range needs to be adjustedJob [#954527](https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/954527) failed for b4e06a2997dbffcf4ba57de59135211865fdc663:
The histogram range needs to be dynamically adjusted with the changing sapling fraction.Job [#954527](https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/954527) failed for b4e06a2997dbffcf4ba57de59135211865fdc663:
The histogram range needs to be dynamically adjusted with the changing sapling fraction.Maria ZurekMaria Zurekhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/109feat: add automatic Property and Service Readiness evaluation to algorithms2022-09-29T22:05:18ZSylvester Joostenfeat: add automatic Property and Service Readiness evaluation to algorithmshttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/52eicweb/physics_benchmarks (epic_imaging) failing2022-10-03T16:15:35ZDmitry Kalinkineicweb/physics_benchmarks (epic_imaging) failingFor current EPIC main branch:
https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/937964For current EPIC main branch:
https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/937964https://eicweb.phy.anl.gov/EIC/juggler/-/issues/108Feat: add obligatory description field to Algorithm and Property2022-09-29T20:47:10ZSylvester JoostenFeat: add obligatory description field to Algorithm and Propertyhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/107Feature: Override-able thread-safe (but not reproducible) RandomSvc for algor...2022-09-29T19:56:35ZSylvester JoostenFeature: Override-able thread-safe (but not reproducible) RandomSvc for algorithms.https://eicweb.phy.anl.gov/EIC/juggler/-/issues/106Migrate SYCL-enabled island clustering to algorithms2022-09-26T21:00:48ZWouter DeconinckMigrate SYCL-enabled island clustering to algorithmsWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/105Better algorithms Property integration2022-09-27T15:58:25ZSylvester JoostenBetter algorithms Property integrationCurrently `Property` passing between the framework and `algorithms` is based around `std::any`. This is not optimal as the type erasure makes automizing framework class generation almost impossible. I propose to use `std::variant` instea...Currently `Property` passing between the framework and `algorithms` is based around `std::any`. This is not optimal as the type erasure makes automizing framework class generation almost impossible. I propose to use `std::variant` instead. There are of course drawbacks (more limited), but those aren't IMO that important:
- people shouldn't be passing tons of data into a Property anyway
- the current `std::any` interface is a little fragile against people specifying the wrong type in one of the places (fragile as in runtime errors). It's probably better to have explicit compiler errors in case there are inconsistencieshttps://eicweb.phy.anl.gov/EIC/NPDet/-/issues/89Handle PFRICH in `npsim.py`2022-10-03T21:42:13ZChristopher DilksHandle PFRICH in `npsim.py`In `npsim.py`, we have settings unique for the DRICH, but these also need to be applied for the PFRICH. Relevant snippet:
```python
# Some detectors are only sensitive to optical photons
SIM.filter.filters['opticalphotons'] = dict(
...In `npsim.py`, we have settings unique for the DRICH, but these also need to be applied for the PFRICH. Relevant snippet:
```python
# Some detectors are only sensitive to optical photons
SIM.filter.filters['opticalphotons'] = dict(
name='ParticleSelectFilter/OpticalPhotonSelector',
parameter={"particle": "opticalphoton"},
)
SIM.filter.mapDetFilter['DRICH'] = 'opticalphotons'
# Use the optical tracker for the DRICH
SIM.action.mapActions['DRICH'] = 'Geant4OpticalTrackerAction'
```https://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/153Material map for EPIC2023-07-09T03:46:31ZShujie LiMaterial map for EPICFirst version of material map for the tracking volume of EPIC detector in LBL design. No AC-LGAD yet.
Material surfaces from Geantino scan: ![geant_mat_map](/uploads/67928357584ab8e9b92b37801f76735a/geant_mat_map.png)
Geantino vs. materi...First version of material map for the tracking volume of EPIC detector in LBL design. No AC-LGAD yet.
Material surfaces from Geantino scan: ![geant_mat_map](/uploads/67928357584ab8e9b92b37801f76735a/geant_mat_map.png)
Geantino vs. material map comparison:
![Ratio_Val_geant_mat_X0_](/uploads/37888d68f72c70d089928c82060d2e20/Ratio_Val_geant_mat_X0_.png)
The outer supporting cylinder is projected to the last disk which is not ideal. Need to improve later.
PR on github/epic: https://github.com/eic/epic/pull/96
Material map file: [material-maps.cbor](/uploads/56b64d544442a93904488e7292aa509d/material-maps.cbor)Shujie LiShujie Lihttps://eicweb.phy.anl.gov/EIC/NPDet/-/issues/88Implement reading from gzipped hepmc input2022-08-30T00:28:24ZWouter DeconinckImplement reading from gzipped hepmc inputhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/104Incomplete metadata from `PodioOutput`2022-08-19T14:11:19ZChristopher DilksIncomplete metadata from `PodioOutput`Calling
```
podio::EventStore::get<edm4hep::MCParticleCollection>("MCParticles");
```
using output of an algorithm where `MCParticles` is one of the collections that was just passed from input to output, fails with the claim that the col...Calling
```
podio::EventStore::get<edm4hep::MCParticleCollection>("MCParticles");
```
using output of an algorithm where `MCParticles` is one of the collections that was just passed from input to output, fails with the claim that the collection `MCParticles` is not found. This same algorithm also produces a new collection `DRICHPID`, and the following call is successful:
```
podio::EventStore::get<eicd::CherenkovParticleIDCollection>("DRICHPID");
```
Despite these differences, both collections are in the store, according to `podio::EventStore::getCollectionIDTable()->print();`. The underlying issue is likely incomplete metadata, in particular the `CollectionTypeInfo` branch.https://eicweb.phy.anl.gov/EIC/juggler/-/issues/103Many places have hard-coded `eicd::Vector3f` which should depend on data mode...2022-08-15T20:00:20ZWouter DeconinckMany places have hard-coded `eicd::Vector3f` which should depend on data model typesThe transition from eicd to edm4hep will be helped by remove the large number of hard-coded `eicd::Vector3f` types. Ideally some `auto` but probably realistically will need `using Vector3f = decltype()` constructs.The transition from eicd to edm4hep will be helped by remove the large number of hard-coded `eicd::Vector3f` types. Ideally some `auto` but probably realistically will need `using Vector3f = decltype()` constructs.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/51Job Failed #818723: improve stability of DIS resolution fits2022-09-28T02:46:11ZWouter DeconinckJob Failed #818723: improve stability of DIS resolution fitsJob [#818723](https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/818723) failed for 6553a83213107d0478f03eafc78bb1c12e96286c:Job [#818723](https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/818723) failed for 6553a83213107d0478f03eafc78bb1c12e96286c:Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/50Re-enable failures on failed JB x and Q2 resolution fits2022-10-03T16:15:36ZWouter DeconinckRe-enable failures on failed JB x and Q2 resolution fitsWhile cluster/track matching was not working, JB was not picking up nearly enough hadronic final state (assumption) and giving wildly incorrect x and Q2 values. Once we have cluster/track matching working again, and once JB is operating ...While cluster/track matching was not working, JB was not picking up nearly enough hadronic final state (assumption) and giving wildly incorrect x and Q2 values. Once we have cluster/track matching working again, and once JB is operating stably again, we should re-enable pipeline failures on fit failures.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/ecce/-/issues/19Add an (Open Source) license?2022-10-03T15:19:53ZDmitry KalinkinAdd an (Open Source) license?The project lacks COPYING/LICENSE file.
Similar to https://eicweb.phy.anl.gov/EIC/eicd/-/issues/28, https://eicweb.phy.anl.gov/EIC/NPDet/-/issues/87 and https://eicweb.phy.anl.gov/EIC/detectors/ip6/-/issues/58The project lacks COPYING/LICENSE file.
Similar to https://eicweb.phy.anl.gov/EIC/eicd/-/issues/28, https://eicweb.phy.anl.gov/EIC/NPDet/-/issues/87 and https://eicweb.phy.anl.gov/EIC/detectors/ip6/-/issues/58https://eicweb.phy.anl.gov/EIC/detectors/ip6/-/issues/58Add an (Open Source) license?2022-07-18T17:30:44ZDmitry KalinkinAdd an (Open Source) license?The project lacks COPYING/LICENSE file.
Similar to https://eicweb.phy.anl.gov/EIC/eicd/-/issues/28 and https://eicweb.phy.anl.gov/EIC/NPDet/-/issues/87The project lacks COPYING/LICENSE file.
Similar to https://eicweb.phy.anl.gov/EIC/eicd/-/issues/28 and https://eicweb.phy.anl.gov/EIC/NPDet/-/issues/87https://eicweb.phy.anl.gov/EIC/NPDet/-/issues/87Add an (Open Source) license?2022-07-18T17:30:49ZDmitry KalinkinAdd an (Open Source) license?The project lacks COPYING/LICENSE file.
Similar to https://eicweb.phy.anl.gov/EIC/eicd/-/issues/28The project lacks COPYING/LICENSE file.
Similar to https://eicweb.phy.anl.gov/EIC/eicd/-/issues/28