EIC issueshttps://eicweb.phy.anl.gov/groups/EIC/-/issues2022-04-11T01:08:45Zhttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/38Remove get_calibrations script and use dd4hep file loader2022-04-11T01:08:45ZWouter DeconinckRemove get_calibrations script and use dd4hep file loaderWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/76acts-152022-02-08T01:52:54ZWouter Deconinckacts-15Relevant commit with breaking changes to SourceLinks: https://github.com/acts-project/acts/commit/8b6bc7a6c2620c51f7b4a8e3918c3eaef1399ed3
Container MR: https://eicweb.phy.anl.gov/containers/eic_container/-/merge_requests/230Relevant commit with breaking changes to SourceLinks: https://github.com/acts-project/acts/commit/8b6bc7a6c2620c51f7b4a8e3918c3eaef1399ed3
Container MR: https://eicweb.phy.anl.gov/containers/eic_container/-/merge_requests/230Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/136cherry pick RICH bug fixes from IRT integration2022-02-10T21:03:42ZChristopher Dilkscherry pick RICH bug fixes from IRT integrationBefore freezing `DeathValley`, we should make sure all bug fixes from other RICH branches (viz. `irt-init-v01`) are pulled into `master`; for example, https://eicweb.phy.anl.gov/EIC/detectors/athena/-/commit/bca4580bd06fb691b7e8d0c486f18...Before freezing `DeathValley`, we should make sure all bug fixes from other RICH branches (viz. `irt-init-v01`) are pulled into `master`; for example, https://eicweb.phy.anl.gov/EIC/detectors/athena/-/commit/bca4580bd06fb691b7e8d0c486f1873b3ace6d68Christopher DilksChristopher Dilkshttps://eicweb.phy.anl.gov/EIC/detectors/ip6/-/issues/50Update ZDC HCAL geometry2022-02-01T19:46:32ZAlex JentschUpdate ZDC HCAL geometry- 2 interaction length to 7 interaction length (number of layers from 35 to 120)
- Scintillator plate thickness from 2.0 mm to 2.5 mm
- Maybe readout section make it more cleaner
- Rename hit collection- 2 interaction length to 7 interaction length (number of layers from 35 to 120)
- Scintillator plate thickness from 2.0 mm to 2.5 mm
- Maybe readout section make it more cleaner
- Rename hit collectionAlex JentschAlex Jentschhttps://eicweb.phy.anl.gov/EIC/irt/-/issues/5Friendly coding suggestions:2022-08-04T17:09:25ZWhitney ArmstrongFriendly coding suggestions:Here are some comments I have to make while briefly going through the code.
1. ROOT's TObject is not really needed anymore.
2. Avoid using ROOT specific-stuff unless it is really needed. Example from my experience, `TRef` is usually mo...Here are some comments I have to make while briefly going through the code.
1. ROOT's TObject is not really needed anymore.
2. Avoid using ROOT specific-stuff unless it is really needed. Example from my experience, `TRef` is usually more of a headache than helpful.
3. From my other issue about using `#include` quotes : https://stackoverflow.com/a/3162067/13377601
4. Avoid unnecessary inheritance. Example: `TObject -> TransientParticle -> {ChargedParticle, OpticalPhoton}`. I do not see any polymorphism in the interface so there is no need for inheritance at all here.
5. The code is hard to read with all the pre-processor defines and logic.
6. The `IRT::Solve` member function should (ideally) be `const`.https://eicweb.phy.anl.gov/EIC/irt/-/issues/4Install public headers in own include sub-directory2022-08-04T17:10:40ZWhitney ArmstrongInstall public headers in own include sub-directory1. For the sake of keeping `include` clean, it is a good idea to put headers in their own directory.
For example, this would mean using
```
#include "IRT/CherenkovMirror.h"
```
for client code.
2. FWIW, it is best to use quotes over br...1. For the sake of keeping `include` clean, it is a good idea to put headers in their own directory.
For example, this would mean using
```
#include "IRT/CherenkovMirror.h"
```
for client code.
2. FWIW, it is best to use quotes over brackets for includes. https://stackoverflow.com/a/3162067/13377601https://eicweb.phy.anl.gov/EIC/juggler/-/issues/74Calorimeter noise fix2021-11-15T19:03:09ZAaron AngeramiCalorimeter noise fixThe implementation of the calorimeter noise in the digitization is incorrect. Namely the code here:
https://eicweb.phy.anl.gov/EIC/juggler/-/blob/master/JugDigi/src/components/CalorimeterHitDigi.cpp#L168
```
double eResRel = std::sqrt...The implementation of the calorimeter noise in the digitization is incorrect. Namely the code here:
https://eicweb.phy.anl.gov/EIC/juggler/-/blob/master/JugDigi/src/components/CalorimeterHitDigi.cpp#L168
```
double eResRel = std::sqrt(std::pow(m_normDist() * eRes[0] / std::sqrt(ahit.energyDeposit()), 2) +
std::pow(m_normDist() * eRes[1], 2) +
std::pow(m_normDist() * eRes[2] / (ahit.energyDeposit()), 2));
```
Should be either
```
double eResRel =m_normDist() * std::sqrt(std::pow(eRes[0] / std::sqrt(ahit.energyDeposit()), 2) +
std::pow(eRes[1], 2) +
std::pow(eRes[2] / (ahit.energyDeposit()), 2));
```
or
```
double eResRel = m_normDist() * (eRes[0] / std::sqrt(ahit.energyDeposit()) +
m_normDist() * eRes[1] +
m_normDist() * eRes[2] / (ahit.energyDeposit());
``
That is, the three contributions to the noise are typically assumed to arise from independent Gaussian fluctuations. So they should either contribute separately (second form) or can be combined by adding in quadrature (first form).Chao PengChao Penghttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/135Add new material WSciFi2021-11-15T05:01:26ZJihee KimAdd new material WSciFifor EMCAL partfor EMCAL partJihee KimJihee Kimhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/133FileLoader should try harder2021-11-05T15:57:05ZWouter DeconinckFileLoader should try harder```
Loading calibrations/materials-map.cbor from https://eicweb.phy.anl.gov/EIC/detectors/athena/uploads/cff8f8d5919d8e78561e8caf2b4fad2b/material-maps.cbor
--2021-11-04 07:49:27-- https://eicweb.phy.anl.gov/EIC/detectors/athena/uploads...```
Loading calibrations/materials-map.cbor from https://eicweb.phy.anl.gov/EIC/detectors/athena/uploads/cff8f8d5919d8e78561e8caf2b4fad2b/material-maps.cbor
--2021-11-04 07:49:27-- https://eicweb.phy.anl.gov/EIC/detectors/athena/uploads/cff8f8d5919d8e78561e8caf2b4fad2b/material-maps.cbor
Resolving eicweb.phy.anl.gov (eicweb.phy.anl.gov)... failed: Temporary failure in name resolution.
wget: unable to resolve host address ‘eicweb.phy.anl.gov’
```Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/72Some issue with OMD fast smearing acceptance2021-11-04T20:48:10ZAlex JentschSome issue with OMD fast smearing acceptancehttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/132Minor RICH updates to support IRT integration2021-11-14T21:52:52ZChristopher DilksMinor RICH updates to support IRT integrationUpdates to support usage of `GeoSvc` from Juggler in the IRT wrapper algorithm. The linked MR will not be dependent on the `IRT` repository.Updates to support usage of `GeoSvc` from Juggler in the IRT wrapper algorithm. The linked MR will not be dependent on the `IRT` repository.Christopher DilksChristopher Dilkshttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/71Change OMD/RP base calculation to warning and event skip2021-10-30T16:00:19ZAlex JentschChange OMD/RP base calculation to warning and event skipAlex JentschAlex Jentschhttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/36Add Far Forward raw hit determination2021-10-29T20:44:57ZWouter DeconinckAdd Far Forward raw hit determinationFrom https://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/blob/master/benchmarks/far_forward/options/far_forward_reconstruction.py into the options here.From https://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/blob/master/benchmarks/far_forward/options/far_forward_reconstruction.py into the options here.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/35CBOR parse error, `[json.exception.parse_error.110] parse error at byte 1`2021-11-05T04:17:37ZWouter DeconinckCBOR parse error, `[json.exception.parse_error.110] parse error at byte 1`Gotta keep an eye out for these. Occurring on OSG nodes. Sporadic, but may turn systemic.
```
====================================================================================================================================
...Gotta keep an eye out for these. Occurring on OSG nodes. Sporadic, but may turn systemic.
```
====================================================================================================================================
Welcome to ApplicationMgr (GaudiCoreSvc v36r0)
running on osg-pilots-highlim-b4b7c6b8b-cp7xb on Thu Oct 28 23:40:55 2021
====================================================================================================================================
Warning in <TGeoManager>: Changing system of units to ROOT units (cm, s, GeV).
GeoSvc INFO loading geometry from file: '/opt/detector/athena-canyonlands-v1.2/share/athena/athena.xml'
DD4hep WARN ++ STD conditions NOT defined by client. NTP defaults taken.
Loading calibrations/materials-map.cbor from https://eicweb.phy.anl.gov/EIC/detectors/athena/uploads/cff8f8d5919d8e78561e8caf2b4fad2b/material-maps.cbor
GeoSvc INFO DD4Hep geometry SUCCESSFULLY built
GeoSvc INFO loading materials map from file: ' 'materials':'calibrations/materials-map.cbor''
GeoSvc FATAL in sysInitialize(): standard std::exception is caught
GeoSvc ERROR [json.exception.parse_error.110] parse error at byte 1: syntax error while parsing CBOR value: unexpected end of input
```Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/131update TOF for DeathValley2021-11-30T00:42:41ZZhenyu Yeupdate TOF for DeathValleyZhenyu YeZhenyu Yehttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/70Still working on FF issues with crossing angle2021-10-28T03:32:59ZAlex JentschStill working on FF issues with crossing angleAlex JentschAlex Jentschhttps://eicweb.phy.anl.gov/EIC/detectors/ip6/-/issues/49ZDC Display2021-11-19T18:07:51ZJihee KimZDC DisplayLinked MR: EIC/detectors/ip6!87
@ajentsch
EMCal - each tower module
![geometry__14_](/uploads/85920d09b1d7404b67fa47c7581ae591/geometry__14_.png)
W power with scintillating fibers
![geometry__10_](/uploads/081a7678a1ea6da6f5ca52bac80f...Linked MR: EIC/detectors/ip6!87
@ajentsch
EMCal - each tower module
![geometry__14_](/uploads/85920d09b1d7404b67fa47c7581ae591/geometry__14_.png)
W power with scintillating fibers
![geometry__10_](/uploads/081a7678a1ea6da6f5ca52bac80fa07d/geometry__10_.png)
After I added fibers in, display doesn't work.
But after throwing some events into emcal of ZDC, there are some hits and hit positions.
![Screen_Shot_2021-10-27_at_17.50.52](/uploads/2ff72c9de15da02c5b79d28e89011939/Screen_Shot_2021-10-27_at_17.50.52.png)
![Screen_Shot_2021-10-27_at_17.58.37](/uploads/bb21e4ea3fc485d487e704e60670c0d2/Screen_Shot_2021-10-27_at_17.58.37.png)Jihee KimJihee Kimhttps://eicweb.phy.anl.gov/EIC/detectors/ip6/-/issues/48Create new layout images for slides2021-10-28T18:17:46ZAlex JentschCreate new layout images for slidesSylvester JoostenSylvester Joostenhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/69Remove crossing angle from FF fast smear2021-10-27T21:08:47ZAlex JentschRemove crossing angle from FF fast smearhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/129change eRICH to pfRICH2022-02-11T03:34:45ZChristopher Dilkschange eRICH to pfRICHThe name "eRICH" is historical, and should be updated to "pfRICH"The name "eRICH" is historical, and should be updated to "pfRICH"Christopher DilksChristopher Dilks