EIC issueshttps://eicweb.phy.anl.gov/groups/EIC/-/issues2022-03-04T19:23:20Zhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/148HCal geometry development2022-03-04T19:23:20ZLeszek KosarzewskiHCal geometry developmenthttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/42Job Failed #597011: fast_ff association failure2022-03-01T21:39:07ZWouter DeconinckJob Failed #597011: fast_ff association failureJob [#597011](https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/597011) failed for 8595e1ccbfee59b6df7c85120cb4359e50d7536b:Job [#597011](https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/jobs/597011) failed for 8595e1ccbfee59b6df7c85120cb4359e50d7536b:Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/issues/26Raw (digitized) hit model redundant, use single unified RawHit2022-03-01T17:15:28ZSylvester JoostenRaw (digitized) hit model redundant, use single unified RawHitCurrently all digitized hit structures store the same basic information: 64bit cell ID, 32bit time stamp and 32bit value. There is no good reason for them to be separate classes. We should unify them into a single RawHit structure as thi...Currently all digitized hit structures store the same basic information: 64bit cell ID, 32bit time stamp and 32bit value. There is no good reason for them to be separate classes. We should unify them into a single RawHit structure as this will provide us with more flexibility down the road. And when needed we can add data structures that actually store different information as we go. Proposed structure:
```
RawHit:
Description: Raw detector hit storing one 32-bit word of information
Members:
- uint64_t cellID
- uint32_t timeStamp
- uint32_t value
```https://eicweb.phy.anl.gov/EIC/juggler/-/issues/86Raw (digitized) hit model redundant, use single unified RawHit2022-02-28T23:28:50ZSylvester JoostenRaw (digitized) hit model redundant, use single unified RawHitCurrently all digitized hit structures store the same basic information: 64bit cell ID, 32bit time stamp and 32bit value. There is no good reason for them to be separate classes. We should unify them into a single RawHit structure as thi...Currently all digitized hit structures store the same basic information: 64bit cell ID, 32bit time stamp and 32bit value. There is no good reason for them to be separate classes. We should unify them into a single RawHit structure as this will provide us with more flexibility down the road. And when needed we can add data structures that actually store different information as we go. Proposed structure:
```
RawHit:
Description: Raw detector hit storing one 32-bit word of information
Members:
- uint64_t cellID
- uint32_t timeStamp
- uint32_t value
```https://eicweb.phy.anl.gov/EIC/detectors/ip6/-/issues/53Update ZDC Material and Cracks2022-02-25T21:52:09ZJihee KimUpdate ZDC Material and CracksUpdate standard scintillator material and cracksUpdate standard scintillator material and cracksJihee KimJihee Kimhttps://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/issues/41Merge all options/reconstruction.*py and use multiple PodioOutput writers wit...2022-02-23T22:57:06ZWouter DeconinckMerge all options/reconstruction.*py and use multiple PodioOutput writers with branch filtersThat will result in more consistent treatments.That will result in more consistent treatments.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/issues/25C++17 compatibility for vector_utils.h2022-02-22T22:55:32ZSylvester JoostenC++17 compatibility for vector_utils.hvector_utils.h right now requires C++20 (concepts). This clashes with ROOT versions compiled with C++17 only. We can resolve this by having a fall-back implementation (vector_utils_legacy.h) that is loaded when Concepts are not available...vector_utils.h right now requires C++20 (concepts). This clashes with ROOT versions compiled with C++17 only. We can resolve this by having a fall-back implementation (vector_utils_legacy.h) that is loaded when Concepts are not available that is as close as possible to the version with concepts in functionality.Sylvester JoostenSylvester Joostenhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/85Re-enable inclusive kinematics calculations2022-02-22T05:57:44ZWouter DeconinckRe-enable inclusive kinematics calculationshttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/386https://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/386Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/issues/61Job Failed #586572: sim_track_hits.cxx needs all tracker hit collections incl...2022-02-22T05:00:14ZWouter DeconinckJob Failed #586572: sim_track_hits.cxx needs all tracker hit collections included againJob [#586572](https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/586572) failed for 844289cd3ca4309ee397c60b034761cdd713a071:
In the transition to EDM4hep the hit collections were demultiplexed and the sim_track_hits.c...Job [#586572](https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/586572) failed for 844289cd3ca4309ee397c60b034761cdd713a071:
In the transition to EDM4hep the hit collections were demultiplexed and the sim_track_hits.cxx was modified to only look at 1 of those multiple collections. We need to change that back so all hits are included.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/issues/24Move closer to EDM4hep (part 2)2022-03-01T18:49:42ZSylvester JoostenMove closer to EDM4hep (part 2)- [x] Remove remaining overlapping datatypes in favor of includes from EDM4hep
- [x] Migrate away from using eic::Index in favor of explicit relations
- [x] Use get/set syntax consistent with EDM4hep- [x] Remove remaining overlapping datatypes in favor of includes from EDM4hep
- [x] Migrate away from using eic::Index in favor of explicit relations
- [x] Use get/set syntax consistent with EDM4hephttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/147Fix DIRC overlaps and make it great again2022-02-21T03:00:49ZDmitry RomanovFix DIRC overlaps and make it great againFix DIRC overlap and fix other problems preventing it from use as a main DIRC implementationFix DIRC overlap and fix other problems preventing it from use as a main DIRC implementationDmitry RomanovDmitry Romanovhttps://eicweb.phy.anl.gov/EIC/benchmarks/reconstruction_benchmarks/-/issues/83Switch to edm4hep removed g4Parent selection in benchmarks/imaging_ecal/scrip...2022-02-19T04:54:47ZWouter DeconinckSwitch to edm4hep removed g4Parent selection in benchmarks/imaging_ecal/scripts/draw_cluster.pyWhile this may run correctly with the edm4hep model, the functionality needs to be checked again.While this may run correctly with the edm4hep model, the functionality needs to be checked again.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/84edm4hep::Vector3f etc: introduce theta, phi, eta, mag functions2022-02-18T02:10:15ZWouter Deconinckedm4hep::Vector3f etc: introduce theta, phi, eta, mag functionsFile upstream bug, change in all the places where we now calculate this ourselves.File upstream bug, change in all the places where we now calculate this ourselves.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/83ParticleSvc: Return charge a float to prevent issues with narrowing2022-02-18T02:01:40ZWouter DeconinckParticleSvc: Return charge a float to prevent issues with narrowingint (uint64_t) requires narrowing when represented in float. Not an actual problem for a charge that is +/- an integer few (where it can always be represented exactly), but even a 32bit float can represent all these charges correctly in ...int (uint64_t) requires narrowing when represented in float. Not an actual problem for a charge that is +/- an integer few (where it can always be represented exactly), but even a 32bit float can represent all these charges correctly in the same bit space and would not generate warnings.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/82Document auto/float/double strategy and apply consistently2022-02-18T01:45:25ZWouter DeconinckDocument auto/float/double strategy and apply consistentlyE.g. input data has mixture of float and double, algorithm should (typically) upgrade this to double, explicit static_cast<float> for output data that is float, but not for output data saved as double.E.g. input data has mixture of float and double, algorithm should (typically) upgrade this to double, explicit static_cast<float> for output data that is float, but not for output data saved as double.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/81MC2SmearedParticle: E^2 = p^2 + m^2 should be valid after smearing2022-02-18T01:34:47ZWouter DeconinckMC2SmearedParticle: E^2 = p^2 + m^2 should be valid after smearingWe just smear momentum, but don't modify energy.We just smear momentum, but don't modify energy.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/80Test the Juggler Birks constant treatment2022-02-18T01:22:34ZWouter DeconinckTest the Juggler Birks constant treatmenthttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/382#note_17718https://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/382#note_17718Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/146DRICHHits (usually) empty after the change of `sens.setType("photoncounter")`...2022-06-12T06:15:38ZChristopher DilksDRICHHits (usually) empty after the change of `sens.setType("photoncounter")` to `tracker`After https://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/330 was merged, the `DRICHHits` branch is usually empty (or there are only a few sporadic entries). If I try reverting the type back to `photoncounter`, we see the ex...After https://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/330 was merged, the `DRICHHits` branch is usually empty (or there are only a few sporadic entries). If I try reverting the type back to `photoncounter`, we see the expected distribution.
Using MR https://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/332 for testing: see artifact `test.png` from job `test_drich`
Steps to reproduce (executed from top-level `athena` directory):
```
npsim --runType run --compactFile compact/subsystem_views/drich_only.xml --macro test.mac --outputFile test.root --enableG4GPS
```
where `test.mac` is
```
/control/verbose 2
/run/initialize
/gps/verbose 2
/gps/particle pi+
/gps/number 1
/gps/ene/mono 20 GeV
/gps/position 0 0 0 cm
/gps/direction 0.25 0.0 1.0
/run/beamOn 50
```
Opening `test.root` and running `events->Draw("DRICHHits.position.x")` should produce a distribution that looks like the attached image, but is coming out empty (or sometimes a few sporadic hits)
It is likely the pfRICH is also affected.
![photoncounter](/uploads/b0d3bad0892f26ccb60ffe8e94b8dd27/photoncounter.png)https://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/145Document how to edep filter by detector type to avoid killing optical photons...2022-02-16T22:38:33ZWouter DeconinckDocument how to edep filter by detector type to avoid killing optical photons on photomultipliersWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/detectors/ip6/-/issues/52Job Failed #573335 overlap_check fails due to missing juggler.env2022-02-13T18:53:21ZWouter DeconinckJob Failed #573335 overlap_check fails due to missing juggler.envJob [#573335](https://eicweb.phy.anl.gov/EIC/detectors/ip6/-/jobs/573335) failed for aa072ca71b60c0beddbf8feba0f926b34bac1d30:Job [#573335](https://eicweb.phy.anl.gov/EIC/detectors/ip6/-/jobs/573335) failed for aa072ca71b60c0beddbf8feba0f926b34bac1d30:Wouter DeconinckWouter Deconinck