From f80491826b9129ac2a8a5af7d08941d936eb12d0 Mon Sep 17 00:00:00 2001
From: Massimiliano Culpo <massimiliano.culpo@gmail.com>
Date: Mon, 16 Dec 2019 10:56:54 +0100
Subject: [PATCH] Travis exits at the first failing test, pin codecov at v4.5.4
 (#14179)

Before this commit we used to run the entire unit test suite
in the presence of a failure. Since we currently rely a lot
on the state of the filesystem etc. the end report was most
of the time showing spurious failures that were a consequence
of the first failing test.

This PR makes unit tests exit at the first failing test

Also, pin codecov at v4.5.4 (last one supporting Python 2.6)
---
 .travis.yml                   | 2 +-
 share/spack/qa/run-unit-tests | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 55d1f13c54..f276c3ba34 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -167,7 +167,7 @@ install:
   - pip install --upgrade pip
   - pip install --upgrade six
   - pip install --upgrade setuptools
-  - pip install --upgrade codecov
+  - pip install --upgrade codecov coverage==4.5.4
   - pip install --upgrade flake8
   - pip install --upgrade pep8-naming
   - if [[ "$TEST_SUITE" == "doc" ]]; then
diff --git a/share/spack/qa/run-unit-tests b/share/spack/qa/run-unit-tests
index 4403d53a76..11f3ac1fcb 100755
--- a/share/spack/qa/run-unit-tests
+++ b/share/spack/qa/run-unit-tests
@@ -46,7 +46,7 @@ extra_args=""
 if [[ -n "$@" ]]; then
     extra_args="-k $@"
 fi
-${coverage_run} bin/spack test --verbose "$extra_args"
+${coverage_run} bin/spack test -x --verbose "$extra_args"
 
 #-----------------------------------------------------------
 # Run tests for setup-env.sh
-- 
GitLab