From 9b926a480f84c62cf4ed23c26b950dd7c89fb1ad Mon Sep 17 00:00:00 2001
From: alalazo <massimiliano.culpo@googlemail.com>
Date: Wed, 6 Jul 2016 17:03:32 +0200
Subject: [PATCH] qa : flake8 issues
---
bin/spack | 2 +-
lib/spack/spack/test/versions.py | 2 +-
lib/spack/spack/version.py | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/bin/spack b/bin/spack
index 9b1276a866..e9307d1485 100755
--- a/bin/spack
+++ b/bin/spack
@@ -77,7 +77,7 @@ import llnl.util.tty as tty
from llnl.util.tty.color import *
import spack
from spack.error import SpackError
-from external import argparse
+import argparse
# Command parsing
parser = argparse.ArgumentParser(
diff --git a/lib/spack/spack/test/versions.py b/lib/spack/spack/test/versions.py
index c051895ca3..a3a328fb14 100644
--- a/lib/spack/spack/test/versions.py
+++ b/lib/spack/spack/test/versions.py
@@ -424,4 +424,4 @@ def test_get_item(self):
self.assertEqual(repr(b), 'Version(\'1_2-3\')')
self.assertEqual(str(b), '1_2-3')
# Raise TypeError on tuples
- self.assertRaises(TypeError, b.__getitem__, 1, 2)
\ No newline at end of file
+ self.assertRaises(TypeError, b.__getitem__, 1, 2)
diff --git a/lib/spack/spack/version.py b/lib/spack/spack/version.py
index 7e5878383d..6839643941 100644
--- a/lib/spack/spack/version.py
+++ b/lib/spack/spack/version.py
@@ -202,9 +202,9 @@ def __getitem__(self, idx):
# Currently len(self.separators) == len(self.version) - 1
extendend_separators = self.separators + ('',)
string_arg = []
- for token, separator in zip(self.version, extendend_separators)[idx]:
+ for token, sep in zip(self.version, extendend_separators)[idx]:
string_arg.append(str(token))
- string_arg.append(str(separator))
+ string_arg.append(str(sep))
string_arg.pop() # We don't need the last separator
string_arg = ''.join(string_arg)
return cls(string_arg)
--
GitLab