From 9b6b91b0b90e8c1af2b903ccfb5492bae506a184 Mon Sep 17 00:00:00 2001
From: Milton Woods <miltonjwoods@gmail.com>
Date: Wed, 19 Apr 2017 21:55:22 +1000
Subject: [PATCH] ncl: capture more dependencies (#3902)
* ncl: add depends_on statements for bison, flex and libiconv
* ncl: depends on flex for building and linking
* ncl: links with -ll, so requires flex with variant '+lex'
* ncl: depends on szip; external hdf5 may not provide it
---
var/spack/repos/builtin/packages/ncl/package.py | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/var/spack/repos/builtin/packages/ncl/package.py b/var/spack/repos/builtin/packages/ncl/package.py
index 78c5bf1ce2..051eaab471 100644
--- a/var/spack/repos/builtin/packages/ncl/package.py
+++ b/var/spack/repos/builtin/packages/ncl/package.py
@@ -58,6 +58,11 @@ class Ncl(Package):
depends_on('netcdf')
depends_on('cairo')
+ # Extra dependencies that may be missing from build system:
+ depends_on('bison', type='build')
+ depends_on('flex+lex')
+ depends_on('libiconv')
+
# Also, the manual says that ncl requires zlib, but that comes as a
# mandatory dependency of libpng, which is a mandatory dependency of cairo.
@@ -75,6 +80,7 @@ class Ncl(Package):
# szip support. We introduce this restriction with the following dependency
# statement.
depends_on('hdf5+szip')
+ depends_on('szip')
# In Spack, we also do not have an option to compile netcdf without DAP
# support, so we will tell the ncl configuration script that we have it.
--
GitLab