Project Juggler merge requestshttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests2024-02-09T20:03:43Zhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/537feat: use the algorithms::-interfaced EICrecon algorithms2024-02-09T20:03:43ZWouter Deconinckfeat: use the algorithms::-interfaced EICrecon algorithmsWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/502Feat context service overhaul2023-11-04T09:44:11ZSylvester JoostenFeat context service overhaul`algorithms` context-aware service overhaul (with more intuitive resource handling).`algorithms` context-aware service overhaul (with more intuitive resource handling).https://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/497feat: CalorimeterHitReco conversion to algorithms2022-12-03T22:09:10ZWouter Deconinckfeat: CalorimeterHitReco conversion to algorithmsWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/484SiliconTrackerDigi: include in algorithms and use in juggler2022-09-30T05:23:56ZWouter DeconinckSiliconTrackerDigi: include in algorithms and use in jugglerWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/479CalorimeterHitDigi conversion (3)2022-12-02T23:36:30ZWouter DeconinckCalorimeterHitDigi conversion (3)Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/474Draft: CalorimeterHitDigi conversion (2)2022-09-27T17:16:19ZWouter DeconinckDraft: CalorimeterHitDigi conversion (2)Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/470Draft: CalorimeterHitDigi conversion2022-09-25T21:12:49ZWouter DeconinckDraft: CalorimeterHitDigi conversionStill hung up on
```
In file included from /home/wdconinc/EIC/juggler/external/algorithms/calorimetry/src/CalorimeterHitDigi.cpp:13:
/home/wdconinc/EIC/juggler/external/algorithms/calorimetry/include/algorithms/calorimetry/CalorimeterHit...Still hung up on
```
In file included from /home/wdconinc/EIC/juggler/external/algorithms/calorimetry/src/CalorimeterHitDigi.cpp:13:
/home/wdconinc/EIC/juggler/external/algorithms/calorimetry/include/algorithms/calorimetry/CalorimeterHitDigi.h: In constructor ‘algorithms::calorimetry::CalorimeterHitDigi::CalorimeterHitDigi(std::string_view)’:
/home/wdconinc/EIC/juggler/external/algorithms/calorimetry/include/algorithms/calorimetry/CalorimeterHitDigi.h:47:66: error: no matching function for call to ‘algorithms::Algorithm<algorithms::Input<edm4hep::SimCalorimeterHitCollection>, algorithms::Output<edm4eic::RawCalorimeterHitCollection> >::Algorithm(<brace-enclosed initializer list>)’
47 | {"outputHitCollection", "outputHits"}} {};
| ^
In file included from /home/wdconinc/EIC/juggler/external/algorithms/calorimetry/include/algorithms/calorimetry/CalorimeterHitDigi.h:13:
/home/wdconinc/EIC/juggler/external/algorithms/core/include/algorithms/algorithm.h:42:3: note: candidate: ‘algorithms::Algorithm<InputType, OutputType>::Algorithm(std::string_view, const InputNames&, const OutputNames&) [with InputType = algorithms::Input<edm4hep::SimCalorimeterHitCollection>; OutputType = algorithms::Output<edm4eic::RawCalorimeterHitCollection>; std::string_view = std::basic_string_view<char>; InputNames = std::array<const std::__cxx11::basic_string<char>, 1>; OutputNames = std::array<const std::__cxx11::basic_string<char>, 1>]’
42 | Algorithm(std::string_view name, const InputNames& input_names, const OutputNames& output_names)
| ^~~~~~~~~
/home/wdconinc/EIC/juggler/external/algorithms/core/include/algorithms/algorithm.h:42:54: note: no known conversion for argument 2 from ‘<brace-enclosed initializer list>’ to ‘const algorithms::Algorithm<algorithms::Input<edm4hep::SimCalorimeterHitCollection>, algorithms::Output<edm4eic::RawCalorimeterHitCollection> >::InputNames&’ {aka ‘const std::array<const std::__cxx11::basic_string<char>, 1>&’}
42 | Algorithm(std::string_view name, const InputNames& input_names, const OutputNames& output_names)
| ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
/home/wdconinc/EIC/juggler/external/algorithms/calorimetry/include/algorithms/calorimetry/CalorimeterHitDigi.h: At global scope:
/home/wdconinc/EIC/juggler/external/algorithms/calorimetry/include/algorithms/calorimetry/CalorimeterHitDigi.h:93:1: error: expected constructor, destructor, or type conversion before ‘}’ token
93 | } // namespace algoriths::calorimetry
| ^
```Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/463Draft: New algorithms project2022-09-03T00:44:34ZWouter DeconinckDraft: New algorithms projecthttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/461fix: only run `jug_xl:master` trigger when juggler not itself a trigger2023-03-09T21:07:42ZWouter Deconinckfix: only run `jug_xl:master` trigger when juggler not itself a triggerWe are seeing eicd MRs trigger juggler master pipelines which then trigger eic_container jug_xl:master rebuilds into production. That should not be possible and is avoided by not triggering eic_container jug_xl:master rebuilds if juggler...We are seeing eicd MRs trigger juggler master pipelines which then trigger eic_container jug_xl:master rebuilds into production. That should not be possible and is avoided by not triggering eic_container jug_xl:master rebuilds if juggler itself was triggered. Only actual commits to juggler master should trigger a rebuild of jug_xl:master.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/454initial script to save trajectory info in to the Trajectory branch2022-08-19T05:09:23ZShujie Liinitial script to save trajectory info in to the Trajectory branchGet trajectory state info via Acts MultiTrajectoryHelpers for tracking quality check. Chi2 and number of measurements are available now.Get trajectory state info via Acts MultiTrajectoryHelpers for tracking quality check. Chi2 and number of measurements are available now.Shujie LiShujie Lihttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/452feat: Use the generic algorithms library2022-08-17T02:06:28ZWouter Deconinckfeat: Use the generic algorithms libraryThis branch introduces the `algorithms` library (not currently in the test environment containers).This branch introduces the `algorithms` library (not currently in the test environment containers).Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/446feat: add firstSmallerThanZ support2022-08-08T18:29:57ZWouter Deconinckfeat: add firstSmallerThanZ supportWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/441feat: migration to edm4hep::Vector classes for merged data model2022-08-03T18:40:25ZWouter Deconinckfeat: migration to edm4hep::Vector classes for merged data modelWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/429First integration of HEP-FCC/FWCore PileUp tools2022-08-03T20:09:52ZWouter DeconinckFirst integration of HEP-FCC/FWCore PileUp toolsThis should already do the pileup on the signals only (all algorithms without 'merge' in the name), but it still fails the compilation for the merge tools and algorithms.
Todo:
- [ ] address differences in the data model from fcc and ed...This should already do the pileup on the signals only (all algorithms without 'merge' in the name), but it still fails the compilation for the merge tools and algorithms.
Todo:
- [ ] address differences in the data model from fcc and edm4hep (just renamed, but some structures are different too)Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/427Draft: Resolve "TrackProjector: generalize by passing target surface as option"2022-06-25T03:43:55ZWouter DeconinckDraft: Resolve "TrackProjector: generalize by passing target surface as option"Closes #99
- [ ] create reconstruction benchmarkCloses #99
- [ ] create reconstruction benchmarkWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/422Draft: Resolve "Implement SimTrackerHitsMerger to overlay/merge background ev...2022-06-18T03:33:22ZWouter DeconinckDraft: Resolve "Implement SimTrackerHitsMerger to overlay/merge background events"Closes #96Closes #96Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/419Draft: Resolve "JugFast::MatchClusters needs updating for EDM4hep migration"2022-07-22T17:28:44ZSylvester JoostenDraft: Resolve "JugFast::MatchClusters needs updating for EDM4hep migration"Closes #95Closes #95https://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/406Draft: Resolve "Use gsl::owner<T*> in places where clang-tidy suggests it"2022-03-24T22:14:00ZWouter DeconinckDraft: Resolve "Use gsl::owner<T*> in places where clang-tidy suggests it"Closes #88
- [ ] Do we need JugBase/Utilities/Helpers? Unused, untested code.Closes #88
- [ ] Do we need JugBase/Utilities/Helpers? Unused, untested code.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/400Created ImagingPixelDataShaper.cpp2022-04-01T19:18:11ZRobinpreet DhillonCreated ImagingPixelDataShaper.cppRobinpreet DhillonRobinpreet Dhillonhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/377Draft: Resolve "add RICH IRT algorithm"2023-03-10T17:12:58ZChristopher DilksDraft: Resolve "add RICH IRT algorithm"Closes #73Closes #73Christopher DilksChristopher Dilks