Project Juggler merge requestshttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests2022-02-16T22:39:08Zhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/376Remove PhotoMultiplierHit for TrackerHit2022-02-16T22:39:08ZWouter DeconinckRemove PhotoMultiplierHit for TrackerHitAssociated with https://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/330, in order to remove the PMT data type not present in edm4hep.Associated with https://eicweb.phy.anl.gov/EIC/detectors/athena/-/merge_requests/330, in order to remove the PMT data type not present in edm4hep.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/363Remove JugBase dictionary2022-02-18T00:52:38ZWouter DeconinckRemove JugBase dictionaryThe JugBase dictionary (through includes) is giving compilation troubles in recent gcc (boost/preprocessor not found...). Not sure we need a dictionary to begin with. The only connection in the commit history is with ProtoTracks.The JugBase dictionary (through includes) is giving compilation troubles in recent gcc (boost/preprocessor not found...). Not sure we need a dictionary to begin with. The only connection in the commit history is with ProtoTracks.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/382Support pure edm4hep output from ddsim2022-02-18T03:24:56ZWouter DeconinckSupport pure edm4hep output from ddsimThis would get 'rid' of the dd4pod format in favor of the edm4hep format.This would get 'rid' of the dd4pod format in favor of the edm4hep format.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/368Resolve "Update RP/OMD coordinates to local"2022-02-18T19:09:41ZAlex JentschResolve "Update RP/OMD coordinates to local"Closes #78Closes #78Alex JentschAlex Jentschhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/379Eicd update2022-02-21T23:31:30ZSylvester JoostenEicd updatehttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/384Eicd update 22022-02-22T01:03:41ZSylvester JoostenEicd update 2https://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/385JugDigi::SimTrackerHitsCollector to deal with demuxed readouts2022-02-22T03:36:59ZWouter DeconinckJugDigi::SimTrackerHitsCollector to deal with demuxed readoutsIntended for syntax like this:
```python
tracker_endcap_collections = [
'TrackerEndcapHits1',
'TrackerEndcapHits2',
'TrackerEndcapHits3',
'TrackerEndcapHits4',
'TrackerEndcapHits5',
'TrackerEndcapHits6'
]
trk_ec_...Intended for syntax like this:
```python
tracker_endcap_collections = [
'TrackerEndcapHits1',
'TrackerEndcapHits2',
'TrackerEndcapHits3',
'TrackerEndcapHits4',
'TrackerEndcapHits5',
'TrackerEndcapHits6'
]
trk_ec_coll = SimTrackerHitsCollector("trk_ec_coll",
inputSimTrackerHits = tracker_endcap_collections,
outputSimTrackerHits = "TrackerEndcapHits")
```Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/386Temporarily disable the inclusive kinematics so we can get stuff working2022-02-22T05:58:20ZWouter DeconinckTemporarily disable the inclusive kinematics so we can get stuff workingWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/387Set weights to 1 in proto clusters2022-02-22T22:29:22ZWouter DeconinckSet weights to 1 in proto clustersWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/388SimpleClustering.cpp, TruthClustering.cpp: add weights to proto clusters2022-02-23T03:15:16ZWouter DeconinckSimpleClustering.cpp, TruthClustering.cpp: add weights to proto clustersWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/391Eicd update2022-02-28T23:18:33ZSylvester JoostenEicd updateUpdate Juggler in step with the evolution of the EICD modelUpdate Juggler in step with the evolution of the EICD modelhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/392Updated Juggler for get/set syntax in eicd2022-03-01T18:50:27ZSylvester JoostenUpdated Juggler for get/set syntax in eicdhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/393Restore timeResolution in SiliconTrackerDigi2022-03-03T21:22:48ZWouter DeconinckRestore timeResolution in SiliconTrackerDigiWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/401Fix bug where sector and layer ID were swapped for imaging calorimeter hits.2022-03-18T18:49:54ZSylvester JoostenFix bug where sector and layer ID were swapped for imaging calorimeter hits.https://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/402Mutable datatypes in podio@0.14.1 and later2022-03-20T01:51:05ZWouter DeconinckMutable datatypes in podio@0.14.1 and laterWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/404clang-tidy: fix source_location issues2022-03-21T20:45:07ZWouter Deconinckclang-tidy: fix source_location issues- add `-extra-arg='-std=c++17'` to the clang-tidy call
- NOLINT on the offending DECLARE_COMPONENTS- add `-extra-arg='-std=c++17'` to the clang-tidy call
- NOLINT on the offending DECLARE_COMPONENTSWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/403Avoid illegal narrowing of non-const temporaries in initializer lists2022-03-21T23:45:49ZWouter DeconinckAvoid illegal narrowing of non-const temporaries in initializer lists@sly2j I think this actually fixes our clang-tidy job again :-)@sly2j I think this actually fixes our clang-tidy job again :-)Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/405Clang-tidy fixes2022-03-24T16:31:53ZWouter DeconinckClang-tidy fixesWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/389Reenable InclusiveKinematics algorithms2022-03-26T03:44:20ZWouter DeconinckReenable InclusiveKinematics algorithmsWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/407Implement InclusiveKinematicsTruth with updated functionality in Beam.h2022-03-27T22:19:25ZWouter DeconinckImplement InclusiveKinematicsTruth with updated functionality in Beam.hWouter DeconinckWouter Deconinck