Project Juggler issueshttps://eicweb.phy.anl.gov/EIC/juggler/-/issues2021-09-23T15:30:10Zhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/7Algorithm for cluster-track matching2021-09-23T15:30:10ZWhitney ArmstrongAlgorithm for cluster-track matchinghttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/17TOF pion/kaon/proton PID2020-11-29T20:37:12ZWhitney ArmstrongTOF pion/kaon/proton PIDAdd a simple algorithm for TOF PID. Later integrate algorithm into track fitting or multi track/kinematic fitting.Add a simple algorithm for TOF PID. Later integrate algorithm into track fitting or multi track/kinematic fitting.Whitney ArmstrongWhitney Armstronghttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/18Clean up found track output2021-01-05T17:47:24ZWhitney ArmstrongClean up found track outputNeed to clean up the output from `TrackFindingAlgorithm` and `ParticlesFromTrackFit`.
These two need not be directly connected but the TrackFindingAlgorithm certainly needs it's output wrangled into the datamodel.
`ParticlesFromTrackFit`...Need to clean up the output from `TrackFindingAlgorithm` and `ParticlesFromTrackFit`.
These two need not be directly connected but the TrackFindingAlgorithm certainly needs it's output wrangled into the datamodel.
`ParticlesFromTrackFit` will feed into PID algorithms so perhaps it should be `InitTrajectoriesFromTrackFit` or something like that.Whitney ArmstrongWhitney Armstrong2020-12-23https://eicweb.phy.anl.gov/EIC/juggler/-/issues/33genfit based tracking2021-09-20T19:50:47ZWhitney Armstronggenfit based trackingWhitney ArmstrongWhitney Armstronghttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/43Add number of bins property to ConformalXYPeak finding algo2021-08-24T16:54:30ZWhitney ArmstrongAdd number of bins property to ConformalXYPeak finding algoThis allows tuning of how many tracks are resolved.
https://eicweb.phy.anl.gov/EIC/juggler/-/blob/master/JugTrack/src/components/ConformalXYPeakProtoTracks.cpp#L28This allows tuning of how many tracks are resolved.
https://eicweb.phy.anl.gov/EIC/juggler/-/blob/master/JugTrack/src/components/ConformalXYPeakProtoTracks.cpp#L28https://eicweb.phy.anl.gov/EIC/juggler/-/issues/50drich track projection2021-09-24T16:51:25ZWhitney Armstrongdrich track projectionhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/51Add both truth and reconstructed path lengths between IP and TOF (or any trac...2021-09-28T21:35:09ZZhenyu YeAdd both truth and reconstructed path lengths between IP and TOF (or any tracker) hitshttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/56Tower level digitization for positive HCAL2021-10-22T00:30:54ZSylvester JoostenTower level digitization for positive HCAL- [ ] Add tower-level digitization (summing all pads during digitization stage
- [ ] Update options files to use new digitization algorithm- [ ] Add tower-level digitization (summing all pads during digitization stage
- [ ] Update options files to use new digitization algorithmcanyonlands-v2Chao PengChao Penghttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/64CKFTracking: reduce verbosity on failed tracks found2021-10-13T16:09:37ZWouter DeconinckCKFTracking: reduce verbosity on failed tracks foundFilling up logs at GB-level quantities...Filling up logs at GB-level quantities...Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/67Issues related to DVCS photon and proton reco2021-10-22T19:08:48ZZhoudunming TuIssues related to DVCS photon and proton recoDVCS ep events (with crossing angle after-burner applied) has been passed thru full ATHENA simulations.
Two observations:
1. DVCS real photon reconstruction is missing eta>0, comparing to MC distribution.
2. DVCS scattered proton, REC ...DVCS ep events (with crossing angle after-burner applied) has been passed thru full ATHENA simulations.
Two observations:
1. DVCS real photon reconstruction is missing eta>0, comparing to MC distribution.
2. DVCS scattered proton, REC eta distribution shifts to high eta comparing to MC distribution
[photon.pdf](/uploads/c4070f027f853b456c298ec2441ac4d1/photon.pdf)
[photon_eta.pdf](/uploads/f2dbe9123b59aa511495da788609fe1b/photon_eta.pdf)
[proton_eta.pdf](/uploads/4b9e7694573396ae09f024c157fa37a2/proton_eta.pdf)
Instruction to reproduce these plots, see the following gitlab link:
https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/tree/diffractive-phi-benchmarks/benchmarks/dvcs-d
run
`dvcs-d.sh`
will run the full chain of reco and analysis.https://eicweb.phy.anl.gov/EIC/juggler/-/issues/68Issue with nucleus PDG code2021-10-22T19:14:00ZZhoudunming TuIssue with nucleus PDG codeThe current sim step does not take 10-digit nucleus PDG code, SEE screenshot,
https://files.slack.com/files-pri/T01RLU7AFNY-F02HMJCGGRK/screen_shot_2021-10-13_at_7.58.12_pm.png
This will be an issue for every eA event generator.
The ve...The current sim step does not take 10-digit nucleus PDG code, SEE screenshot,
https://files.slack.com/files-pri/T01RLU7AFNY-F02HMJCGGRK/screen_shot_2021-10-13_at_7.58.12_pm.png
This will be an issue for every eA event generator.
The version of the code can be found here,
https://eicweb.phy.anl.gov/EIC/benchmarks/physics_benchmarks/-/tree/diffractive-phi-benchmarks/benchmarks/diffractive_phi
also,
the test file is
S3/eictest/ATHENA/EVGEN/TEST/Output_input_temp_189.hepmc
or any eA hepmc files.https://eicweb.phy.anl.gov/EIC/juggler/-/issues/73add RICH IRT algorithm2022-08-12T22:39:21ZChristopher Dilksadd RICH IRT algorithmChristopher DilksChristopher Dilkshttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/75Hit merging implementation2021-11-17T15:43:48ZAaron AngeramiHit merging implementationIf I understand correctly, the current implementation converts individual G4 hits to summed ADC values in the digitization (including noise), the cell hits are reconstructed and assigned energies and then merged in the reconstruction. I ...If I understand correctly, the current implementation converts individual G4 hits to summed ADC values in the digitization (including noise), the cell hits are reconstructed and assigned energies and then merged in the reconstruction. I think the order of merging/digitization should be reversed, so that energies of different G4 hits in the same cell are summed _before_ digitization. In going from the G4 deposited energy (which already has fluctuations in the energy loss and sampling) to cell energies, the primary source of noise is electronic noise which contributes per cell not per hit.
In the current implementation if you had N hits all within the same cell, the current digitization/hit reconstruction/hit merging sequence would give each hit its own independent contribution to the electronic noise, thus the merged hit would have noise that goes like sqrt(N)sigma instead of just sigma.
The solution would be to disable the CalorimeterHitsMerger algorithm and replace it with an analogous one in the digitation that runs upstream of CalorimeterHitDigi that takes the hit collection and produces a new, merged one.Chao PengChao Penghttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/77Source linker storage performance2022-01-15T22:29:50ZWouter DeconinckSource linker storage performanceAs pointed out by Paul Gessinger, https://github.com/acts-project/acts/issues/1106#issuecomment-989624406:
> One thing I noticed when looking at the MR over on your Gitlab is that you copied the pattern from our fitting algorithm, where ...As pointed out by Paul Gessinger, https://github.com/acts-project/acts/issues/1106#issuecomment-989624406:
> One thing I noticed when looking at the MR over on your Gitlab is that you copied the pattern from our fitting algorithm, where I introduced an std::list to have stable pointers for the source links I create. This is not necessarily a good idea for a setup meant for any kind of production: std::list is relatively slow. I didn't add anything more clever to that algorithm there because it wasn't needed, but I would suggest you try to work around using this pattern, for example by creating the source links in one pass and only afterwards creating the measurements (when source link pointers are stable)
This needs some thinking.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/79Testing CI for Alexander2022-01-28T23:06:31ZDmitry RomanovTesting CI for AlexanderDmitry RomanovDmitry Romanovhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/80Test the Juggler Birks constant treatment2022-02-18T01:22:34ZWouter DeconinckTest the Juggler Birks constant treatmenthttps://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/382#note_17718https://eicweb.phy.anl.gov/EIC/juggler/-/merge_requests/382#note_17718Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/81MC2SmearedParticle: E^2 = p^2 + m^2 should be valid after smearing2022-02-18T01:34:47ZWouter DeconinckMC2SmearedParticle: E^2 = p^2 + m^2 should be valid after smearingWe just smear momentum, but don't modify energy.We just smear momentum, but don't modify energy.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/82Document auto/float/double strategy and apply consistently2022-02-18T01:45:25ZWouter DeconinckDocument auto/float/double strategy and apply consistentlyE.g. input data has mixture of float and double, algorithm should (typically) upgrade this to double, explicit static_cast<float> for output data that is float, but not for output data saved as double.E.g. input data has mixture of float and double, algorithm should (typically) upgrade this to double, explicit static_cast<float> for output data that is float, but not for output data saved as double.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/83ParticleSvc: Return charge a float to prevent issues with narrowing2022-02-18T02:01:40ZWouter DeconinckParticleSvc: Return charge a float to prevent issues with narrowingint (uint64_t) requires narrowing when represented in float. Not an actual problem for a charge that is +/- an integer few (where it can always be represented exactly), but even a 32bit float can represent all these charges correctly in ...int (uint64_t) requires narrowing when represented in float. Not an actual problem for a charge that is +/- an integer few (where it can always be represented exactly), but even a 32bit float can represent all these charges correctly in the same bit space and would not generate warnings.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/juggler/-/issues/84edm4hep::Vector3f etc: introduce theta, phi, eta, mag functions2022-02-18T02:10:15ZWouter Deconinckedm4hep::Vector3f etc: introduce theta, phi, eta, mag functionsFile upstream bug, change in all the places where we now calculate this ourselves.File upstream bug, change in all the places where we now calculate this ourselves.Wouter DeconinckWouter Deconinck