Commit 315959d0 authored by Wouter Deconinck's avatar Wouter Deconinck
Browse files

More clang-tidy fixes

parent 04b4bbe6
......@@ -43,7 +43,7 @@ StatusCode PodioDataSvc::reinitialize() {
}
StatusCode PodioDataSvc::finalize() {
m_cnvSvc = 0; // release
m_cnvSvc = nullptr; // release
DataSvc::finalize().ignore();
return StatusCode::SUCCESS;
}
......
......@@ -86,7 +86,7 @@ GeoSvc::~GeoSvc() {
if (m_dd4hepGeo != nullptr) {
try {
m_dd4hepGeo->destroyInstance();
m_dd4hepGeo = 0;
m_dd4hepGeo = nullptr;
} catch (...) {
}
}
......@@ -229,7 +229,7 @@ StatusCode GeoSvc::buildDD4HepGeo() {
m_dd4hepGeo->fromCompact(filename);
}
m_dd4hepGeo->volumeManager();
m_dd4hepGeo->apply("DD4hepVolumeManager", 0, 0);
m_dd4hepGeo->apply("DD4hepVolumeManager", 0, nullptr);
m_cellid_converter = std::make_shared<const dd4hep::rec::CellIDPositionConverter>(*m_dd4hepGeo);
return StatusCode::SUCCESS;
}
......
......@@ -222,9 +222,11 @@ namespace Jug::Digi {
edep += hits[i].getEnergy();
if (hits[i].getEnergy() > max_edep) {
max_edep = hits[i].getEnergy();
for (const auto& c : hits[i].getContributions())
if (c.getTime() <= time)
for (const auto& c : hits[i].getContributions()) {
if (c.getTime() <= time) {
time = c.getTime();
}
}
}
}
......
......@@ -336,7 +336,7 @@ private:
void split_group(std::vector<std::pair<uint32_t, CaloHit>>& group, const std::vector<CaloHit>& maxima,
eicd::ProtoClusterCollection& proto) const {
// special cases
if (maxima.size() == 0) {
if (maxima.empty()) {
if (msgLevel(MSG::VERBOSE)) {
verbose() << "No maxima found, not building any clusters" << endmsg;
}
......@@ -402,7 +402,6 @@ private:
if (msgLevel(MSG::VERBOSE)) {
verbose() << "Multiple (" << maxima.size() << ") maxima found, added a ProtoClusters for each maximum" << endmsg;
}
return;
}
};
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment