Christopher Dilks (281db5ce) at 04 Aug 17:16
Update README.md
include
clean, it is a good idea to put headers in their own directory.
For example, this would mean using#include "IRT/CherenkovMirror.h"
for client code.
opened at https://github.com/eic/irt/issues/5
Here are some comments I have to make while briefly going through the code.
TRef
is usually more of a headache than helpful.#include
quotes : https://stackoverflow.com/a/3162067/13377601
TObject -> TransientParticle -> {ChargedParticle, OpticalPhoton}
. I do not see any polymorphism in the interface so there is no need for inheritance at all here.IRT::Solve
member function should (ideally) be const
.opened at https://github.com/eic/irt/issues/4
close #7
opened at https://github.com/eic/irt/pull/2
Since the data model has changed, we need to refactor some of the evaluation
code. Things to do include:
eic::Index
, since we now use PODIO relations insteadedm4hep::MCParticle
to replace dd4pod::Geant4Particle
?ReconstructedParticle
to the MC generated particle? we no longer have mcID
, do we need to add a relation in eicd
?opened at https://github.com/eic/irt/pull/2
What shall we replace with eic::Index
? In the evaluation
code we are mapping the Index
to eic::CherenkovParticleIDData
, after the mapping with eic::Index ID
we are the calling eic::Index recID
; both ID
and recID
are members of eic::CherenkovParticleIDData
. Do we have to create such members? Or we make a totally new association based on the new data-model?
Since the data model has changed, we need to refactor some of the evaluation
code. Things to do include:
eic::Index
, since we now use PODIO relations insteadedm4hep::MCParticle
to replace dd4pod::Geant4Particle
?ReconstructedParticle
to the MC generated particle? we no longer have mcID
, do we need to add a relation in eicd
?Christopher Dilks (d240d762) at 18 Jun 13:18
Christopher Dilks (dd6fc6d7) at 18 Jun 13:18
Merge branch 'irt-init-v02' into 'main'
... and 37 more commits
A lot of development happened on irt-init-v01
for the initial integration with other modules. This MR proposes merging irt-init-v02
, which is irt-init-v01
+ a renaming of the eRICH to pfRICH.
Christopher Dilks (d240d762) at 18 Jun 13:14
temporarily disable EVALUATION build; we need to refactor evaluatio...
close #7
Christopher Dilks (f38c9738) at 17 Feb 18:46