eicd merge requestshttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests2022-08-23T23:09:21Zhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/95feat: trigger eicweb/juggler after changes to eicd2022-08-23T23:09:21ZWouter Deconinckfeat: trigger eicweb/juggler after changes to eicdWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/94fix: run Github workflow for docs inside alpine (LCG podio too old)2022-08-23T23:42:57ZWouter Deconinckfix: run Github workflow for docs inside alpine (LCG podio too old)This runs the doxygen workflow inside an alpine container based on the build products from eic-shell.This runs the doxygen workflow inside an alpine container based on the build products from eic-shell.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/93feat: make doxygen in github2022-08-23T19:26:01ZWouter Deconinckfeat: make doxygen in githubWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/92fix: template instantiation for `vector_x<edm4hep::Vector2f>`2022-08-15T18:51:16ZWouter Deconinckfix: template instantiation for `vector_x<edm4hep::Vector2f>`This allows for magnitude on Vector2f.This allows for magnitude on Vector2f.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/91feat: use edm4hep as upstream to eicd2022-08-16T05:29:59ZWouter Deconinckfeat: use edm4hep as upstream to eicdThis does not change the data model, but just introduces the CMakeLists support.This does not change the data model, but just introduces the CMakeLists support.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/90feat: add recID for convenience and compatibility2022-08-05T18:05:08ZWouter Deconinckfeat: add recID for convenience and compatibilityThere are usability concerns with the assocation branches in ROOT trees. For now we can also store recID similar to simID. This will allow us to do that with juggler algorithms.There are usability concerns with the assocation branches in ROOT trees. For now we can also store recID similar to simID. This will allow us to do that with juggler algorithms.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/89feat: updated cmake with user-facing podio macros (NEEDS podio > 0.14.3)2022-08-23T14:43:33ZWouter Deconinckfeat: updated cmake with user-facing podio macros (NEEDS podio > 0.14.3)Current podio data model building patterns use:
```cmake
PODIO_GENERATE_DATAMODEL()
PODIO_ADD_DATAMODEL_CORE_LIB()
PODIO_ADD_ROOT_IO_DICT()
```
instead of doing a lot of manipulation by the user code.Current podio data model building patterns use:
```cmake
PODIO_GENERATE_DATAMODEL()
PODIO_ADD_DATAMODEL_CORE_LIB()
PODIO_ADD_ROOT_IO_DICT()
```
instead of doing a lot of manipulation by the user code.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/88fix: pass correct variable to juggler2022-07-29T22:22:56ZWouter Deconinckfix: pass correct variable to jugglerIt seems we've been passing the incorrect variable to the juggler repository, so pipelines trigger by a pull request from a branch of eicd have been run against a master branch of eicd in the juggler repository pipeline. This should addr...It seems we've been passing the incorrect variable to the juggler repository, so pipelines trigger by a pull request from a branch of eicd have been run against a master branch of eicd in the juggler repository pipeline. This should address this.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/87feat*: remove deprecated BasicParticle (non-EDM4hep)2022-08-05T03:34:48ZWouter Deconinckfeat*: remove deprecated BasicParticle (non-EDM4hep)Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/86feat: use the UPSTREAM_EDM cmake option (NEEDS podio > 0.14.3)2022-08-23T20:20:55ZWouter Deconinckfeat: use the UPSTREAM_EDM cmake option (NEEDS podio > 0.14.3)This will allow eicd to use the upstream edm4hep instead of reimplementing it.
This will maintain the associations with explicit indices for now, since they are easier to use outside of ROOT-based environments.
- [X] revert https://eic...This will allow eicd to use the upstream edm4hep instead of reimplementing it.
This will maintain the associations with explicit indices for now, since they are easier to use outside of ROOT-based environments.
- [X] revert https://eicweb.phy.anl.gov/EIC/eicd/-/commit/a906e3cd52fad2e0b48a19fea6c5d4384513959cWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/85feat: add github actions workflow build-test2022-07-24T16:57:03ZWouter Deconinckfeat: add github actions workflow build-testWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/84eic_data.yaml: simID as uint32_t for compatibility with id()2022-03-28T00:20:18ZWouter Deconinckeic_data.yaml: simID as uint32_t for compatibility with id()Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/83Remove Vector2f(float aa, float bb) etc.2022-03-21T22:24:54ZWouter DeconinckRemove Vector2f(float aa, float bb) etc.Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/82eic_data.yaml: static_casting constructors from double2022-03-21T20:45:31ZWouter Deconinckeic_data.yaml: static_casting constructors from doubleTo avoid narrowing warnings and errors which are fully anticipated by the choice of data model, we introduce here e.g.
```c++
Vector2f(double aa, double bb)\n
: a{static_cast<float>(aa)},b{static_cast<float>(bb)} {}\n
`...To avoid narrowing warnings and errors which are fully anticipated by the choice of data model, we introduce here e.g.
```c++
Vector2f(double aa, double bb)\n
: a{static_cast<float>(aa)},b{static_cast<float>(bb)} {}\n
```
Other changes:
- initializer lists in constructors
- bugfix in Cov4fWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/81Mutable datatypes in podio@0.14.1 and later2022-03-20T01:44:46ZWouter DeconinckMutable datatypes in podio@0.14.1 and laterWouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/80Resolve "Move closer to EDM4hep (part 2)"2022-03-01T18:49:42ZSylvester JoostenResolve "Move closer to EDM4hep (part 2)"Closes #24Closes #24Sylvester JoostenSylvester Joostenhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/79Resolve "C++17 compatibility for vector_utils.h"2022-02-22T22:55:32ZSylvester JoostenResolve "C++17 compatibility for vector_utils.h"Closes #25Closes #25Sylvester JoostenSylvester Joostenhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/78Resolve "Move closer to EDM4hep (part 2)"2022-02-28T23:17:22ZSylvester JoostenResolve "Move closer to EDM4hep (part 2)"Closes #24Closes #24Sylvester JoostenSylvester Joostenhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/77target_link_libraries(eicd PUBLIC EDM4HEP::edm4hep)2022-02-22T05:26:12ZWouter Deconincktarget_link_libraries(eicd PUBLIC EDM4HEP::edm4hep)Wouter DeconinckWouter Deconinckhttps://eicweb.phy.anl.gov/EIC/eicd/-/merge_requests/76find_package EDM4HEP2022-02-22T04:30:12ZWouter Deconinckfind_package EDM4HEPWouter DeconinckWouter Deconinck